diff mbox series

gcc: depend on zstd

Message ID 20230927104922.3734608-1-sean@geanix.com
State Accepted, archived
Commit 2f6e3d32ad73ef8e0e3d3b89702d85c36358c00c
Headers show
Series gcc: depend on zstd | expand

Commit Message

Sean Nyekjaer Sept. 27, 2023, 10:49 a.m. UTC
Add zstd LTO support for the nativesdk compiler.

---
% x86_64-oe-linux-gcc -v
[...]
 Supported LTO compression algorithms: zlib zstd
 gcc version 12.2.0 (GCC)
% x86_64-oesdk-linux-gcc -v
[...]
 Supported LTO compression algorithms: zlib
 gcc version 12.2.0 (GCC)
---

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 meta/recipes-devtools/gcc/gcc-13.2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Sept. 27, 2023, 11:17 a.m. UTC | #1
On Wed, 2023-09-27 at 12:49 +0200, Sean Nyekjaer wrote:
> Add zstd LTO support for the nativesdk compiler.

This is changing it for the target compiler as well? 

Perhaps also mention it brings it into sync with gcc-cross (assuming it
does?).

Cheers,

Richard
Sean Nyekjaer Sept. 27, 2023, 11:22 a.m. UTC | #2
> On 27 Sep 2023, at 13.17, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> 
> On Wed, 2023-09-27 at 12:49 +0200, Sean Nyekjaer wrote:
>> Add zstd LTO support for the nativesdk compiler.
> 
> This is changing it for the target compiler as well? 
> 
> Perhaps also mention it brings it into sync with gcc-cross (assuming it
> does?).
> 
> Cheers,
> 
> Richard
> 

Hi Richard,

It looks like the target compiler(x86_64-oe-linux) already had zstd support.

---
% x86_64-oe-linux-gcc -v
[...]
Supported LTO compression algorithms: zlib zstd
gcc version 12.2.0 (GCC)
% x86_64-oesdk-linux-gcc -v
[...]
Supported LTO compression algorithms: zlib
gcc version 12.2.0 (GCC)
—

Or I’m wrong?

Br,
/Sean
Richard Purdie Sept. 27, 2023, 11:29 a.m. UTC | #3
On Wed, 2023-09-27 at 13:22 +0200, Sean Nyekjaer wrote:
> 
> > On 27 Sep 2023, at 13.17, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > 
> > On Wed, 2023-09-27 at 12:49 +0200, Sean Nyekjaer wrote:
> > > Add zstd LTO support for the nativesdk compiler.
> > 
> > This is changing it for the target compiler as well? 
> > 
> > Perhaps also mention it brings it into sync with gcc-cross (assuming it
> > does?).
> > 
> > Cheers,
> > 
> > Richard
> > 
> 
> Hi Richard,
> 
> It looks like the target compiler(x86_64-oe-linux) already had zstd support.
> 
> ---
> % x86_64-oe-linux-gcc -v
> [...]
> Supported LTO compression algorithms: zlib zstd
> gcc version 12.2.0 (GCC)
> % x86_64-oesdk-linux-gcc -v
> [...]
> Supported LTO compression algorithms: zlib
> gcc version 12.2.0 (GCC)
> —
> 
> Or I’m wrong?

Sorry, I mean the on target compiler, i.e. if you boot an image with
gcc in it. I think it might be missing there. The compiler above is
what I'd refer to as the cross compiler.

I'd just like to be clear in the commit message what the current state
is and which ones are changing. I do agree we should bring them into
sync.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-13.2.inc b/meta/recipes-devtools/gcc/gcc-13.2.inc
index d96f3171e4..359db1e278 100644
--- a/meta/recipes-devtools/gcc/gcc-13.2.inc
+++ b/meta/recipes-devtools/gcc/gcc-13.2.inc
@@ -10,7 +10,7 @@  BINV = "13.2.0"
 
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/gcc:${FILE_DIRNAME}/gcc/backport:"
 
-DEPENDS =+ "mpfr gmp libmpc zlib flex-native"
+DEPENDS =+ "mpfr gmp libmpc zlib zstd flex-native"
 NATIVEDEPS = "mpfr-native gmp-native libmpc-native zlib-native flex-native zstd-native"
 
 LICENSE = "GPL-3.0-with-GCC-exception & GPL-3.0-only"