| Submitter | Jesse Zhang |
|---|---|
| Date | July 3, 2012, 8:49 a.m. |
| Message ID | <1341305368-30561-1-git-send-email-sen.zhang@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/31083/ |
| State | New |
| Headers | show |
Comments
Op 3 jul. 2012, om 10:49 heeft Jesse Zhang het volgende geschreven: > mount.sh mounts all partitions with -o sync, which is bad for system > performance. But good for data integrity :) > Signed-off-by: Jesse Zhang <sen.zhang@windriver.com> > --- > meta/recipes-core/udev/udev/mount.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh > index 53fefa3..c13b8bb 100644 > --- a/meta/recipes-core/udev/udev/mount.sh > +++ b/meta/recipes-core/udev/udev/mount.sh > @@ -23,7 +23,7 @@ automount() { > > ! test -d "/media/$name" && mkdir -p "/media/$name" > > - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name" > + if ! $MOUNT -t auto $DEVNAME "/media/$name" > then > #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!" > rm_dir "/media/$name" Missing PR bump
On 07/03/2012 06:41 PM, Koen Kooi wrote: > > Op 3 jul. 2012, om 10:49 heeft Jesse Zhang het volgende geschreven: > >> mount.sh mounts all partitions with -o sync, which is bad for system >> performance. > > But good for data integrity :) Who cares about integrity as long as it's blazing fast :P But I see the same was done for meta-openembedded. commit 88295fc7dd7bf79b6eb2decfc64467defe829df8 Author: Koen Kooi <koen@dominion.thruhere.net> Date: Mon May 16 15:37:36 2011 +0200 udev: update to 168 - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name" + if ! $MOUNT -t auto -o async,relatime $DEVNAME "/media/$name" I omitted async,relatime since I think they are the default. >> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com> >> --- >> meta/recipes-core/udev/udev/mount.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh >> index 53fefa3..c13b8bb 100644 >> --- a/meta/recipes-core/udev/udev/mount.sh >> +++ b/meta/recipes-core/udev/udev/mount.sh >> @@ -23,7 +23,7 @@ automount() { >> >> ! test -d "/media/$name" && mkdir -p "/media/$name" >> >> - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name" >> + if ! $MOUNT -t auto $DEVNAME "/media/$name" >> then >> #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!" >> rm_dir "/media/$name" > > Missing PR bump Oh. Sorry I didn't realized about that. jesse
On 07/03/2012 01:49 AM, Jesse Zhang wrote: > mount.sh mounts all partitions with -o sync, which is bad for system > performance. > > Signed-off-by: Jesse Zhang <sen.zhang@windriver.com> > --- > meta/recipes-core/udev/udev/mount.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh > index 53fefa3..c13b8bb 100644 > --- a/meta/recipes-core/udev/udev/mount.sh > +++ b/meta/recipes-core/udev/udev/mount.sh > @@ -23,7 +23,7 @@ automount() { > > ! test -d "/media/$name" && mkdir -p "/media/$name" > > - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name" > + if ! $MOUNT -t auto $DEVNAME "/media/$name" > then > #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!" > rm_dir "/media/$name" > Merged into OE-Core Thanks Sau!
Patch
diff --git a/meta/recipes-core/udev/udev/mount.sh b/meta/recipes-core/udev/udev/mount.sh index 53fefa3..c13b8bb 100644 --- a/meta/recipes-core/udev/udev/mount.sh +++ b/meta/recipes-core/udev/udev/mount.sh @@ -23,7 +23,7 @@ automount() { ! test -d "/media/$name" && mkdir -p "/media/$name" - if ! $MOUNT -t auto -o sync $DEVNAME "/media/$name" + if ! $MOUNT -t auto $DEVNAME "/media/$name" then #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!" rm_dir "/media/$name"
mount.sh mounts all partitions with -o sync, which is bad for system performance. Signed-off-by: Jesse Zhang <sen.zhang@windriver.com> --- meta/recipes-core/udev/udev/mount.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)