Patchwork [PATCHv2,3/3] u-boot: do not clobber PARALLEL_MAKE setting

login
register
mail settings
Submitter Paul Gortmaker
Date July 2, 2012, 5:44 a.m.
Message ID <1341207885-9463-4-git-send-email-paul.gortmaker@windriver.com>
Download mbox | patch
Permalink /patch/30975/
State Accepted
Commit 7fdd1f82803df9752e908f01f7643d66b82a690e
Headers show

Comments

Paul Gortmaker - July 2, 2012, 5:44 a.m.
The u-boot tree is fully capable of parallel builds, so this
setting should not exist as a blanket setting for all of the
recipes.  Going forward, if there is a parallelism issue
in u-boot, it needs to be reported and fixed there, and not
with the "make -j1" band-aid approach.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 meta/recipes-bsp/u-boot/u-boot.inc |    2 --
 1 file changed, 2 deletions(-)
Otavio Salvador - July 2, 2012, 11:25 a.m.
On Mon, Jul 2, 2012 at 2:44 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The u-boot tree is fully capable of parallel builds, so this
> setting should not exist as a blanket setting for all of the
> recipes.  Going forward, if there is a parallelism issue
> in u-boot, it needs to be reported and fixed there, and not
> with the "make -j1" band-aid approach.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

I've been building it with -j12 for long time, it does work :-)

Patch

diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
index 3226bd4..3df7418 100644
--- a/meta/recipes-bsp/u-boot/u-boot.inc
+++ b/meta/recipes-bsp/u-boot/u-boot.inc
@@ -5,8 +5,6 @@  PROVIDES = "virtual/bootloader"
 
 inherit deploy
 
-PARALLEL_MAKE=""
-
 EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX}"
 
 python () {