From patchwork Sat Jun 30 19:34:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel] git: do not execute 'git remote prune' Date: Sat, 30 Jun 2012 19:34:56 -0000 From: Enrico Scholz X-Patchwork-Id: 30957 Message-Id: <1341084896-29686-1-git-send-email-enrico.scholz@sigma-chemnitz.de> To: bitbake-devel@lists.openembedded.org Cc: Enrico Scholz 'git remote prune' at this location does not make much sense because the following 'git remote rm' will prune stale and non-stale branches. The 'prune' can cause trouble because it will access the network bypassing the no-network code in bitbake. When this operation fails and throws an exception, the next command (--> 'git remote rm') will be skipped. This in turn, will make all the following operations fail, because they assume that the remote does not exist yet. Signed-off-by: Enrico Scholz --- lib/bb/fetch2/git.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py index 8544860..c5ccdfd 100644 --- a/lib/bb/fetch2/git.py +++ b/lib/bb/fetch2/git.py @@ -207,7 +207,6 @@ class Git(FetchMethod): needupdate = True if needupdate: try: - runfetchcmd("%s remote prune origin" % ud.basecmd, d) runfetchcmd("%s remote rm origin" % ud.basecmd, d) except bb.fetch2.FetchError: logger.debug(1, "No Origin")