| Submitter | Saul Wold |
|---|---|
| Date | June 29, 2012, 9:21 p.m. |
| Message ID | <d273d0ea0fd0059499c54b68ba420043a31f2bb7.1341004548.git.sgw@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/30901/ |
| State | Accepted |
| Commit | b41b2bc584756956a48c9c5f91e7337e821105b2 |
| Headers | show |
Comments
On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com> wrote: > By doing this we can easily add addtional packages that can be > greedy before PN, but after some of the other standard packages. > > This will also allow us to simplify the lib_package class to set > this variable. > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/conf/bitbake.conf | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 9377ee6..df4907e 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -254,7 +254,8 @@ SOLIBSDEV_darwin = ".dylib" > SOLIBSDEV_darwin8 = ".dylib" > SOLIBSDEV_darwin9 = ".dylib" > > -PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc ${PN}-locale ${PN}" > +PACKAGE_BEFORE_PN ?= "" > +PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}" > PACKAGES_DYNAMIC = "${PN}-locale-*" > FILES = "" > Can it appear at the beginning before pn-dbg? Then you could just prepend I don't think any of those predefined packages will have anything of interest that's in pn-bin > -- > 1.7.10.4 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On 06/29/2012 02:52 PM, Khem Raj wrote: > > > On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com > <mailto:sgw@linux.intel.com>> wrote: > > By doing this we can easily add addtional packages that can be > > greedy before PN, but after some of the other standard packages. > > > > This will also allow us to simplify the lib_package class to set > > this variable. > > > > Signed-off-by: Saul Wold <sgw@linux.intel.com > <mailto:sgw@linux.intel.com>> > > --- > > meta/conf/bitbake.conf | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > > index 9377ee6..df4907e 100644 > > --- a/meta/conf/bitbake.conf > > +++ b/meta/conf/bitbake.conf > > @@ -254,7 +254,8 @@ SOLIBSDEV_darwin = ".dylib" > > SOLIBSDEV_darwin8 = ".dylib" > > SOLIBSDEV_darwin9 = ".dylib" > > > > -PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc > ${PN}-locale ${PN}" > > +PACKAGE_BEFORE_PN ?= "" > > +PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc > ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}" > > PACKAGES_DYNAMIC = "${PN}-locale-*" > > FILES = "" > > > > > Can it appear at the beginning before pn-dbg? > Then you could just prepend I don't think any of those predefined > packages will have anything of interest that's in pn-bin No that's won't work since pn-dev wants to get -config binaries and sometimes there are other binaries that pn-dev wants, I did try that initially, by having -bin in front with =+ and got failures. This has been a tricky set of changes to deal with. Sau! > > -- > > 1.7.10.4 > > > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org> > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com> wrote: > On 06/29/2012 02:52 PM, Khem Raj wrote: >> >> >> On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com >> <mailto:sgw@linux.intel.com>> wrote: >> > By doing this we can easily add addtional packages that can be >> > greedy before PN, but after some of the other standard packages. >> > >> > This will also allow us to simplify the lib_package class to set >> > this variable. >> > >> > Signed-off-by: Saul Wold <sgw@linux.intel.com >> <mailto:sgw@linux.intel.com>> >> > --- >> > meta/conf/bitbake.conf | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> > index 9377ee6..df4907e 100644 >> > --- a/meta/conf/bitbake.conf >> > +++ b/meta/conf/bitbake.conf >> > @@ -254,7 +254,8 @@ SOLIBSDEV_darwin = ".dylib" >> > SOLIBSDEV_darwin8 = ".dylib" >> > SOLIBSDEV_darwin9 = ".dylib" >> > >> > -PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc >> ${PN}-locale ${PN}" >> > +PACKAGE_BEFORE_PN ?= "" >> > +PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc >> ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}" >> > PACKAGES_DYNAMIC = "${PN}-locale-*" >> > FILES = "" >> > >> >> >> Can it appear at the beginning before pn-dbg? >> Then you could just prepend I don't think any of those predefined >> packages will have anything of interest that's in pn-bin > > No that's won't work since pn-dev wants to get -config binaries and sometimes there are other binaries that pn-dev wants, I did try that initially, by having -bin in front with =+ and got failures. > > This has been a tricky set of changes to deal with. Hmm this variable really looks very specific not something for general bitbake.conf I think Can pn-bin appear after pn since in case of libraries on should not have much interest in binaries > Sau! > >> > -- >> > 1.7.10.4 >> > >> > >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> <mailto:Openembedded-core@lists.openembedded.org> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com> wrote: > On 06/29/2012 02:52 PM, Khem Raj wrote: >> >> >> On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com >> <mailto:sgw@linux.intel.com>> wrote: >> > By doing this we can easily add addtional packages that can be >> > greedy before PN, but after some of the other standard packages. >> > >> > This will also allow us to simplify the lib_package class to set >> > this variable. >> > >> > Signed-off-by: Saul Wold <sgw@linux.intel.com >> <mailto:sgw@linux.intel.com>> >> > --- >> > meta/conf/bitbake.conf | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >> > index 9377ee6..df4907e 100644 >> > --- a/meta/conf/bitbake.conf >> > +++ b/meta/conf/bitbake.conf >> > @@ -254,7 +254,8 @@ SOLIBSDEV_darwin = ".dylib" >> > SOLIBSDEV_darwin8 = ".dylib" >> > SOLIBSDEV_darwin9 = ".dylib" >> > >> > -PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc >> ${PN}-locale ${PN}" >> > +PACKAGE_BEFORE_PN ?= "" >> > +PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc >> ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}" >> > PACKAGES_DYNAMIC = "${PN}-locale-*" >> > FILES = "" >> > >> >> >> Can it appear at the beginning before pn-dbg? >> Then you could just prepend I don't think any of those predefined >> packages will have anything of interest that's in pn-bin > > No that's won't work since pn-dev wants to get -config binaries and sometimes there are other binaries that pn-dev wants, I did try that initially, by having -bin in front with =+ and got failures. > > This has been a tricky set of changes to deal with. Hmm this variable really looks very specific not something for general bitbake.conf I think Can pn-bin appear after pn since in case of libraries on should not have much interest > Sau! > >> > -- >> > 1.7.10.4 >> > >> > >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> <mailto:Openembedded-core@lists.openembedded.org> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On 06/29/2012 03:09 PM, Khem Raj wrote: > > > On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com > <mailto:sgw@linux.intel.com>> wrote: > > On 06/29/2012 02:52 PM, Khem Raj wrote: > >> > >> > >> On Friday, June 29, 2012, Saul Wold <sgw@linux.intel.com > <mailto:sgw@linux.intel.com> > >> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>> wrote: > >> > By doing this we can easily add addtional packages that can be > >> > greedy before PN, but after some of the other standard packages. > >> > > >> > This will also allow us to simplify the lib_package class to set > >> > this variable. > >> > > >> > Signed-off-by: Saul Wold <sgw@linux.intel.com > <mailto:sgw@linux.intel.com> > >> <mailto:sgw@linux.intel.com <mailto:sgw@linux.intel.com>>> > >> > --- > >> > meta/conf/bitbake.conf | 3 ++- > >> > 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > >> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > >> > index 9377ee6..df4907e 100644 > >> > --- a/meta/conf/bitbake.conf > >> > +++ b/meta/conf/bitbake.conf > >> > @@ -254,7 +254,8 @@ SOLIBSDEV_darwin = ".dylib" > >> > SOLIBSDEV_darwin8 = ".dylib" > >> > SOLIBSDEV_darwin9 = ".dylib" > >> > > >> > -PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc > >> ${PN}-locale ${PN}" > >> > +PACKAGE_BEFORE_PN ?= "" > >> > +PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc > >> ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}" > >> > PACKAGES_DYNAMIC = "${PN}-locale-*" > >> > FILES = "" > >> > > >> > >> > >> Can it appear at the beginning before pn-dbg? > >> Then you could just prepend I don't think any of those predefined > >> packages will have anything of interest that's in pn-bin > > > > No that's won't work since pn-dev wants to get -config binaries and > sometimes there are other binaries that pn-dev wants, I did try that > initially, by having -bin in front with =+ and got failures. > > > > This has been a tricky set of changes to deal with. > > > Hmm this variable really looks very specific not something for general > bitbake.conf I think > Can pn-bin appear after pn since in case of libraries on should not > have much interest No it can't appear after because PN is greedy and will grab all the bindir and base_bindir executable. If anything I could move PN-bin definition back into lib_package, but I found it clear to define it in bitbake.conf with all the other PN-* definitions. Sau! > > Sau! > > > >> > -- > >> > 1.7.10.4 > >> > > >> > > >> > _______________________________________________ > >> > Openembedded-core mailing list > >> > Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org> > >> <mailto:Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org>> > >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >> > > >> > >> > >> _______________________________________________ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org> > >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >
On Fri, Jun 29, 2012 at 3:16 PM, Saul Wold <sgw@linux.intel.com> wrote: > > No it can't appear after because PN is greedy and will grab all the bindir > and base_bindir executable. If anything I could move PN-bin definition back > into lib_package, but I found it clear to define it in bitbake.conf with all > the other PN-* definitions. right. In this case I think adding a variable is ok probably
Patch
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 9377ee6..df4907e 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -254,7 +254,8 @@ SOLIBSDEV_darwin = ".dylib" SOLIBSDEV_darwin8 = ".dylib" SOLIBSDEV_darwin9 = ".dylib" -PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc ${PN}-locale ${PN}" +PACKAGE_BEFORE_PN ?= "" +PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN}-doc ${PN}-locale ${PACKAGE_BEFORE_PN} ${PN}" PACKAGES_DYNAMIC = "${PN}-locale-*" FILES = ""
By doing this we can easily add addtional packages that can be greedy before PN, but after some of the other standard packages. This will also allow us to simplify the lib_package class to set this variable. Signed-off-by: Saul Wold <sgw@linux.intel.com> --- meta/conf/bitbake.conf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)