Patchwork [4/5] tasl-core-sdk: Add kernel-dev to task-core-sdk RDEPENDS

login
register
mail settings
Submitter Darren Hart
Date June 29, 2012, 7:54 p.m.
Message ID <53ce203eec118e3d5b0faac4c8e71f69c9857146.1340998763.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/30895/
State New
Headers show

Comments

Darren Hart - June 29, 2012, 7:54 p.m.
Add kernel-dev to task-core-sdk so it will be included with
core-image-sato-sdk and similar image recipes. This enables
building Linux kernel modules on the target.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Jessica Zhang <jessica.zhang@intel.com>
---
 meta/recipes-core/tasks/task-core-sdk.bb |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Darren Hart - June 29, 2012, 7:59 p.m.
s/tasl-core-sdk/task-core-sdk/ in subject fixed in branch.
Khem Raj - June 29, 2012, 9:59 p.m.
On Friday, June 29, 2012, Darren Hart <dvhart@linux.intel.com> wrote:
> Add kernel-dev to task-core-sdk so it will be included with
> core-image-sato-sdk and similar image recipes. This enables
> building Linux kernel modules on the target.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Jessica Zhang <jessica.zhang@intel.com>
> ---
>  meta/recipes-core/tasks/task-core-sdk.bb |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/tasks/task-core-sdk.bbb/meta/recipes-core/tasks/
task-core-sdk.bb
> index ec6cdcc..d65a53a 100644
> --- a/meta/recipes-core/tasks/task-core-sdk.bb
> +++ b/meta/recipes-core/tasks/task-core-sdk.bb
> @@ -7,7 +7,7 @@ LICENSE = "MIT"
>  LIC_FILES_CHKSUM =
"file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>
file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>  DEPENDS = "task-core-console"
> -PR = "r7"
> +PR = "r8"
>
>  ALLOW_EMPTY = "1"
>  #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
> @@ -46,7 +46,8 @@ RDEPENDS_task-core-sdk = "\
>     distcc \
>     ldd \
>     file \
> -    tcl"
> +    tcl \
> +    kernel-dev"

Doesn't this.make sdk to be machine specific now
>
>  #python generate_sdk_pkgs () {
>  #    poky_pkgs = read_pkgdata('task-core', d)['PACKAGES']
> --
> 1.7.10.2
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
Darren Hart - June 29, 2012, 11:01 p.m.
On 06/29/2012 02:59 PM, Khem Raj wrote:

>>  ALLOW_EMPTY = "1"
>>  #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
>> @@ -46,7 +46,8 @@ RDEPENDS_task-core-sdk = "\
>>     distcc \
>>     ldd \
>>     file \
>> -    tcl"
>> +    tcl \
>> +    kernel-dev"
> 
> Doesn't this.make sdk to be machine specific now

It does indeed as the kernel-dev contains the system map, config, and
possibly even modified headers dependingon the KBRANCH.

Is task-core-sdk intended to be only architecture specific?

If so, I can just add kernel-dev to the -sdk image recipes directly
rather than modifying task-core-sdk.

Jessica, any opinion here?
Jessica Zhang - June 29, 2012, 11:23 p.m.
Hi Darren,

I think add kernel-dev to sdk image is a better approach for what you're trying to achieve.

Thanks,
Jessica

-----Original Message-----
From: Darren Hart [mailto:dvhart@linux.intel.com]
Sent: Friday, June 29, 2012 4:02 PM
To: Khem Raj
Cc: Poky; openembedded-core@lists.openembedded.org; Bodke, Kishore K; Zhang, Jessica
Subject: Re: [poky] [PATCH 4/5] tasl-core-sdk: Add kernel-dev to task-core-sdk RDEPENDS

On 06/29/2012 02:59 PM, Khem Raj wrote:

>>  ALLOW_EMPTY = "1"
>>  #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
>> @@ -46,7 +46,8 @@ RDEPENDS_task-core-sdk = "\
>>     distcc \
>>     ldd \
>>     file \
>> -    tcl"
>> +    tcl \
>> +    kernel-dev"
>
> Doesn't this.make sdk to be machine specific now

It does indeed as the kernel-dev contains the system map, config, and possibly even modified headers dependingon the KBRANCH.

Is task-core-sdk intended to be only architecture specific?

If so, I can just add kernel-dev to the -sdk image recipes directly rather than modifying task-core-sdk.

Jessica, any opinion here?

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
Darren Hart - June 29, 2012, 11:27 p.m.
On 06/29/2012 04:23 PM, Zhang, Jessica wrote:
> Hi Darren,
> 
> I think add kernel-dev to sdk image is a better approach for what you're trying to achieve.

OK, I'll go that route in the upcoming V3.

Thanks,

Darren

> 
> Thanks,
> Jessica
> 
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@linux.intel.com]
> Sent: Friday, June 29, 2012 4:02 PM
> To: Khem Raj
> Cc: Poky; openembedded-core@lists.openembedded.org; Bodke, Kishore K; Zhang, Jessica
> Subject: Re: [poky] [PATCH 4/5] tasl-core-sdk: Add kernel-dev to task-core-sdk RDEPENDS
> 
> On 06/29/2012 02:59 PM, Khem Raj wrote:
> 
>>>  ALLOW_EMPTY = "1"
>>>  #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
>>> @@ -46,7 +46,8 @@ RDEPENDS_task-core-sdk = "\
>>>     distcc \
>>>     ldd \
>>>     file \
>>> -    tcl"
>>> +    tcl \
>>> +    kernel-dev"
>>
>> Doesn't this.make sdk to be machine specific now
> 
> It does indeed as the kernel-dev contains the system map, config, and possibly even modified headers dependingon the KBRANCH.
> 
> Is task-core-sdk intended to be only architecture specific?
> 
> If so, I can just add kernel-dev to the -sdk image recipes directly rather than modifying task-core-sdk.
> 
> Jessica, any opinion here?
> 
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> 
>

Patch

diff --git a/meta/recipes-core/tasks/task-core-sdk.bb b/meta/recipes-core/tasks/task-core-sdk.bb
index ec6cdcc..d65a53a 100644
--- a/meta/recipes-core/tasks/task-core-sdk.bb
+++ b/meta/recipes-core/tasks/task-core-sdk.bb
@@ -7,7 +7,7 @@  LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 DEPENDS = "task-core-console"
-PR = "r7"
+PR = "r8"
 
 ALLOW_EMPTY = "1"
 #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
@@ -46,7 +46,8 @@  RDEPENDS_task-core-sdk = "\
     distcc \
     ldd \
     file \
-    tcl"
+    tcl \
+    kernel-dev"
 
 #python generate_sdk_pkgs () {
 #    poky_pkgs = read_pkgdata('task-core', d)['PACKAGES']