From patchwork Wed Sep 20 17:51:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoann Congal X-Patchwork-Id: 30823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA73CC04ABC for ; Wed, 20 Sep 2023 17:52:28 +0000 (UTC) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mx.groups.io with SMTP id smtpd.web11.2074.1695232347017467228 for ; Wed, 20 Sep 2023 10:52:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@smile-fr.20230601.gappssmtp.com header.s=20230601 header.b=iB3RGKAq; spf=pass (domain: smile.fr, ip: 209.85.218.41, mailfrom: yoann.congal@smile.fr) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-99de884ad25so949967466b.3 for ; Wed, 20 Sep 2023 10:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile-fr.20230601.gappssmtp.com; s=20230601; t=1695232345; x=1695837145; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AqW8p05LQ1ZdaLJd3z3v1iAktDyKMLFy4Hq0rgtzf1w=; b=iB3RGKAqvc0fjg5okEmlSI9jq+GHhzoVCutn8i8kMKi1oLF7aapAZNzj4St1pu1Y8n br4OS46bfKAUo6HS1NYZXbNyNuSVVSlMXWWqbmA1i8b6YeEzzM+/2mez5jcqLUoU6nY/ k7bRO49LWdurNwF7obAsrYvy5XaR/EjxH53r//Um87mukYM4MJUreC4AwYp/IBffVrWL mF9ycPgnqz5w4a6S/S+a9pXgykWyLPGLZIwCgL8VlncyArxZnFosSxl90RMBgLuuB0JM xs5Gub534uytNy16oyJHK6kDzU6Pa8HfN8naPI+UNUzPafY0jA774549dCkmseKFkp2e E5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695232345; x=1695837145; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AqW8p05LQ1ZdaLJd3z3v1iAktDyKMLFy4Hq0rgtzf1w=; b=KluxPRDpQ8ZqLjmed7aiEYtvQxE8NFX1Z197gxbRGh/xo+++JxORblgfnct+YPDdtR CCBC8IEE1fWrzAfIYfbY7yJqasCq5ubMoaMIBTGLgOe6PYkIRHRinVfXboS2SuK8iTjU hrgc1OPYZ3pbGCqOSdyRtij0QFofUatri2rZkXqcomnDHv6+U8riZZ3M7xUUxPTZWxfg BXUOm7H0jAkTc3fTe7TaXCrtuMyCmLCcNZTjb2b1v450Ovr8Q/6ih1HZGWx0yH3kjD+T q/cce71ElwpHr3b2OPDQe3cGJNLZO7tQLqh2cSQwJx92/Btvc7t9zM9MdY4hA0fL7Jqt VR4w== X-Gm-Message-State: AOJu0Yz7k7nFq9KaWSkRdmUZuW0t/ZiWwQbQlEE3kDQqVudDWcLcKOUT WRQFwNW+d7U8GRU0NlVm/X7C9cIQejXO4DZHKDU= X-Google-Smtp-Source: AGHT+IFuidNZIYlWWwyLaRnB0g5l8eMlY2r2e+6uXqhetrpw+lpbBYQqxk9kF7YsmTSBOdVkTn5s2Q== X-Received: by 2002:a17:906:57:b0:9a1:edfd:73b2 with SMTP id 23-20020a170906005700b009a1edfd73b2mr3142094ejg.2.1695232345307; Wed, 20 Sep 2023 10:52:25 -0700 (PDT) Received: from P-ASN-ECS-830T8C3.local ([2a04:cec0:1092:a137:6566:f57c:ee5b:7a23]) by smtp.gmail.com with ESMTPSA id rl20-20020a1709076c1400b009adc81c0c7esm8463946ejc.107.2023.09.20.10.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 10:52:24 -0700 (PDT) From: Yoann Congal To: openembedded-core@lists.openembedded.org Cc: Steve Sakoman , Jaeyoon Jung , Richard Purdie , Yoann Congal Subject: [mickledore][PATCH] cml1: Fix KCONFIG_CONFIG_COMMAND not conveyed fully in do_menuconfig Date: Wed, 20 Sep 2023 19:51:37 +0200 Message-Id: <20230920175136.2872181-1-yoann.congal@smile.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 20 Sep 2023 17:52:28 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/187934 From: Jaeyoon Jung Variable overrides in KCONFIG_CONFIG_COMMAND do not work as expected due to double quote mismatches. The issue is reproducible in an environment where gold is the default linker. Below is an example snippet of run.do_terminal generated by do_menuconfig. do_terminal() { exec sh -c "make menuconfig CC="aarch64-webos-linux-gcc ..." LD="aarch64-webos-linux-ld.bfd ..." ... } Although LD override is set to bfd correctly, it is not passed to make and make menuconfig ends up with messages like: | gold linker is not supported as it is not capable of linking the kernel proper. | scripts/Kconfig.include:56: Sorry, this linker is not supported. (From OE-Core rev: 9c483765db762dbe8020423c8778518612b7e5f7) Signed-off-by: Jaeyoon Jung Signed-off-by: Richard Purdie (cherry picked from commit d4664d2b7974354e73d891762ebb2c8a12d62438) Signed-off-by: Yoann Congal --- This backport request was prompted by the following OE-Core mailing list thread : https://lists.yoctoproject.org/g/yocto/topic/100872991#60840 This patch does fix the problem and apply cleanly on mickledore. meta/classes-recipe/cml1.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes-recipe/cml1.bbclass b/meta/classes-recipe/cml1.bbclass index a09a042c3f..73c22f81d6 100644 --- a/meta/classes-recipe/cml1.bbclass +++ b/meta/classes-recipe/cml1.bbclass @@ -53,7 +53,7 @@ python do_menuconfig() { # ensure that environment variables are overwritten with this tasks 'd' values d.appendVar("OE_TERMINAL_EXPORTS", " PKG_CONFIG_DIR PKG_CONFIG_PATH PKG_CONFIG_LIBDIR PKG_CONFIG_SYSROOT_DIR") - oe_terminal("sh -c \"make %s; if [ \\$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'), + oe_terminal("sh -c 'make %s; if [ \\$? -ne 0 ]; then echo \"Command failed.\"; printf \"Press any key to continue... \"; read r; fi'" % d.getVar('KCONFIG_CONFIG_COMMAND'), d.getVar('PN') + ' Configuration', d) # FIXME this check can be removed when the minimum bitbake version has been bumped