Patchwork [2/3] apr: add util-linux to DEPENDS for libuuid

login
register
mail settings
Submitter Paul Eggleton
Date June 28, 2012, 6:29 p.m.
Message ID <dfdd61d5d2f3c413b6b19db1b9d9371e46b32aa5.1340908084.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/30821/
State Accepted
Commit b880cebf503ca13cd4fcb741895e57e6353065be
Headers show

Comments

Paul Eggleton - June 28, 2012, 6:29 p.m.
apr will use libuuid if it is present, and thus we should require that
it is there so that we have a deterministic build.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/recipes-support/apr/apr_1.4.6.bb |    1 +
 1 file changed, 1 insertion(+)
Khem Raj - June 29, 2012, 2:48 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/28/2012 11:29 AM, Paul Eggleton wrote:
> apr will use libuuid if it is present, and thus we should require
> that it is there so that we have a deterministic build.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> --- 
> meta/recipes-support/apr/apr_1.4.6.bb |    1 + 1 file changed, 1
> insertion(+)
> 
> diff --git a/meta/recipes-support/apr/apr_1.4.6.bb
> b/meta/recipes-support/apr/apr_1.4.6.bb index 6cd37f1..54c47fe
> 100644 --- a/meta/recipes-support/apr/apr_1.4.6.bb +++
> b/meta/recipes-support/apr/apr_1.4.6.bb @@ -1,6 +1,7 @@ DESCRIPTION
> = "Apache Portable Runtime (APR) library" HOMEPAGE =
> "http://apr.apache.org/" SECTION = "libs" +DEPENDS = "util-linux"
> 


interesting. I wonder if there is configure option to denote this
feature. May be its better to enable it explicitly along with this change


> LICENSE = "Apache-2.0" LIC_FILES_CHKSUM =
> "file://LICENSE;md5=0c35ff3c4c83b89d2f076e315caac28b \
> 


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAk/tF48ACgkQuwUzVZGdMxQydQCUCdoOXb+AV2vPY7OAcc0fiecF
sgCfRbcwcMIZfoVjZ+XCsh3H0cgzmOE=
=8BAs
-----END PGP SIGNATURE-----
Paul Eggleton - June 29, 2012, 10:03 a.m.
On Thursday 28 June 2012 19:48:47 Khem Raj wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 6/28/2012 11:29 AM, Paul Eggleton wrote:
> > apr will use libuuid if it is present, and thus we should require
> > that it is there so that we have a deterministic build.
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> ---
> > meta/recipes-support/apr/apr_1.4.6.bb |    1 + 1 file changed, 1
> > insertion(+)
> > 
> > diff --git a/meta/recipes-support/apr/apr_1.4.6.bb
> > b/meta/recipes-support/apr/apr_1.4.6.bb index 6cd37f1..54c47fe
> > 100644 --- a/meta/recipes-support/apr/apr_1.4.6.bb +++
> > b/meta/recipes-support/apr/apr_1.4.6.bb @@ -1,6 +1,7 @@ DESCRIPTION
> > = "Apache Portable Runtime (APR) library" HOMEPAGE =
> > "http://apr.apache.org/" SECTION = "libs" +DEPENDS = "util-linux"
> 
> interesting. I wonder if there is configure option to denote this
> feature. May be its better to enable it explicitly along with this change

There's no documented option - I can force ac_cv_osuuid but that doesn't 
actually have the desired effect (i.e. it does not make it fail if uuid isn't 
actually provided).

Cheers,
Paul

Patch

diff --git a/meta/recipes-support/apr/apr_1.4.6.bb b/meta/recipes-support/apr/apr_1.4.6.bb
index 6cd37f1..54c47fe 100644
--- a/meta/recipes-support/apr/apr_1.4.6.bb
+++ b/meta/recipes-support/apr/apr_1.4.6.bb
@@ -1,6 +1,7 @@ 
 DESCRIPTION = "Apache Portable Runtime (APR) library"
 HOMEPAGE = "http://apr.apache.org/"
 SECTION = "libs"
+DEPENDS = "util-linux"
 
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=0c35ff3c4c83b89d2f076e315caac28b \