Patchwork [3/4] eglibc: support mipsel little endian, filter out -march=mips32

login
register
mail settings
Submitter Khem Raj
Date June 28, 2012, 1:10 a.m.
Message ID <e7eb300513b285a6e90a46989ed283e1cf28bfc0.1340845612.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/30779/
State Accepted
Commit 6a013236d362874c661aa5f15b948aac32177181
Headers show

Comments

Khem Raj - June 28, 2012, 1:10 a.m.
From: Dennis Lan <dennis.yxun@gmail.com>

Quote for eglibc source:
 for mips eglibc now builds syscall tables for all abi's
 so we make sure that we choose right march option which is
 compatible with o32,n32 and n64 abi's
 e.g. -march=mips32 is not compatible with n32 and n64 therefore
 we filter it out in such case -march=from-abi which will be
 mips1 when using o32 and mips3 when using n32/n64

Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
---
 meta/recipes-core/eglibc/eglibc_2.15.bb |    1 +
 1 file changed, 1 insertion(+)
Dennis Lan - June 28, 2012, 9:37 a.m.
HI Raj:
   So this will eventually goes into OE-core, right?
   As I see Bruce has no response for the "override scheme"
so mips -> for big endian mips o32 (could be mipseb better?, less confusion)
and mipsel -> for little endian mips o32, they in same level, not of
one's subset

Dennis

On Thu, Jun 28, 2012 at 9:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
> From: Dennis Lan <dennis.yxun@gmail.com>
>
> Quote for eglibc source:
>  for mips eglibc now builds syscall tables for all abi's
>  so we make sure that we choose right march option which is
>  compatible with o32,n32 and n64 abi's
>  e.g. -march=mips32 is not compatible with n32 and n64 therefore
>  we filter it out in such case -march=from-abi which will be
>  mips1 when using o32 and mips3 when using n32/n64
>
> Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
> ---
>  meta/recipes-core/eglibc/eglibc_2.15.bb |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/eglibc/eglibc_2.15.bb b/meta/recipes-core/eglibc/eglibc_2.15.bb
> index e57a112..b2922b4 100644
> --- a/meta/recipes-core/eglibc/eglibc_2.15.bb
> +++ b/meta/recipes-core/eglibc/eglibc_2.15.bb
> @@ -101,6 +101,7 @@ do_patch_append() {
>  # mips1 when using o32 and mips3 when using n32/n64
>
>  TUNE_CCARGS_mips := "${@oe_filter_out('-march=mips32', '${TUNE_CCARGS}', d)}"
> +TUNE_CCARGS_mipsel := "${@oe_filter_out('-march=mips32', '${TUNE_CCARGS}', d)}"
>
>  # We need to ensure that all of the i386 and x86_64 headers are identical
>  # to support the multilib case.  We do this by copying headers from x86_64
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - June 28, 2012, 5:02 p.m.
On Thursday, June 28, 2012, Dennis.Yxun <dennis.yxun@gmail.com> wrote:
> HI Raj:
>   So this will eventually goes into OE-core, right?
>   As I see Bruce has no response for the "override scheme"
> so mips -> for big endian mips o32 (could be mipseb better?, less
confusion)

Mips has always meant big endian no need to change there


> and mipsel -> for little endian mips o32, they in same level, not of
> one's subset
>
> Dennis
>
> On Thu, Jun 28, 2012 at 9:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> From: Dennis Lan <dennis.yxun@gmail.com>
>>
>> Quote for eglibc source:
>>  for mips eglibc now builds syscall tables for all abi's
>>  so we make sure that we choose right march option which is
>>  compatible with o32,n32 and n64 abi's
>>  e.g. -march=mips32 is not compatible with n32 and n64 therefore
>>  we filter it out in such case -march=from-abi which will be
>>  mips1 when using o32 and mips3 when using n32/n64
>>
>> Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
>> ---
>>  meta/recipes-core/eglibc/eglibc_2.15.bb |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-core/eglibc/eglibc_2.15.bbb/meta/recipes-core/eglibc/
eglibc_2.15.bb
>> index e57a112..b2922b4 100644
>> --- a/meta/recipes-core/eglibc/eglibc_2.15.bb
>> +++ b/meta/recipes-core/eglibc/eglibc_2.15.bb
>> @@ -101,6 +101,7 @@ do_patch_append() {
>>  # mips1 when using o32 and mips3 when using n32/n64
>>
>>  TUNE_CCARGS_mips := "${@oe_filter_out('-march=mips32',
'${TUNE_CCARGS}', d)}"
>> +TUNE_CCARGS_mipsel := "${@oe_filter_out('-march=mips32',
'${TUNE_CCARGS}', d)}"
>>
>>  # We need to ensure that all of the i386 and x86_64 headers are
identical
>>  # to support the multilib case.  We do this by copying headers from
x86_64
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-core/eglibc/eglibc_2.15.bb b/meta/recipes-core/eglibc/eglibc_2.15.bb
index e57a112..b2922b4 100644
--- a/meta/recipes-core/eglibc/eglibc_2.15.bb
+++ b/meta/recipes-core/eglibc/eglibc_2.15.bb
@@ -101,6 +101,7 @@  do_patch_append() {
 # mips1 when using o32 and mips3 when using n32/n64
 
 TUNE_CCARGS_mips := "${@oe_filter_out('-march=mips32', '${TUNE_CCARGS}', d)}"
+TUNE_CCARGS_mipsel := "${@oe_filter_out('-march=mips32', '${TUNE_CCARGS}', d)}"
 
 # We need to ensure that all of the i386 and x86_64 headers are identical
 # to support the multilib case.  We do this by copying headers from x86_64