Patchwork openjade-native: Fix use of obsolete getopts.pl in msggen.pl

login
register
mail settings
Submitter Jonathan Santos
Date June 27, 2012, 3:35 p.m.
Message ID <1340811339-6223-1-git-send-email-jrsantos@jonathanrsantos.com>
Download mbox | patch
Permalink /patch/30719/
State New
Headers show

Comments

Jonathan Santos - June 27, 2012, 3:35 p.m.
getopts.pl was deprecated in perl 5.14, and removed in 5.16.

Signed-off-by: Jonathan Santos <jrsantos@jonathanrsantos.com>
---
 .../openjade/openjade-1.3.2/getopts.patch            | 20 ++++++++++++++++++++
 .../openjade/openjade-native_1.3.2.bb                |  3 ++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch
Saul Wold - June 27, 2012, 5:07 p.m.
On 06/27/2012 08:35 AM, Jonathan Santos wrote:
> getopts.pl was deprecated in perl 5.14, and removed in 5.16.
>
> Signed-off-by: Jonathan Santos<jrsantos@jonathanrsantos.com>
> ---
>   .../openjade/openjade-1.3.2/getopts.patch            | 20 ++++++++++++++++++++
>   .../openjade/openjade-native_1.3.2.bb                |  3 ++-
>   2 files changed, 22 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch
>
> diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch
> new file mode 100644
> index 0000000..b89861d
> --- /dev/null
> +++ b/meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch

This need a patch header, with comment (why is patch needed) along with 
Upstream-Status and Signed-off-by

Please see the Commit and Patch Wiki:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks
	Sau!

> @@ -0,0 +1,20 @@
> +--- ./msggen.pl.orig	2012-06-11 11:35:22.000000000 +0000
> ++++ ./msggen.pl	2012-06-11 11:37:06.000000000 +0000
> +@@ -4,6 +4,7 @@
> + # See the file COPYING for copying permission.
> +
> + use POSIX;
> ++use Getopt::Std;
> +
> + # Package and version.
> + $package = 'openjade';
> +@@ -18,8 +19,7 @@ $gen_c = 0;
> + undef $opt_l;
> + undef $opt_p;
> + undef $opt_t;
> +-do 'getopts.pl';
> +-&Getopts('l:p:t:');
> ++getopts('l:p:t:');
> + $module = $opt_l;
> + $pot_file = $opt_p;
> +
> diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> index 5b29c1f..a69c697 100644
> --- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> +++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
> @@ -15,7 +15,8 @@ RDEPENDS_${PN} = "sgml-common-native"
>   SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \
>              file://makefile.patch \
>              file://reautoconf.patch \
> -	   file://user-declared-default-constructor.patch"
> +           file://user-declared-default-constructor.patch \
> +           file://getopts.patch"
>
>   SRC_URI[md5sum] = "7df692e3186109cc00db6825b777201e"
>   SRC_URI[sha256sum] = "1d2d7996cc94f9b87d0c51cf0e028070ac177c4123ecbfd7ac1cb8d0b7d322d1"

Patch

diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch
new file mode 100644
index 0000000..b89861d
--- /dev/null
+++ b/meta/recipes-devtools/openjade/openjade-1.3.2/getopts.patch
@@ -0,0 +1,20 @@ 
+--- ./msggen.pl.orig	2012-06-11 11:35:22.000000000 +0000
++++ ./msggen.pl	2012-06-11 11:37:06.000000000 +0000
+@@ -4,6 +4,7 @@
+ # See the file COPYING for copying permission.
+ 
+ use POSIX;
++use Getopt::Std;
+ 
+ # Package and version.
+ $package = 'openjade';
+@@ -18,8 +19,7 @@ $gen_c = 0;
+ undef $opt_l;
+ undef $opt_p;
+ undef $opt_t;
+-do 'getopts.pl';
+-&Getopts('l:p:t:');
++getopts('l:p:t:');
+ $module = $opt_l;
+ $pot_file = $opt_p;
+ 
diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
index 5b29c1f..a69c697 100644
--- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
+++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
@@ -15,7 +15,8 @@  RDEPENDS_${PN} = "sgml-common-native"
 SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \
            file://makefile.patch \
            file://reautoconf.patch \
-	   file://user-declared-default-constructor.patch"
+           file://user-declared-default-constructor.patch \
+           file://getopts.patch"
 
 SRC_URI[md5sum] = "7df692e3186109cc00db6825b777201e"
 SRC_URI[sha256sum] = "1d2d7996cc94f9b87d0c51cf0e028070ac177c4123ecbfd7ac1cb8d0b7d322d1"