| Submitter | Khem Raj |
|---|---|
| Date | June 27, 2012, 6:09 a.m. |
| Message ID | <3ef3573dcf3deb300a12a1830ccc768c999e61fe.1340777116.git.raj.khem@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/30681/ |
| State | New |
| Headers | show |
Comments
On Tue, 2012-06-26 at 23:09 -0700, Khem Raj wrote: > USE_NLS is generally defined for uclibc based system builds > and generally its defined to 'no' there. However this variable > does not exist at all for eglibc/glibc distributions. This > patch adds a weak definition to 'yes' on eglibc based system > builds. This will ease out some of the cryptic contructs we > have to define certain options based on USE_NLS and also > checking got uclibc at the same time to avoid pythong exceptions > when its not defined. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/conf/distro/include/tclibc-eglibc.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/conf/distro/include/tclibc-eglibc.inc b/meta/conf/distro/include/tclibc-eglibc.inc > index 4f5607f..e2ca4e8 100644 > --- a/meta/conf/distro/include/tclibc-eglibc.inc > +++ b/meta/conf/distro/include/tclibc-eglibc.inc > @@ -32,6 +32,8 @@ LIBC_LOCALE_DEPENDENCIES = "\ > eglibc-gconv-iso8859-1 \ > eglibc-gconv-iso8859-15" > > +USE_NLS ?= "yes" > + > def get_libc_locales_dependencies(d): > if 'libc-locales' in (d.getVar('DISTRO_FEATURES', True) or '').split() : > return d.getVar('LIBC_LOCALE_DEPENDENCIES', True) or '' Shouldn't this go as a weak default in bitbake.conf? USE_NLS ??= "yes" Cheers, Richard
On Wednesday, June 27, 2012, Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Tue, 2012-06-26 at 23:09 -0700, Khem Raj wrote: >> USE_NLS is generally defined for uclibc based system builds >> and generally its defined to 'no' there. However this variable >> does not exist at all for eglibc/glibc distributions. This >> patch adds a weak definition to 'yes' on eglibc based system >> builds. This will ease out some of the cryptic contructs we >> have to define certain options based on USE_NLS and also >> checking got uclibc at the same time to avoid pythong exceptions >> when its not defined. >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> meta/conf/distro/include/tclibc-eglibc.inc | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta/conf/distro/include/tclibc-eglibc.inc b/meta/conf/distro/include/tclibc-eglibc.inc >> index 4f5607f..e2ca4e8 100644 >> --- a/meta/conf/distro/include/tclibc-eglibc.inc >> +++ b/meta/conf/distro/include/tclibc-eglibc.inc >> @@ -32,6 +32,8 @@ LIBC_LOCALE_DEPENDENCIES = "\ >> eglibc-gconv-iso8859-1 \ >> eglibc-gconv-iso8859-15" >> >> +USE_NLS ?= "yes" >> + >> def get_libc_locales_dependencies(d): >> if 'libc-locales' in (d.getVar('DISTRO_FEATURES', True) or '').split() : >> return d.getVar('LIBC_LOCALE_DEPENDENCIES', True) or '' > > Shouldn't this go as a weak default in bitbake.conf? > > USE_NLS ??= "yes" > I think that would be better I will try that out and update > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
Patch
diff --git a/meta/conf/distro/include/tclibc-eglibc.inc b/meta/conf/distro/include/tclibc-eglibc.inc index 4f5607f..e2ca4e8 100644 --- a/meta/conf/distro/include/tclibc-eglibc.inc +++ b/meta/conf/distro/include/tclibc-eglibc.inc @@ -32,6 +32,8 @@ LIBC_LOCALE_DEPENDENCIES = "\ eglibc-gconv-iso8859-1 \ eglibc-gconv-iso8859-15" +USE_NLS ?= "yes" + def get_libc_locales_dependencies(d): if 'libc-locales' in (d.getVar('DISTRO_FEATURES', True) or '').split() : return d.getVar('LIBC_LOCALE_DEPENDENCIES', True) or ''
USE_NLS is generally defined for uclibc based system builds and generally its defined to 'no' there. However this variable does not exist at all for eglibc/glibc distributions. This patch adds a weak definition to 'yes' on eglibc based system builds. This will ease out some of the cryptic contructs we have to define certain options based on USE_NLS and also checking got uclibc at the same time to avoid pythong exceptions when its not defined. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/conf/distro/include/tclibc-eglibc.inc | 2 ++ 1 file changed, 2 insertions(+)