Patchwork [1/2] zeromq: Add zeromq socket library.

login
register
mail settings
Submitter Siddharth Heroor
Date May 1, 2011, 9:50 a.m.
Message ID <1304243449-12028-1-git-send-email-heroor@ti.com>
Download mbox | patch
Permalink /patch/3055/
State Rejected
Headers show

Comments

Siddharth Heroor - May 1, 2011, 9:50 a.m.
Signed-off-by: Siddharth Heroor <heroor@ti.com>
---
 recipes/zeromq/zeromq.inc |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)
 create mode 100644 recipes/zeromq/zeromq.inc
Paul Menzel - May 1, 2011, 10:08 a.m.
Am Sonntag, den 01.05.2011, 15:20 +0530 schrieb Siddharth Heroor:
> Signed-off-by: Siddharth Heroor <heroor@ti.com>

The email differs again from the From line. If you want the TI address
be shown, please add a from line to the beginning of the message with
the patch. I guess `git send-email` can also be configured this way.

> ---
>  recipes/zeromq/zeromq.inc |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/zeromq/zeromq.inc
> 
> diff --git a/recipes/zeromq/zeromq.inc b/recipes/zeromq/zeromq.inc
> new file mode 100644
> index 0000000..b631d98
> --- /dev/null
> +++ b/recipes/zeromq/zeromq.inc
> @@ -0,0 +1,10 @@
> +DESCRIPTION = "Socket Library that acts as a concurrency framework"
> +HOMEPAGE = "http://www.zeromq.org"
> +SECTION = "libs"
> +LICENSE = "LGPLv3" 
> +
> +PR = "r1"

In an `*.inc` file `INC_PR` is used [1]. Please also start with `r0`.

> +
> +SRC_URI = "http://download.zeromq.org/zeromq-${PV}.tar.gz"
> +
> +inherit autotools


Thanks,

Paul


[1] http://openembedded.org/index.php/Styleguide#PR_variables_with_recipes_that_use_INC_files
Siddharth Heroor - May 1, 2011, 3:24 p.m.
On Sun, May 1, 2011 at 3:38 PM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> Am Sonntag, den 01.05.2011, 15:20 +0530 schrieb Siddharth Heroor:
>> Signed-off-by: Siddharth Heroor <heroor@ti.com>
>
> The email differs again from the From line. If you want the TI address
> be shown, please add a from line to the beginning of the message with
> the patch. I guess `git send-email` can also be configured this way.

I was using gmail to send out the email. I'll change the signoff line.
Its not strictly from TI.
Is it ok if I sign off my gmail account from non-TI stuff?

>
>> ---
>>  recipes/zeromq/zeromq.inc |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/zeromq/zeromq.inc
>>
>> diff --git a/recipes/zeromq/zeromq.inc b/recipes/zeromq/zeromq.inc
>> new file mode 100644
>> index 0000000..b631d98
>> --- /dev/null
>> +++ b/recipes/zeromq/zeromq.inc
>> @@ -0,0 +1,10 @@
>> +DESCRIPTION = "Socket Library that acts as a concurrency framework"
>> +HOMEPAGE = "http://www.zeromq.org"
>> +SECTION = "libs"
>> +LICENSE = "LGPLv3"
>> +
>> +PR = "r1"
>
> In an `*.inc` file `INC_PR` is used [1]. Please also start with `r0`.
>
>> +
>> +SRC_URI = "http://download.zeromq.org/zeromq-${PV}.tar.gz"
>> +
>> +inherit autotools
>
>
> Thanks,
>
> Paul
>
>
> [1] http://openembedded.org/index.php/Styleguide#PR_variables_with_recipes_that_use_INC_files
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
Petr Štetiar - May 1, 2011, 5:30 p.m.
Siddharth Heroor <heroor@gmail.com> [2011-05-01 15:20:48]:

Hi,

> +PR = "r1"
> +
> +SRC_URI = "http://download.zeromq.org/zeromq-${PV}.tar.gz"
> +
> +inherit autotools

for version 2.1.1 I've needed also the following:

	DEPENDS += "util-linux-ng"

	do_configure_prepend() {
        	./autogen.sh
	}

It's not needed anymore?

-- ynezz
Siddharth Heroor - May 3, 2011, 4:48 p.m.
On Sun, May 1, 2011 at 11:00 PM, Petr Štetiar <ynezz@true.cz> wrote:
> Siddharth Heroor <heroor@gmail.com> [2011-05-01 15:20:48]:
>
> Hi,
>
>> +PR = "r1"
>> +
>> +SRC_URI = "http://download.zeromq.org/zeromq-${PV}.tar.gz"
>> +
>> +inherit autotools
>
> for version 2.1.1 I've needed also the following:
>
>        DEPENDS += "util-linux-ng"
>
>        do_configure_prepend() {
>                ./autogen.sh
>        }
>
> It's not needed anymore?
Is the older recipe available somewhere? I didn't have to do this for
the latest version.
Petr Štetiar - May 6, 2011, 9:02 a.m.
Siddharth Heroor <heroor@gmail.com> [2011-05-03 22:18:03]:

> Is the older recipe available somewhere? I didn't have to do this for the
> latest version.

Yes, it's in patchwork[1]. I should've pushed it few weeks ago, but didn't had
time to rebase and test it again yet. Hopefully I'll do it during this
weekend.

AFAIK, libuuid from util-linux-ng is build/run dependency, so it's needed.

1. http://patches.openembedded.org/patch/1885

-- ynezz
Siddharth Heroor - May 6, 2011, 10:09 a.m.
On Fri, May 6, 2011 at 2:32 PM, Petr Štetiar <ynezz@true.cz> wrote:
> Siddharth Heroor <heroor@gmail.com> [2011-05-03 22:18:03]:
>
>> Is the older recipe available somewhere? I didn't have to do this for the
>> latest version.
>
> Yes, it's in patchwork[1]. I should've pushed it few weeks ago, but didn't had
> time to rebase and test it again yet. Hopefully I'll do it during this
> weekend.
Ok. I'll wait for your patch. I'm facing some issues with testing my
patch and so I'll
withdraw it.

--
Sid

>
> AFAIK, libuuid from util-linux-ng is build/run dependency, so it's needed.
>
> 1. http://patches.openembedded.org/patch/1885
>
> -- ynezz
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Petr Štetiar - May 8, 2011, 6:09 p.m.
Siddharth Heroor <heroor@gmail.com> [2011-05-06 15:39:23]:

> Ok. I'll wait for your patch. I'm facing some issues with testing my patch
> and so I'll withdraw it.

It's in[1], please test it and give some feedback. I'm using it with
lua-zeromq for some time already on arm9, so I would be suprised if there are
some issues. Thanks.

1. http://git.openembedded.org/cgit.cgi/openembedded/commit/?id=b8e90091aca8777092aa410fbfbb5c5d8cc7cbcb

-- ynezz
Siddharth Heroor - May 10, 2011, 9:34 a.m.
On Sun, May 8, 2011 at 11:39 PM, Petr Štetiar <ynezz@true.cz> wrote:
> Siddharth Heroor <heroor@gmail.com> [2011-05-06 15:39:23]:
>
>> Ok. I'll wait for your patch. I'm facing some issues with testing my patch
>> and so I'll withdraw it.
>
> It's in[1], please test it and give some feedback. I'm using it with
> lua-zeromq for some time already on arm9, so I would be suprised if there are
> some issues. Thanks.
>
> 1. http://git.openembedded.org/cgit.cgi/openembedded/commit/?id=b8e90091aca8777092aa410fbfbb5c5d8cc7cbcb

I tried to build it and it fails. The error is as follows -

ERROR: Logfile of failure stored in:
/swcoe/sdk/sid/arago/build-oe/angstrom-setup-scripts/build/tmp-angstrom_2010_x/work/armv7a-angstrom-linux-gnueabi/zeromq-2.1.6-r0/temp/log.do_configure.10701
Log data follows:
| + do_configure
| + ./autogen.sh
| autogen.sh: error: could not find libtool.  libtool is required to
run autogen.sh.
NOTE: package zeromq-2.1.6-r0: task do_configure: Failed

My build configuration is

Build Configuration:
BB_VERSION        = "1.12.0"
METADATA_BRANCH   = "master"
METADATA_REVISION = "980407c"
TARGET_ARCH       = "arm"
TARGET_OS         = "linux-gnueabi"
MACHINE           = "c6a816x-evm"
DISTRO            = "angstrom"
DISTRO_VERSION    = "v2011.05"
TARGET_FPU        = "hard"

By removing do_configure_prepend() from the recipe, I am able to build zeromq.
Why do we need to run autogen.sh to regenerate the configure script?
Won't the shipped configure work?

Also, shouldn't most the recipe be in an .inc file and the checksums
in a version.bb?
>
> -- ynezz
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Petr Štetiar - May 10, 2011, 8:35 p.m.
Siddharth Heroor <heroor@gmail.com> [2011-05-10 15:04:04]:

> I tried to build it and it fails. The error is as follows -
> 
> ERROR: Logfile of failure stored in:
> /swcoe/sdk/sid/arago/build-oe/angstrom-setup-scripts/build/tmp-angstrom_2010_x/work/armv7a-angstrom-linux-gnueabi/zeromq-2.1.6-r0/temp/log.do_configure.10701
> Log data follows:
> | + do_configure
> | + ./autogen.sh
> | autogen.sh: error: could not find libtool.  libtool is required to
> run autogen.sh.
> NOTE: package zeromq-2.1.6-r0: task do_configure: Failed

Hm sorry, but this is strange. I don't know why it shoudln't find libtool...
Log here:

	+ cd /opt/devel/oe/ts72xx-test/tmp-uclibc-angstrom-2010.x/work/armv4t-angstrom-linux-uclibceabi/zeromq-2.1.6-r0/zeromq-2.1.6
	+ do_configure
	+ ./autogen.sh
	autoreconf: Entering directory `.'
	autoreconf: configure.in: not using Gettext
	autoreconf: running: aclocal -I config -I config --force -I config
	...

> By removing do_configure_prepend() from the recipe, I am able to build zeromq.
> Why do we need to run autogen.sh to regenerate the configure script?
> Won't the shipped configure work?

It apparently wasn't working quite correctly in some scenario, that's why it's
there. Maybe automake or something was complaining about the shipped version
of the macros? Sorry, I don't remember it correctly now, but it was tested by
Craig also, so I've pushed it as it is.

Anyone with the better knowledge of the autofoo stuff, who could shed some
light on this?

> Also, shouldn't most the recipe be in an .inc file and the checksums
> in a version.bb?

AFAIK, there's no such guideline. If you do plan to add for example package
which would track the git version of zeromq, then yes, it would be good idea
to split it and reuse the common parts.

-- ynezz
Paul Menzel - Sept. 8, 2011, 10:13 a.m.
Dear Petr, dear Siddharth,


Am Dienstag, den 10.05.2011, 22:35 +0200 schrieb Petr Štetiar:
> Siddharth Heroor <heroor@gmail.com> [2011-05-10 15:04:04]:
> 
> > I tried to build it and it fails. The error is as follows -
> > 
> > ERROR: Logfile of failure stored in:
> > /swcoe/sdk/sid/arago/build-oe/angstrom-setup-scripts/build/tmp-angstrom_2010_x/work/armv7a-angstrom-linux-gnueabi/zeromq-2.1.6-r0/temp/log.do_configure.10701
> > Log data follows:
> > | + do_configure
> > | + ./autogen.sh
> > | autogen.sh: error: could not find libtool.  libtool is required to run autogen.sh.
> > NOTE: package zeromq-2.1.6-r0: task do_configure: Failed

I do get the same error as Siddharth using `angstrom-2010.x` for
`MACHINE = "beagleboard"`.

> Hm sorry, but this is strange. I don't know why it shoudln't find libtool...
> Log here:
> 
> 	+ cd /opt/devel/oe/ts72xx-test/tmp-uclibc-angstrom-2010.x/work/armv4t-angstrom-linux-uclibceabi/zeromq-2.1.6-r0/zeromq-2.1.6
> 	+ do_configure
> 	+ ./autogen.sh
> 	autoreconf: Entering directory `.'
> 	autoreconf: configure.in: not using Gettext
> 	autoreconf: running: aclocal -I config -I config --force -I config
> 	...

Are you sure it is not using `libtool` installed on your build system?

> > By removing do_configure_prepend() from the recipe, I am able to build zeromq.
> > Why do we need to run autogen.sh to regenerate the configure script?
> > Won't the shipped configure work?
> 
> It apparently wasn't working quite correctly in some scenario, that's why it's
> there. Maybe automake or something was complaining about the shipped version
> of the macros? Sorry, I don't remember it correctly now, but it was tested by
> Craig also, so I've pushed it as it is.
> 
> Anyone with the better knowledge of the autofoo stuff, who could shed some
> light on this?

Maybe Ilya who submitted a patch to upgrade the recipe to 2.1.6 has an
idea?

[…]


Thanks,

Paul

Patch

diff --git a/recipes/zeromq/zeromq.inc b/recipes/zeromq/zeromq.inc
new file mode 100644
index 0000000..b631d98
--- /dev/null
+++ b/recipes/zeromq/zeromq.inc
@@ -0,0 +1,10 @@ 
+DESCRIPTION = "Socket Library that acts as a concurrency framework"
+HOMEPAGE = "http://www.zeromq.org"
+SECTION = "libs"
+LICENSE = "LGPLv3" 
+
+PR = "r1"
+
+SRC_URI = "http://download.zeromq.org/zeromq-${PV}.tar.gz"
+
+inherit autotools