Patchwork [bitbake-devel] Fix for Hob bug #2323

login
register
mail settings
Submitter Cristian Iorga
Date June 22, 2012, 4:08 p.m.
Message ID <1340381304-20531-1-git-send-email-cristian.iorga@intel.com>
Download mbox | patch
Permalink /patch/30487/
State New
Headers show

Comments

Cristian Iorga - June 22, 2012, 4:08 p.m.
Removed unnecessary button from Recipes screen and
replaced the button that diplayed packages size and total image size
from Packages screen with a label.

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py |    7 ++-----
 bitbake/lib/bb/ui/crumbs/recipeselectionpage.py  |    9 ++-------
 2 files changed, 4 insertions(+), 12 deletions(-)
Saul Wold - June 26, 2012, 6:49 p.m.
On 06/22/2012 09:08 AM, Cristian Iorga wrote:
> Removed unnecessary button from Recipes screen and
> replaced the button that diplayed packages size and total image size
> from Packages screen with a label.
>
Please change the subject to address what you fixed, not everyone wants 
to look up bug numbers and they should not be in the commit subject.

You can add the bug number at a tag:
[YOCTO #2323]

Please review these general guidelines at:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

They can be used for oe-core, bitbake, and poky commits.

Thanks
	Sau!

> Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
> ---
>   bitbake/lib/bb/ui/crumbs/packageselectionpage.py |    7 ++-----
>   bitbake/lib/bb/ui/crumbs/recipeselectionpage.py  |    9 ++-------
>   2 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
> index 9895835..1b832eb 100755
> --- a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
> +++ b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
> @@ -113,15 +113,12 @@ class PackageSelectionPage (HobPage):
>           self.ins.set_current_page(0)
>
>       def create_visual_elements(self):
> -        self.label = gtk.Button("Packages included: 0\nSelected packages size: 0 MB")
> -        self.label.set_can_default(False)
> -        self.label.set_relief(gtk.RELIEF_HALF)
> -        self.label.connect("clicked", self.included_clicked_cb)
> +        self.label = gtk.Label("Packages included: 0\nSelected packages size: 0 MB")
>           self.eventbox = self.add_onto_top_bar(self.label, 73)
>           self.pack_start(self.eventbox, expand=False, fill=False)
>           self.pack_start(self.group_align, expand=True, fill=True)
>
> -        # set visiable members
> +        # set visible members
>           self.ins = HobNotebook()
>           self.tables = [] # we need to modify table when the dialog is shown
>           # append the tab
> diff --git a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
> index ece37e0..af68f2a 100755
> --- a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
> +++ b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
> @@ -138,15 +138,11 @@ class RecipeSelectionPage (HobPage):
>           self.ins.set_current_page(0)
>
>       def create_visual_elements(self):
> -        self.label = gtk.Button('Recipes included: 0')
> -        self.label.set_can_default(False)
> -        self.label.set_relief(gtk.RELIEF_HALF)
> -        self.label.connect("clicked", self.included_clicked_cb)
> -        self.eventbox = self.add_onto_top_bar(self.label, 73)
> +        self.eventbox = self.add_onto_top_bar(None, 73)
>           self.pack_start(self.eventbox, expand=False, fill=False)
>           self.pack_start(self.group_align, expand=True, fill=True)
>
> -        # set visiable members
> +        # set visible members
>           self.ins = HobNotebook()
>           self.tables = [] # we need modify table when the dialog is shown
>           # append the tabs in order
> @@ -205,7 +201,6 @@ class RecipeSelectionPage (HobPage):
>       def refresh_selection(self):
>           self.builder.configuration.selected_image = self.recipe_model.get_selected_image()
>           _, self.builder.configuration.selected_recipes = self.recipe_model.get_selected_recipes()
> -        self.label.set_label("Recipes included: %s" % len(self.builder.configuration.selected_recipes))
>           self.ins.show_indicator_icon("Included", len(self.builder.configuration.selected_recipes))
>
>       def toggle_item_idle_cb(self, path, view_tree, cell, pagename):

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
index 9895835..1b832eb 100755
--- a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
+++ b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
@@ -113,15 +113,12 @@  class PackageSelectionPage (HobPage):
         self.ins.set_current_page(0)
 
     def create_visual_elements(self):
-        self.label = gtk.Button("Packages included: 0\nSelected packages size: 0 MB")
-        self.label.set_can_default(False)
-        self.label.set_relief(gtk.RELIEF_HALF)
-        self.label.connect("clicked", self.included_clicked_cb)
+        self.label = gtk.Label("Packages included: 0\nSelected packages size: 0 MB")
         self.eventbox = self.add_onto_top_bar(self.label, 73)
         self.pack_start(self.eventbox, expand=False, fill=False)
         self.pack_start(self.group_align, expand=True, fill=True)
 
-        # set visiable members
+        # set visible members
         self.ins = HobNotebook()
         self.tables = [] # we need to modify table when the dialog is shown
         # append the tab
diff --git a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
index ece37e0..af68f2a 100755
--- a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
+++ b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
@@ -138,15 +138,11 @@  class RecipeSelectionPage (HobPage):
         self.ins.set_current_page(0)
 
     def create_visual_elements(self):
-        self.label = gtk.Button('Recipes included: 0')
-        self.label.set_can_default(False)
-        self.label.set_relief(gtk.RELIEF_HALF)
-        self.label.connect("clicked", self.included_clicked_cb)
-        self.eventbox = self.add_onto_top_bar(self.label, 73)
+        self.eventbox = self.add_onto_top_bar(None, 73)
         self.pack_start(self.eventbox, expand=False, fill=False)
         self.pack_start(self.group_align, expand=True, fill=True)
 
-        # set visiable members
+        # set visible members
         self.ins = HobNotebook()
         self.tables = [] # we need modify table when the dialog is shown
         # append the tabs in order
@@ -205,7 +201,6 @@  class RecipeSelectionPage (HobPage):
     def refresh_selection(self):
         self.builder.configuration.selected_image = self.recipe_model.get_selected_image()
         _, self.builder.configuration.selected_recipes = self.recipe_model.get_selected_recipes()
-        self.label.set_label("Recipes included: %s" % len(self.builder.configuration.selected_recipes))
         self.ins.show_indicator_icon("Included", len(self.builder.configuration.selected_recipes))
 
     def toggle_item_idle_cb(self, path, view_tree, cell, pagename):