Patchwork layer.conf/bblayers.conf.sample: Fix empth BBPATH entry warnings

login
register
mail settings
Submitter Richard Purdie
Date June 22, 2012, 1:39 p.m.
Message ID <1340372395.394.35.camel@ted>
Download mbox | patch
Permalink /patch/30469/
State Accepted
Commit 3d379929d119ee59b233116c5392441c625355f2
Headers show

Comments

Richard Purdie - June 22, 2012, 1:39 p.m.
Many people are seeing issues from the empty path warnings from BBPATH.
The empty path entry corresponding to the current working directory is a
problem since if cwd changes, so does BBPATH and build reproducibility.

Simply removing the empty element causes problems since the build
directory then isn't listed in BBPATH which means local.conf isn't found
and this gives an extremely confusing error message about bbappends
being unsatisfied.

The build directory in bitbake terms is TOPDIR. The correct way to fix
things is to add in TOPDIR into bblayers.conf itself. This means the
layers can happily append/prepend to BBPATH at will as its no longer
empty hence neatly solving all the various problems. Since the file has
changed, the version is also changed.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

---
 meta/conf/bblayers.conf.sample |    4 +++-
 meta/conf/layer.conf           |    1 -
 2 files changed, 3 insertions(+), 2 deletions(-)
Khem Raj - June 22, 2012, 2:17 p.m.
On Fri, Jun 22, 2012 at 6:39 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Many people are seeing issues from the empty path warnings from BBPATH.
> The empty path entry corresponding to the current working directory is a
> problem since if cwd changes, so does BBPATH and build reproducibility.
>
> Simply removing the empty element causes problems since the build
> directory then isn't listed in BBPATH which means local.conf isn't found
> and this gives an extremely confusing error message about bbappends
> being unsatisfied.
>
> The build directory in bitbake terms is TOPDIR. The correct way to fix
> things is to add in TOPDIR into bblayers.conf itself. This means the
> layers can happily append/prepend to BBPATH at will as its no longer
> empty hence neatly solving all the various problems. Since the file has
> changed, the version is also changed.


thanks this is fine


>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> ---
>  meta/conf/bblayers.conf.sample |    4 +++-
>  meta/conf/layer.conf           |    1 -
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/bblayers.conf.sample b/meta/conf/bblayers.conf.sample
> index 222b03a..e621866 100644
> --- a/meta/conf/bblayers.conf.sample
> +++ b/meta/conf/bblayers.conf.sample
> @@ -1,8 +1,10 @@
>  # LAYER_CONF_VERSION is increased each time build/conf/bblayers.conf
>  # changes incompatibly
> -LCONF_VERSION = "4"
> +LCONF_VERSION = "5"
>
> +BBPATH = "${TOPDIR}"
>  BBFILES ?= ""
> +
>  BBLAYERS ?= " \
>   ##COREBASE##/meta \
>   "
> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> index 43e4295..090c8e2 100644
> --- a/meta/conf/layer.conf
> +++ b/meta/conf/layer.conf
> @@ -1,4 +1,3 @@
> -BBPATH ?= ""
>  # We have a conf and classes directory, add to BBPATH
>  BBPATH .= ":${LAYERDIR}"
>  # We have a packages directory, add to BBFILES
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/conf/bblayers.conf.sample b/meta/conf/bblayers.conf.sample
index 222b03a..e621866 100644
--- a/meta/conf/bblayers.conf.sample
+++ b/meta/conf/bblayers.conf.sample
@@ -1,8 +1,10 @@ 
 # LAYER_CONF_VERSION is increased each time build/conf/bblayers.conf
 # changes incompatibly
-LCONF_VERSION = "4"
+LCONF_VERSION = "5"
 
+BBPATH = "${TOPDIR}"
 BBFILES ?= ""
+
 BBLAYERS ?= " \
   ##COREBASE##/meta \
   "
diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
index 43e4295..090c8e2 100644
--- a/meta/conf/layer.conf
+++ b/meta/conf/layer.conf
@@ -1,4 +1,3 @@ 
-BBPATH ?= ""
 # We have a conf and classes directory, add to BBPATH
 BBPATH .= ":${LAYERDIR}"
 # We have a packages directory, add to BBFILES