Patchwork [meta-oe] libmodbus: update to 3.0.3

login
register
mail settings
Submitter Andrea Galbusera
Date June 22, 2012, 8:06 a.m.
Message ID <1340352411-20305-1-git-send-email-gizero@gmail.com>
Download mbox | patch
Permalink /patch/30447/
State Superseded
Headers show

Comments

Andrea Galbusera - June 22, 2012, 8:06 a.m.
Signed-off-by: Andrea Galbusera <gizero@gmail.com>
---
 .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |   16 ----------------
 .../recipes-extended/libmodbus/libmodbus_3.0.3.bb  |   16 ++++++++++++++++
 2 files changed, 16 insertions(+), 16 deletions(-)
 delete mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
 create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
Martin Jansa - June 22, 2012, 8:20 a.m.
On Fri, Jun 22, 2012 at 10:06:51AM +0200, Andrea Galbusera wrote:
> Signed-off-by: Andrea Galbusera <gizero@gmail.com>
> ---
>  .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |   16 ----------------
>  .../recipes-extended/libmodbus/libmodbus_3.0.3.bb  |   16 ++++++++++++++++
>  2 files changed, 16 insertions(+), 16 deletions(-)
>  delete mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb

Please use -M when sending patches like this, so it's easier for review.

Also when you're at it, you can simplify URL like this:
s%libmodbus/libmodbus-${PV}%${BPN}/${BP}%

Cheers,

> 
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
> deleted file mode 100644
> index 03b7fcc..0000000
> --- a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -SUMMARY = "A Modbus library"
> -DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
> -implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
> -QNX and Windows."
> -HOMEPAGE = "http://www.libmodbus.org/"
> -SECTION = "libs"
> -
> -LICENSE = "LGPLv2.1+"
> -LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
> -
> -SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
> -
> -inherit autotools pkgconfig
> -
> -SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
> -SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
> new file mode 100644
> index 0000000..e6dde2c
> --- /dev/null
> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
> @@ -0,0 +1,16 @@
> +SUMMARY = "A Modbus library"
> +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
> +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
> +QNX and Windows."
> +HOMEPAGE = "http://www.libmodbus.org/"
> +SECTION = "libs"
> +
> +LICENSE = "LGPLv2.1+"
> +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
> +
> +SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
> +
> +inherit autotools pkgconfig
> +
> +SRC_URI[md5sum] = "b5042d833c6c132e6fb2551af133a342"
> +SRC_URI[sha256sum] = "6fc7cf91f7293e522afde6ae5fc605c6cd7bdca4ee2ec953db5bb91158ab8677"
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Andrea Galbusera - June 22, 2012, 9:20 a.m.
Hi Martin,

On Fri, Jun 22, 2012 at 10:20 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Jun 22, 2012 at 10:06:51AM +0200, Andrea Galbusera wrote:
>> Signed-off-by: Andrea Galbusera <gizero@gmail.com>
>> ---
>>  .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |   16 ----------------
>>  .../recipes-extended/libmodbus/libmodbus_3.0.3.bb  |   16 ++++++++++++++++
>>  2 files changed, 16 insertions(+), 16 deletions(-)
>>  delete mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
>
> Please use -M when sending patches like this, so it's easier for review.
>
> Also when you're at it, you can simplify URL like this:
> s%libmodbus/libmodbus-${PV}%${BPN}/${BP}%

Thank you for reviewing. I wasn't aware of -M... still a newbie of
patch workflow. ;-)
Going to update my 'oe patch howto' notes and re-submitting.

>
> Cheers,
>
>>
>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>> deleted file mode 100644
>> index 03b7fcc..0000000
>> --- a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>> +++ /dev/null
>> @@ -1,16 +0,0 @@
>> -SUMMARY = "A Modbus library"
>> -DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
>> -implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
>> -QNX and Windows."
>> -HOMEPAGE = "http://www.libmodbus.org/"
>> -SECTION = "libs"
>> -
>> -LICENSE = "LGPLv2.1+"
>> -LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
>> -
>> -SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
>> -
>> -inherit autotools pkgconfig
>> -
>> -SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
>> -SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
>> new file mode 100644
>> index 0000000..e6dde2c
>> --- /dev/null
>> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
>> @@ -0,0 +1,16 @@
>> +SUMMARY = "A Modbus library"
>> +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
>> +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
>> +QNX and Windows."
>> +HOMEPAGE = "http://www.libmodbus.org/"
>> +SECTION = "libs"
>> +
>> +LICENSE = "LGPLv2.1+"
>> +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
>> +
>> +SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
>> +
>> +inherit autotools pkgconfig
>> +
>> +SRC_URI[md5sum] = "b5042d833c6c132e6fb2551af133a342"
>> +SRC_URI[sha256sum] = "6fc7cf91f7293e522afde6ae5fc605c6cd7bdca4ee2ec953db5bb91158ab8677"
>> --
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Martin Jansa - June 22, 2012, 9:46 a.m.
On Fri, Jun 22, 2012 at 11:20 AM, Andrea Galbusera <gizero@gmail.com> wrote:
> Hi Martin,
>
> On Fri, Jun 22, 2012 at 10:20 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Fri, Jun 22, 2012 at 10:06:51AM +0200, Andrea Galbusera wrote:
>>> Signed-off-by: Andrea Galbusera <gizero@gmail.com>
>>> ---
>>>  .../recipes-extended/libmodbus/libmodbus_3.0.2.bb  |   16 ----------------
>>>  .../recipes-extended/libmodbus/libmodbus_3.0.3.bb  |   16 ++++++++++++++++
>>>  2 files changed, 16 insertions(+), 16 deletions(-)
>>>  delete mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>>>  create mode 100644 meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
>>
>> Please use -M when sending patches like this, so it's easier for review.
>>
>> Also when you're at it, you can simplify URL like this:
>> s%libmodbus/libmodbus-${PV}%${BPN}/${BP}%
>
> Thank you for reviewing. I wasn't aware of -M... still a newbie of
> patch workflow. ;-)
> Going to update my 'oe patch howto' notes and re-submitting.

To make your 'oe patch howto' even better add 2 more items:

1) when sending v2 fill in Message-ID when git send-email asks for it:
  Message-ID to be used as In-Reply-To for the first email?
  in original patch you had:
  Message-Id: <1340352411-20305-1-git-send-email-gizero@gmail.com>
  so 1340352411-20305-1-git-send-email-gizero@gmail.com
  this way v2 is in the same thread as original patch
2) after sending v2 update patchwork:
  http://patchwork.openembedded.org/project/oe/list/?q=libmodbus
  marking v1 as supperseeded

Cheers,

>
>>
>> Cheers,
>>
>>>
>>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>>> deleted file mode 100644
>>> index 03b7fcc..0000000
>>> --- a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
>>> +++ /dev/null
>>> @@ -1,16 +0,0 @@
>>> -SUMMARY = "A Modbus library"
>>> -DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
>>> -implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
>>> -QNX and Windows."
>>> -HOMEPAGE = "http://www.libmodbus.org/"
>>> -SECTION = "libs"
>>> -
>>> -LICENSE = "LGPLv2.1+"
>>> -LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
>>> -
>>> -SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
>>> -
>>> -inherit autotools pkgconfig
>>> -
>>> -SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
>>> -SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
>>> diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
>>> new file mode 100644
>>> index 0000000..e6dde2c
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
>>> @@ -0,0 +1,16 @@
>>> +SUMMARY = "A Modbus library"
>>> +DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
>>> +implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
>>> +QNX and Windows."
>>> +HOMEPAGE = "http://www.libmodbus.org/"
>>> +SECTION = "libs"
>>> +
>>> +LICENSE = "LGPLv2.1+"
>>> +LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
>>> +
>>> +SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
>>> +
>>> +inherit autotools pkgconfig
>>> +
>>> +SRC_URI[md5sum] = "b5042d833c6c132e6fb2551af133a342"
>>> +SRC_URI[sha256sum] = "6fc7cf91f7293e522afde6ae5fc605c6cd7bdca4ee2ec953db5bb91158ab8677"
>>> --
>>> 1.7.5.4
>>>
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
deleted file mode 100644
index 03b7fcc..0000000
--- a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.2.bb
+++ /dev/null
@@ -1,16 +0,0 @@ 
-SUMMARY = "A Modbus library"
-DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
-implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
-QNX and Windows."
-HOMEPAGE = "http://www.libmodbus.org/"
-SECTION = "libs"
-
-LICENSE = "LGPLv2.1+"
-LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
-
-SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
-
-inherit autotools pkgconfig
-
-SRC_URI[md5sum] = "1aaacce9d9779d3a84f7d1a75774c943"
-SRC_URI[sha256sum] = "927ec90e0e299a7d4ec7086b1e2590566bdfc3bbc22e12204229361c029f2615"
diff --git a/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
new file mode 100644
index 0000000..e6dde2c
--- /dev/null
+++ b/meta-oe/recipes-extended/libmodbus/libmodbus_3.0.3.bb
@@ -0,0 +1,16 @@ 
+SUMMARY = "A Modbus library"
+DESCRIPTION = "libmodbus is a C library designed to provide a fast and robust \
+implementation of the Modbus protocol. It runs on Linux, Mac OS X, FreeBSD, \
+QNX and Windows."
+HOMEPAGE = "http://www.libmodbus.org/"
+SECTION = "libs"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=4fbd65380cdd255951079008b364516c"
+
+SRC_URI = "http://github.com/downloads/stephane/libmodbus/libmodbus-${PV}.tar.gz"
+
+inherit autotools pkgconfig
+
+SRC_URI[md5sum] = "b5042d833c6c132e6fb2551af133a342"
+SRC_URI[sha256sum] = "6fc7cf91f7293e522afde6ae5fc605c6cd7bdca4ee2ec953db5bb91158ab8677"