Patchwork [meta-openembedded] python_numpy: Fix SRC_URI warnings.

login
register
mail settings
Submitter Elvis Dowson
Date June 22, 2012, 4:14 a.m.
Message ID <1340338450-23907-1-git-send-email-elvis.dowson@gmail.com>
Download mbox | patch
Permalink /patch/30445/
State Superseded
Headers show

Comments

Elvis Dowson - June 22, 2012, 4:14 a.m.
This commit fixes the following warnings:
WARNING: Unable to get checksum for python-numpy SRC_URI entry config.h: file could not be found
WARNING: Unable to get checksum for python-numpy SRC_URI entry numpyconfig.h: file could not be found

Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
---
 .../recipes-devtools/python/python-numpy_1.4.1.bb  |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Khem Raj - June 22, 2012, 4:28 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/21/2012 9:14 PM, Elvis Dowson wrote:
> This commit fixes the following warnings: WARNING: Unable to get
> checksum for python-numpy SRC_URI entry config.h: file could not be
> found WARNING: Unable to get checksum for python-numpy SRC_URI
> entry numpyconfig.h: file could not be found
> 
> Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com> --- 
> .../recipes-devtools/python/python-numpy_1.4.1.bb  |   12
> +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb
> b/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb index
> a67bf8b..bdcdf91 100644 ---
> a/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +++
> b/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb @@ -2,11
> +2,17 @@ DESCRIPTION = "A sophisticated Numeric Processing Package
> for Python" SECTION = "devel/python" LICENSE = "PSF" 
> LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=3c42211d73c3faa1026e671dd39883fa" -PR =
> "r3" +PR = "r4"
> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \ -
> file://config.h \ -	   file://numpyconfig.h \ +	  " +SRC_URI_arm +=
> " \ +           file://arm/config.h \ +
> file://arm/numpyconfig.h \ +	  " +SRC_URI_mipsel += " \ +
> file://mipsel/config.h \ +           file://mipsel/numpyconfig.h \ 
> "
> 

Did you test it on arm/mipsel and made sure that SRC_URI is correct
after this change ?

> S = "${WORKDIR}/numpy-${PV}"
> 


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/j9IIACgkQuwUzVZGdMxRdNwCfRMpvWZtDIwMi4EkqZVhN9YbW
WPwAn3VFiygw3k119AqPDm7gxm8UVIl2
=NYbZ
-----END PGP SIGNATURE-----
Elvis Dowson - June 22, 2012, 4:39 a.m.
Hi Khem,

On Jun 22, 2012, at 8:28 AM, Khem Raj wrote:

> Did you test it on arm/mipsel and made sure that SRC_URI is correct
> after this change ?

No, I did not. The location of the files had move to architecture specific folders, but the main recipe had not been updated to reflect this, so I just corrected the recipe. 

I have an armv7a board (TI OMAP3530 based Gumstix Overo Fire), but no mipsel based board. At the moment, I'm focussing on the powerpc440 on my virtex5 fpga board, so perhaps someone else with an arm and mipsel could help test it out.

Best regards,

Elvis Dowson
Khem Raj - June 22, 2012, 4:45 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/21/2012 9:39 PM, Elvis Dowson wrote:
> No, I did not. The location of the files had move to architecture
> specific folders, but the main recipe had not been updated to
> reflect this, so I just corrected the recipe.

OK you can just do

MACHINE=qemuarm bitbake -e python-numpy | grep -i "^SRC_URI="

and see what it shows.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/j+IQACgkQuwUzVZGdMxTyiQCglNWEIfS2EC7Sm0R60GsT0m4I
pOsAn1olV/oDwSSqVYxpy3hoaFP1YJgo
=9qri
-----END PGP SIGNATURE-----
Khem Raj - June 22, 2012, 4:51 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/21/2012 9:14 PM, Elvis Dowson wrote:
> This commit fixes the following warnings: WARNING: Unable to get
> checksum for python-numpy SRC_URI entry config.h: file could not be
> found WARNING: Unable to get checksum for python-numpy SRC_URI
> entry numpyconfig.h: file could not be found
> 
> Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com> --- 
> .../recipes-devtools/python/python-numpy_1.4.1.bb  |   12
> +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb
> b/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb index
> a67bf8b..bdcdf91 100644 ---
> a/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb +++
> b/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb @@ -2,11
> +2,17 @@ DESCRIPTION = "A sophisticated Numeric Processing Package
> for Python" SECTION = "devel/python" LICENSE = "PSF" 
> LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=3c42211d73c3faa1026e671dd39883fa" -PR =
> "r3" +PR = "r4"
> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \ -
> file://config.h \ -	   file://numpyconfig.h \ +	  " +SRC_URI_arm +=
> " \ +           file://arm/config.h \ +
> file://arm/numpyconfig.h \ +	  " +SRC_URI_mipsel += " \ +
> file://mipsel/config.h \ +           file://mipsel/numpyconfig.h \ 
> "
> 
> S = "${WORKDIR}/numpy-${PV}"
> 

anyway something like below is what you need.

SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \
           ${CONFIGFILESURI} \
          "

CONFIGFILESURI ?= ""
CONFIGFILESURI_arm = "file://config.h \
                      file://numpyconfig.h \
                      "

CONFIGFILESURI_mipsel = "file://config.h \
                      file://numpyconfig.h \
                      "
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/j+ckACgkQuwUzVZGdMxRl/QCfZL/I+bjl6bjd2xkb+1lsSXqn
/E0An1i6f1IqSKrdHhHy308N0DK2BI9l
=KzI2
-----END PGP SIGNATURE-----
Elvis Dowson - June 22, 2012, 5:16 a.m.
Hi Khem,

On Jun 22, 2012, at 8:45 AM, Khem Raj wrote:

> OK you can just do
> 
> MACHINE=qemuarm bitbake -e python-numpy | grep -i "^SRC_URI="
> 
> and see what it shows.

That command returned empty.

I'll modify the patch with the CONFIGFILESURI as you suggested.

Best regards,

Elvis Dowson
Khem Raj - June 22, 2012, 5:18 a.m.
On Thu, Jun 21, 2012 at 10:16 PM, Elvis Dowson <elvis.dowson@gmail.com> wrote:
>
>
> That command returned empty.

:) thats what I expected.
Elvis Dowson - June 22, 2012, 2:15 p.m.
Hi Khem,

On Jun 22, 2012, at 8:51 AM, Khem Raj wrote:

> anyway something like below is what you need.
> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \
>           ${CONFIGFILESURI} \
>          "
> 
> CONFIGFILESURI ?= ""
> CONFIGFILESURI_arm = "file://config.h \
>                      file://numpyconfig.h \
>                      "
> 
> CONFIGFILESURI_mipsel = "file://config.h \
>                      file://numpyconfig.h \

I made the changes as you suggested and now the SRCURI is reporting the correct values:

$ MACHINE=qemuarm bitbake -e python-numpy | grep -i "^SRC_URI="
SRC_URI="http://downloads.sourceforge.net/numpy/numpy-1.4.1.tar.gz            file://config.h 	   file://numpyconfig.h"

I'll submit a patch now.

Best regards,

Elvis Dowson

Patch

diff --git a/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb b/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb
index a67bf8b..bdcdf91 100644
--- a/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb
+++ b/meta-oe/recipes-devtools/python/python-numpy_1.4.1.bb
@@ -2,11 +2,17 @@  DESCRIPTION = "A sophisticated Numeric Processing Package for Python"
 SECTION = "devel/python"
 LICENSE = "PSF"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=3c42211d73c3faa1026e671dd39883fa"
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \
-	   file://config.h \
-	   file://numpyconfig.h \
+	  "
+SRC_URI_arm += " \
+           file://arm/config.h \
+           file://arm/numpyconfig.h \
+	  "
+SRC_URI_mipsel += " \
+           file://mipsel/config.h \
+           file://mipsel/numpyconfig.h \
 	  "
 
 S = "${WORKDIR}/numpy-${PV}"