Patchwork libgpsbt: add dbus-glib to DEPENDS

login
register
mail settings
Submitter Andreas Müller
Date April 30, 2011, 12:32 p.m.
Message ID <1304166728-3002-1-git-send-email-schnitzeltony@gmx.de>
Download mbox | patch
Permalink /patch/3043/
State Superseded
Headers show

Comments

Andreas Müller - April 30, 2011, 12:32 p.m.
During performance tests with BB_NUMBER_THREADS > 10
libgpsbt failed with

| /home/Superandy/tmp/sysroots/x86_64-linux/usr/armv7a/lib/gcc/arm-angstrom-linux-gnueabi/4.5.3/../../../../arm-angstrom-linux-gnueabi/bin/ld: cannot find -ldbus-glib-1
| collect2: ld returned 1 exit status
| make[1]: *** [libgpsbt.la] Error 1
| make[1]: Leaving directory `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/libgpsbt-0.1-r2/libgpsbt-0.1'
| make: *** [all] Error 2
| + die 'oe_runmake failed'
| + oefatal 'oe_runmake failed'
| + echo FATAL: 'oe_runmake failed'
| FATAL: oe_runmake failed
| + exit 1
...
ERROR: '/home/Superandy/data/OpenEmbedded/gumstix-oe/recipes/maemo4/libgpsbt_0.1.bb' failed

Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
---
 recipes/maemo4/libgpsbt_0.1.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Paul Menzel - April 30, 2011, 7:41 p.m.
Dear Andreas,


Am Samstag, den 30.04.2011, 14:32 +0200 schrieb Andreas Mueller:
> During performance tests with BB_NUMBER_THREADS > 10
> libgpsbt failed with
> 
> | /home/Superandy/tmp/sysroots/x86_64-linux/usr/armv7a/lib/gcc/arm-angstrom-linux-gnueabi/4.5.3/../../../../arm-angstrom-linux-gnueabi/bin/ld: cannot find -ldbus-glib-1
> | collect2: ld returned 1 exit status
> | make[1]: *** [libgpsbt.la] Error 1
> | make[1]: Leaving directory `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/libgpsbt-0.1-r2/libgpsbt-0.1'
> | make: *** [all] Error 2
> | + die 'oe_runmake failed'
> | + oefatal 'oe_runmake failed'
> | + echo FATAL: 'oe_runmake failed'
> | FATAL: oe_runmake failed
> | + exit 1
> ...
> ERROR: '/home/Superandy/data/OpenEmbedded/gumstix-oe/recipes/maemo4/libgpsbt_0.1.bb' failed

Why is the task compile even executed for your system? Using
`minimal-uclibc` already task configure detects the missing dependency.

        […]
        | checking for GLIB... yes
        | checking for DBUS... configure: error: Package requirements ( dbus-glib-1 >= 0.23 ) were not met:
        |
        | No package 'dbus-glib-1' found
        |
        | Consider adjusting the PKG_CONFIG_PATH environment variable if you
        | installed software in a non-standard prefix.
        |
        | Alternatively, you may set the environment variables DBUS_CFLAGS
        | and DBUS_LIBS to avoid the need to call pkg-config.
        | See the pkg-config man page for more details.
        |
        NOTE: package libgpsbt-0.1-r2: task do_configure: Failed

> Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

> ---
>  recipes/maemo4/libgpsbt_0.1.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/maemo4/libgpsbt_0.1.bb b/recipes/maemo4/libgpsbt_0.1.bb
> index c6c6ea6..d199379 100644
> --- a/recipes/maemo4/libgpsbt_0.1.bb
> +++ b/recipes/maemo4/libgpsbt_0.1.bb
> @@ -1,8 +1,8 @@
>  LICENSE = "nokia"
>  
> -PR = "r2"
> +PR = "r3"

Is that needed?

> -DEPENDS = "libgpsmgr dbus"
> +DEPENDS = "libgpsmgr dbus dbus-glib"
>  
>  # This is proprietary software in Chinook, so we have to stay with the last released
>  # free version.

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
Andreas Müller - May 1, 2011, 4 p.m.
On Saturday, April 30, 2011 09:41:29 PM Paul Menzel wrote:
> Dear Andreas,
> 
> Am Samstag, den 30.04.2011, 14:32 +0200 schrieb Andreas Mueller:
> > During performance tests with BB_NUMBER_THREADS > 10
> > libgpsbt failed with
> > 
> > | /home/Superandy/tmp/sysroots/x86_64-linux/usr/armv7a/lib/gcc/arm-angstr
> > | om-linux-gnueabi/4.5.3/../../../../arm-angstrom-linux-gnueabi/bin/ld:
> > | cannot find -ldbus-glib-1 collect2: ld returned 1 exit status
> > | make[1]: *** [libgpsbt.la] Error 1
> > | make[1]: Leaving directory
> > | `/home/Superandy/tmp/work/armv7a-angstrom-linux-gnueabi/libgpsbt-0.1-r
> > | 2/libgpsbt-0.1' make: *** [all] Error 2
> > | + die 'oe_runmake failed'
> > | + oefatal 'oe_runmake failed'
> > | + echo FATAL: 'oe_runmake failed'
> > | FATAL: oe_runmake failed
> > | + exit 1
> > 
> > ...
> > ERROR:
> > '/home/Superandy/data/OpenEmbedded/gumstix-oe/recipes/maemo4/libgpsbt_0.
> > 1.bb' failed
> 
> Why is the task compile even executed for your system? Using
> `minimal-uclibc` already task configure detects the missing dependency.
I don't know and I do not have the full logs anymore. Maybe it was related to a 
high value of BB_NUMBER_THREADS. I made tests with BB_NUMBER_THREADS = 64.
> 
>         […]
> 
>         | checking for GLIB... yes
>         | checking for DBUS... configure: error: Package requirements (
>         | dbus-glib-1 >= 0.23 ) were not met:
>         | 
>         | No package 'dbus-glib-1' found
>         | 
>         | Consider adjusting the PKG_CONFIG_PATH environment variable if
>         | you installed software in a non-standard prefix.
>         | 
>         | Alternatively, you may set the environment variables DBUS_CFLAGS
>         | and DBUS_LIBS to avoid the need to call pkg-config.
>         | See the pkg-config man page for more details.
> 
>         NOTE: package libgpsbt-0.1-r2: task do_configure: Failed
> 
> > Signed-off-by: Andreas Mueller <schnitzeltony@gmx.de>
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> > ---
> > 
> >  recipes/maemo4/libgpsbt_0.1.bb |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/recipes/maemo4/libgpsbt_0.1.bb
> > b/recipes/maemo4/libgpsbt_0.1.bb index c6c6ea6..d199379 100644
> > --- a/recipes/maemo4/libgpsbt_0.1.bb
> > +++ b/recipes/maemo4/libgpsbt_0.1.bb
> > @@ -1,8 +1,8 @@
> > 
> >  LICENSE = "nokia"
> > 
> > -PR = "r2"
> > +PR = "r3"
> 
> Is that needed?
You are right I think it's not needed. In case there any harm I can resend.
> 
> > -DEPENDS = "libgpsmgr dbus"
> > +DEPENDS = "libgpsmgr dbus dbus-glib"
> > 
> >  # This is proprietary software in Chinook, so we have to stay with the
> >  last released # free version.
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> 
> Thanks,
> 
> Paul

Patch

diff --git a/recipes/maemo4/libgpsbt_0.1.bb b/recipes/maemo4/libgpsbt_0.1.bb
index c6c6ea6..d199379 100644
--- a/recipes/maemo4/libgpsbt_0.1.bb
+++ b/recipes/maemo4/libgpsbt_0.1.bb
@@ -1,8 +1,8 @@ 
 LICENSE = "nokia"
 
-PR = "r2"
+PR = "r3"
 
-DEPENDS = "libgpsmgr dbus"
+DEPENDS = "libgpsmgr dbus dbus-glib"
 
 # This is proprietary software in Chinook, so we have to stay with the last released
 # free version.