Patchwork [bitbake-devel] lib/bb/utils.py: remove unnecessary preserved variables

login
mail settings
Submitter Paul Eggleton
Date June 21, 2012, 2:43 p.m.
Message ID <1340289782-5874-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/30407/
State Accepted
Commit 1c531dff2fb055ecab2d462027eecec3fabc2a44
Headers show

Comments

Paul Eggleton - June 21, 2012, 2:43 p.m.
_ and LANG no longer need to be preserved from the external environment.
The value of _ changes between non-pseudo-wrapped and pseudo-wrapped
invocations (e.g. between "bitbake -p" and "bitbake target") and this
will currently trigger a full reparse in the absence of a whitelist
entry in BB_HASHCONFIG_WHITELIST, which is not ideal.

LANG used to be preserved in order to ensure the C locale was being
used for tools invoked by bitbake, however we now set LC_ALL in
bitbake.conf to take care of this.

Second part of the fix for [YOCTO #2600].

Acked-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 lib/bb/utils.py |    2 --
 1 file changed, 2 deletions(-)

Patch

diff --git a/lib/bb/utils.py b/lib/bb/utils.py
index fc389a3..c1e5a61 100644
--- a/lib/bb/utils.py
+++ b/lib/bb/utils.py
@@ -422,8 +422,6 @@  def preserved_envvars():
         'BB_PRESERVE_ENV',
         'BB_ENV_WHITELIST',
         'BB_ENV_EXTRAWHITE',
-        'LANG',
-        '_',
     ]
     return v + preserved_envvars_exported() + preserved_envvars_exported_interactive()