Patchwork [v2] python-numpy: add missing release dependencies

login
register
mail settings
Submitter Christian Charreyre
Date April 29, 2011, 3:43 p.m.
Message ID <1304091838-23333-3-git-send-email-christian.charreyre@cioinfoindus.fr>
Download mbox | patch
Permalink /patch/3037/
State New, archived
Headers show

Comments

Christian Charreyre - April 29, 2011, 3:43 p.m.
Signed-off-by: C. Charreyre <christian.charreyre@cioinfoindus.fr>
---
 recipes/python/python-numpy_1.1.1.bb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Paul Menzel - May 6, 2011, 8:24 a.m.
Dear Christian,


I just wanted to commit your patches, but looking at this patch again I
have one more question. (I am sorry.)

Am Freitag, den 29.04.2011, 17:43 +0200 schrieb C. Charreyre:
> Signed-off-by: C. Charreyre <christian.charreyre@cioinfoindus.fr>
> ---
>  recipes/python/python-numpy_1.1.1.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/python/python-numpy_1.1.1.bb b/recipes/python/python-numpy_1.1.1.bb
> index f5c23e0..9dda508 100644
> --- a/recipes/python/python-numpy_1.1.1.bb
> +++ b/recipes/python/python-numpy_1.1.1.bb
> @@ -4,6 +4,8 @@ PRIORITY = "optional"
>  LICENSE = "PSF"
>  PR = "ml0"
>  
> +RDEPENDS_${PN} = "python-compiler python-mmap python-pkgutil python-pydoc python-unittest"
> +

Why are those runtime dependencies needed. Does not `python-numpy` start
at all or are just some features of it not working? Depending on that it
should maybe be a `RRECOMMENDS_${PN}`? I am wondering why the original
recipe author did not put them in.

>  SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \
>             file://unbreak-assumptions.diff \
>  	   file://trycompile.diff \


Thanks,

Paul


PS: Do you get the message delivered directly or just the digest? I am
asking because the threading is broken. If you do get the messages,
could you please use the reply to list option of Thunderbird. Then
everything should be fine.

PPS: I am putting you in CC, so that you maybe get my message earlier
and we will be able to commit your patches before the weekend.
Christian Charreyre - May 17, 2011, 8:03 p.m.
Dear Paul,

sorry for late reply, I missed you last mail.

Without these dependencies, I got errors on the target when executing 
mypaint, because python-numpy code calls
import from the distinct packages.

When I install python-numpy alone, there are errors. I'm not an expert 
of python packages splits, that was the way I've
found to force installation of the necessary packages. Perhaps you right 
to replace RDEPENDS by RRECOMMENDS.

Perhaps you can ask someone that does know how relationship between 
python packages must be described in recipes.

Regards.

PS : you suggested in previous mail you will commit the last correction. 
Can you commit the final version after deciding
between RDEPENDS and RRECOMENDS.

Thanks.

Le 06/05/2011 10:24, Paul Menzel a écrit :
> Dear Christian,
>
>
> I just wanted to commit your patches, but looking at this patch again I
> have one more question. (I am sorry.)
>
> Am Freitag, den 29.04.2011, 17:43 +0200 schrieb C. Charreyre:
>> Signed-off-by: C. Charreyre<christian.charreyre@cioinfoindus.fr>
>> ---
>>   recipes/python/python-numpy_1.1.1.bb |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/recipes/python/python-numpy_1.1.1.bb b/recipes/python/python-numpy_1.1.1.bb
>> index f5c23e0..9dda508 100644
>> --- a/recipes/python/python-numpy_1.1.1.bb
>> +++ b/recipes/python/python-numpy_1.1.1.bb
>> @@ -4,6 +4,8 @@ PRIORITY = "optional"
>>   LICENSE = "PSF"
>>   PR = "ml0"
>>
>> +RDEPENDS_${PN} = "python-compiler python-mmap python-pkgutil python-pydoc python-unittest"
>> +
> Why are those runtime dependencies needed. Does not `python-numpy` start
> at all or are just some features of it not working? Depending on that it
> should maybe be a `RRECOMMENDS_${PN}`? I am wondering why the original
> recipe author did not put them in.
>
>>   SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \
>>              file://unbreak-assumptions.diff \
>>   	   file://trycompile.diff \
>
> Thanks,
>
> Paul
>
>
> PS: Do you get the message delivered directly or just the digest? I am
> asking because the threading is broken. If you do get the messages,
> could you please use the reply to list option of Thunderbird. Then
> everything should be fine.
>
> PPS: I am putting you in CC, so that you maybe get my message earlier
> and we will be able to commit your patches before the weekend.

Patch

diff --git a/recipes/python/python-numpy_1.1.1.bb b/recipes/python/python-numpy_1.1.1.bb
index f5c23e0..9dda508 100644
--- a/recipes/python/python-numpy_1.1.1.bb
+++ b/recipes/python/python-numpy_1.1.1.bb
@@ -4,6 +4,8 @@  PRIORITY = "optional"
 LICENSE = "PSF"
 PR = "ml0"
 
+RDEPENDS_${PN} = "python-compiler python-mmap python-pkgutil python-pydoc python-unittest"
+
 SRC_URI = "${SOURCEFORGE_MIRROR}/numpy/numpy-${PV}.tar.gz \
            file://unbreak-assumptions.diff \
 	   file://trycompile.diff \