| Submitter | Khem Raj |
|---|---|
| Date | Jan. 17, 2011, 5:50 p.m. |
| Message ID | <1295286639-4901-1-git-send-email-raj.khem@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/303/ |
| State | Accepted |
| Headers | show |
Comments
2011/1/17 Khem Raj <raj.khem@gmail.com>: > * Tested various builds seems to hold fine > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > conf/distro/minimal.conf | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf > index 5a19cbc..f495d13 100644 > --- a/conf/distro/minimal.conf > +++ b/conf/distro/minimal.conf > @@ -108,7 +108,7 @@ INHERIT += "recipe_sanity" > # PREFERRED VERSIONS > ############################################################################# > require conf/distro/include/preferred-e-versions.inc > -require conf/distro/include/preferred-opie-versions-1.2.4.inc > +require conf/distro/include/preferred-opie-versions-1.2.5.inc > > PREFERRED_PROVIDER_opkg ?= "opkg" > PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg" > @@ -119,7 +119,8 @@ PREFERRED_VERSION_qt4-embedded = "${PREFERRED_QT_VERSION}" > PREFERRED_VERSION_qt4-embedded-gles = "${PREFERRED_QT_VERSION}" > PREFERRED_VERSION_qt4-x11-free = "${PREFERRED_QT_VERSION}" > PREFERRED_VERSION_qt4-x11-free-gles = "${PREFERRED_QT_VERSION}" > - > +PREFERRED_VERSION_perl = "5.10.1" > +PREFERRED_VERSION_perl-native = "5.10.1" > ############################################################################# > # CONTENTS > ############################################################################# > -- > 1.7.2.3 No opinion on the opie stuff, but I'm using perl 5.10.1 for quite a while, so that part has my ack. (maybe split into two patches, one for opie, one for perl). Frans
On 01/17/2011 10:50 AM, Khem Raj wrote: > * Tested various builds seems to hold fine > > Signed-off-by: Khem Raj<raj.khem@gmail.com> > --- > conf/distro/minimal.conf | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf > index 5a19cbc..f495d13 100644 > --- a/conf/distro/minimal.conf > +++ b/conf/distro/minimal.conf > @@ -108,7 +108,7 @@ INHERIT += "recipe_sanity" > # PREFERRED VERSIONS > ############################################################################# > require conf/distro/include/preferred-e-versions.inc > -require conf/distro/include/preferred-opie-versions-1.2.4.inc > +require conf/distro/include/preferred-opie-versions-1.2.5.inc > > PREFERRED_PROVIDER_opkg ?= "opkg" > PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg" > @@ -119,7 +119,8 @@ PREFERRED_VERSION_qt4-embedded = "${PREFERRED_QT_VERSION}" > PREFERRED_VERSION_qt4-embedded-gles = "${PREFERRED_QT_VERSION}" > PREFERRED_VERSION_qt4-x11-free = "${PREFERRED_QT_VERSION}" > PREFERRED_VERSION_qt4-x11-free-gles = "${PREFERRED_QT_VERSION}" > - > +PREFERRED_VERSION_perl = "5.10.1" > +PREFERRED_VERSION_perl-native = "5.10.1" > ############################################################################# > # CONTENTS > ############################################################################# I see different problems with perl 5.10.1 + uclibc + p2020ds, so I guess this is fine with me.
On Mon, Jan 17, 2011 at 11:03 AM, Frans Meulenbroeks <fransmeulenbroeks@gmail.com> wrote: > 2011/1/17 Khem Raj <raj.khem@gmail.com>: >> * Tested various builds seems to hold fine >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> conf/distro/minimal.conf | 5 +++-- >> 1 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf >> index 5a19cbc..f495d13 100644 >> --- a/conf/distro/minimal.conf >> +++ b/conf/distro/minimal.conf >> @@ -108,7 +108,7 @@ INHERIT += "recipe_sanity" >> # PREFERRED VERSIONS >> ############################################################################# >> require conf/distro/include/preferred-e-versions.inc >> -require conf/distro/include/preferred-opie-versions-1.2.4.inc >> +require conf/distro/include/preferred-opie-versions-1.2.5.inc >> >> PREFERRED_PROVIDER_opkg ?= "opkg" >> PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg" >> @@ -119,7 +119,8 @@ PREFERRED_VERSION_qt4-embedded = "${PREFERRED_QT_VERSION}" >> PREFERRED_VERSION_qt4-embedded-gles = "${PREFERRED_QT_VERSION}" >> PREFERRED_VERSION_qt4-x11-free = "${PREFERRED_QT_VERSION}" >> PREFERRED_VERSION_qt4-x11-free-gles = "${PREFERRED_QT_VERSION}" >> - >> +PREFERRED_VERSION_perl = "5.10.1" >> +PREFERRED_VERSION_perl-native = "5.10.1" >> ############################################################################# >> # CONTENTS >> ############################################################################# >> -- >> 1.7.2.3 > > No opinion on the opie stuff, but I'm using perl 5.10.1 for quite a > while, so that part has my ack. > (maybe split into two patches, one for opie, one for perl). > I will commit them as two patches if that helps > Frans > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >
2011/1/17 Khem Raj <raj.khem@gmail.com>: > On Mon, Jan 17, 2011 at 11:03 AM, Frans Meulenbroeks > <fransmeulenbroeks@gmail.com> wrote: >> 2011/1/17 Khem Raj <raj.khem@gmail.com>: >>> * Tested various builds seems to hold fine >>> >>> Signed-off-by: Khem Raj <raj.khem@gmail.com> >>> --- >>> conf/distro/minimal.conf | 5 +++-- >>> 1 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf >>> index 5a19cbc..f495d13 100644 >>> --- a/conf/distro/minimal.conf >>> +++ b/conf/distro/minimal.conf >>> @@ -108,7 +108,7 @@ INHERIT += "recipe_sanity" >>> # PREFERRED VERSIONS >>> ############################################################################# >>> require conf/distro/include/preferred-e-versions.inc >>> -require conf/distro/include/preferred-opie-versions-1.2.4.inc >>> +require conf/distro/include/preferred-opie-versions-1.2.5.inc >>> >>> PREFERRED_PROVIDER_opkg ?= "opkg" >>> PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg" >>> @@ -119,7 +119,8 @@ PREFERRED_VERSION_qt4-embedded = "${PREFERRED_QT_VERSION}" >>> PREFERRED_VERSION_qt4-embedded-gles = "${PREFERRED_QT_VERSION}" >>> PREFERRED_VERSION_qt4-x11-free = "${PREFERRED_QT_VERSION}" >>> PREFERRED_VERSION_qt4-x11-free-gles = "${PREFERRED_QT_VERSION}" >>> - >>> +PREFERRED_VERSION_perl = "5.10.1" >>> +PREFERRED_VERSION_perl-native = "5.10.1" >>> ############################################################################# >>> # CONTENTS >>> ############################################################################# >>> -- >>> 1.7.2.3 >> >> No opinion on the opie stuff, but I'm using perl 5.10.1 for quite a >> while, so that part has my ack. >> (maybe split into two patches, one for opie, one for perl). >> > > I will commit them as two patches if that helps If others are happy (and ack) the combined thing that is fine with me, but as a non-opie user or builder I cannot ack the opie part. Frans.
? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini ???????: > On 01/17/2011 10:50 AM, Khem Raj wrote: > I see different problems with perl 5.10.1 + uclibc + p2020ds, so I guess > this is fine with me. What kind of problems?
On 01/17/2011 09:30 PM, Roman I Khimov wrote: > ? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini ???????: >> On 01/17/2011 10:50 AM, Khem Raj wrote: >> I see different problems with perl 5.10.1 + uclibc + p2020ds, so I guess >> this is fine with me. > > What kind of problems? Khem fixed it tonight. At heart, there's been a need to make much better use of the libc-uclibc override rather than testing TARGET_OS as there's at least 'linux-uclibc', 'linux-uclibceabi' and 'linux-uclibcspe' as valid TARGET_OS combinations. perl has been doing a test for the first two and Khem added a test for the 3rd. This got me to go and audit the recipes for using the _linux-uclibc append and switching them en masse to libc-uclibc. There were a very small number of places that had been catching all 3, but for the most part it was 80% catching the first two and 20% catching just linux-uclibc. I believe but didn't check that Khem caught the rest of the places that were testing for TARGET_OS in shell code and updated them for linux-uclibcspe.
On (18/01/11 20:59), Tom Rini wrote: > On 01/17/2011 09:30 PM, Roman I Khimov wrote: > >? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini ???????: > >>On 01/17/2011 10:50 AM, Khem Raj wrote: > >>I see different problems with perl 5.10.1 + uclibc + p2020ds, so I guess > >>this is fine with me. > > > >What kind of problems? > > Khem fixed it tonight. At heart, there's been a need to make much > better use of the libc-uclibc override rather than testing TARGET_OS > as there's at least 'linux-uclibc', 'linux-uclibceabi' and > 'linux-uclibcspe' as valid TARGET_OS combinations. I thought about it and indeed it would be better to have a LIBC override but its defined in .inc files which may not be included by all distributions, if this makes into bitbake.conf somehow then that would be better or we can decide to have a global data var called LIBC or some sort. perl has been > doing a test for the first two and Khem added a test for the 3rd. > This got me to go and audit the recipes for using the _linux-uclibc > append and switching them en masse to libc-uclibc. There were a > very small number of places that had been catching all 3, but for > the most part it was 80% catching the first two and 20% catching > just linux-uclibc. I believe but didn't check that Khem caught the > rest of the places that were testing for TARGET_OS in shell code and > updated them for linux-uclibcspe. > > -- > Tom Rini > Mentor Graphics Corporation > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
On 01/18/2011 09:29 PM, Khem Raj wrote: > On (18/01/11 20:59), Tom Rini wrote: >> On 01/17/2011 09:30 PM, Roman I Khimov wrote: >>> ? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini ???????: >>>> On 01/17/2011 10:50 AM, Khem Raj wrote: >>>> I see different problems with perl 5.10.1 + uclibc + p2020ds, so I guess >>>> this is fine with me. >>> >>> What kind of problems? >> >> Khem fixed it tonight. At heart, there's been a need to make much >> better use of the libc-uclibc override rather than testing TARGET_OS >> as there's at least 'linux-uclibc', 'linux-uclibceabi' and >> 'linux-uclibcspe' as valid TARGET_OS combinations. > > I thought about it and indeed it would be better to have a LIBC override > but its defined in .inc files which may not be included by all > distributions, if this makes into bitbake.conf somehow then that would > be better or we can decide to have a global data var called LIBC or some > sort. We already did this. A distro that doesn't pull in the right libc inc file is either broken or on its own (I forget and can't check atm if Angstrom uses the files eventually or just also has the libc-foo OVERRIDES, but is correct here). We also have LIBC as a global env way to say what LIBC to use (Angstrom has ANGSTROMLIBC and LIBC since they originated the feature).
On Wed, Jan 19, 2011 at 9:37 AM, Tom Rini <tom_rini@mentor.com> wrote: > On 01/18/2011 09:29 PM, Khem Raj wrote: >> >> On (18/01/11 20:59), Tom Rini wrote: >>> >>> On 01/17/2011 09:30 PM, Roman I Khimov wrote: >>>> >>>> ? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini >>>> ???????: >>>>> >>>>> On 01/17/2011 10:50 AM, Khem Raj wrote: >>>>> I see different problems with perl 5.10.1 + uclibc + p2020ds, so I >>>>> guess >>>>> this is fine with me. >>>> >>>> What kind of problems? >>> >>> Khem fixed it tonight. At heart, there's been a need to make much >>> better use of the libc-uclibc override rather than testing TARGET_OS >>> as there's at least 'linux-uclibc', 'linux-uclibceabi' and >>> 'linux-uclibcspe' as valid TARGET_OS combinations. >> >> I thought about it and indeed it would be better to have a LIBC override >> but its defined in .inc files which may not be included by all >> distributions, if this makes into bitbake.conf somehow then that would >> be better or we can decide to have a global data var called LIBC or some >> sort. > > We already did this. A distro that doesn't pull in the right libc inc file > is either broken or on its own (I forget and can't check atm if Angstrom > uses the files eventually or just also has the libc-foo OVERRIDES, but is > correct here). yes angstrom does. Ok I moved slugos to use it recently so its no more broken :) We also have LIBC as a global env way to say what LIBC to > use (Angstrom has ANGSTROMLIBC and LIBC since they originated the feature). nice we can use LIBC as well if need be but override is more elegant > > -- > Tom Rini > Mentor Graphics Corporation > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >
On 01/19/2011 10:57 AM, Khem Raj wrote: > On Wed, Jan 19, 2011 at 9:37 AM, Tom Rini<tom_rini@mentor.com> wrote: >> On 01/18/2011 09:29 PM, Khem Raj wrote: >>> >>> On (18/01/11 20:59), Tom Rini wrote: >>>> >>>> On 01/17/2011 09:30 PM, Roman I Khimov wrote: >>>>> >>>>> ? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini >>>>> ???????: >>>>>> >>>>>> On 01/17/2011 10:50 AM, Khem Raj wrote: >>>>>> I see different problems with perl 5.10.1 + uclibc + p2020ds, so I >>>>>> guess >>>>>> this is fine with me. >>>>> >>>>> What kind of problems? >>>> >>>> Khem fixed it tonight. At heart, there's been a need to make much >>>> better use of the libc-uclibc override rather than testing TARGET_OS >>>> as there's at least 'linux-uclibc', 'linux-uclibceabi' and >>>> 'linux-uclibcspe' as valid TARGET_OS combinations. >>> >>> I thought about it and indeed it would be better to have a LIBC override >>> but its defined in .inc files which may not be included by all >>> distributions, if this makes into bitbake.conf somehow then that would >>> be better or we can decide to have a global data var called LIBC or some >>> sort. >> >> We already did this. A distro that doesn't pull in the right libc inc file >> is either broken or on its own (I forget and can't check atm if Angstrom >> uses the files eventually or just also has the libc-foo OVERRIDES, but is >> correct here). > > yes angstrom does. Ok I moved slugos to use it recently so its no more broken :) Um, when did SlugOS break then? When I introduced the libc overrides I moved everyone over to it. > We also have LIBC as a global env way to say what LIBC to >> use (Angstrom has ANGSTROMLIBC and LIBC since they originated the feature). > > nice we can use LIBC as well if need be but override is more elegant Yes, LIBC shouldn't be parsed like that, it's like MACHINE :)
On Wed, Jan 19, 2011 at 12:36 PM, Tom Rini <tom_rini@mentor.com> wrote: > On 01/19/2011 10:57 AM, Khem Raj wrote: >> >> On Wed, Jan 19, 2011 at 9:37 AM, Tom Rini<tom_rini@mentor.com> wrote: >>> >>> On 01/18/2011 09:29 PM, Khem Raj wrote: >>>> >>>> On (18/01/11 20:59), Tom Rini wrote: >>>>> >>>>> On 01/17/2011 09:30 PM, Roman I Khimov wrote: >>>>>> >>>>>> ? ????????? ?? ??????????? 17 ?????? 2011 22:14:51 ????? Tom Rini >>>>>> ???????: >>>>>>> >>>>>>> On 01/17/2011 10:50 AM, Khem Raj wrote: >>>>>>> I see different problems with perl 5.10.1 + uclibc + p2020ds, so I >>>>>>> guess >>>>>>> this is fine with me. >>>>>> >>>>>> What kind of problems? >>>>> >>>>> Khem fixed it tonight. At heart, there's been a need to make much >>>>> better use of the libc-uclibc override rather than testing TARGET_OS >>>>> as there's at least 'linux-uclibc', 'linux-uclibceabi' and >>>>> 'linux-uclibcspe' as valid TARGET_OS combinations. >>>> >>>> I thought about it and indeed it would be better to have a LIBC override >>>> but its defined in .inc files which may not be included by all >>>> distributions, if this makes into bitbake.conf somehow then that would >>>> be better or we can decide to have a global data var called LIBC or some >>>> sort. >>> >>> We already did this. A distro that doesn't pull in the right libc inc >>> file >>> is either broken or on its own (I forget and can't check atm if Angstrom >>> uses the files eventually or just also has the libc-foo OVERRIDES, but is >>> correct here). >> >> yes angstrom does. Ok I moved slugos to use it recently so its no more >> broken :) > > Um, when did SlugOS break then? When I introduced the libc overrides I > moved everyone over to it. indeed, I just thought now that its using sane-toolchain but it included conf/distro/include/${LIBC}.inc before too so it was not broken > >> We also have LIBC as a global env way to say what LIBC to >>> >>> use (Angstrom has ANGSTROMLIBC and LIBC since they originated the >>> feature). >> >> nice we can use LIBC as well if need be but override is more elegant > > Yes, LIBC shouldn't be parsed like that, it's like MACHINE :) > > -- > Tom Rini > Mentor Graphics Corporation > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >
Patch
diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf index 5a19cbc..f495d13 100644 --- a/conf/distro/minimal.conf +++ b/conf/distro/minimal.conf @@ -108,7 +108,7 @@ INHERIT += "recipe_sanity" # PREFERRED VERSIONS ############################################################################# require conf/distro/include/preferred-e-versions.inc -require conf/distro/include/preferred-opie-versions-1.2.4.inc +require conf/distro/include/preferred-opie-versions-1.2.5.inc PREFERRED_PROVIDER_opkg ?= "opkg" PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg" @@ -119,7 +119,8 @@ PREFERRED_VERSION_qt4-embedded = "${PREFERRED_QT_VERSION}" PREFERRED_VERSION_qt4-embedded-gles = "${PREFERRED_QT_VERSION}" PREFERRED_VERSION_qt4-x11-free = "${PREFERRED_QT_VERSION}" PREFERRED_VERSION_qt4-x11-free-gles = "${PREFERRED_QT_VERSION}" - +PREFERRED_VERSION_perl = "5.10.1" +PREFERRED_VERSION_perl-native = "5.10.1" ############################################################################# # CONTENTS #############################################################################
* Tested various builds seems to hold fine Signed-off-by: Khem Raj <raj.khem@gmail.com> --- conf/distro/minimal.conf | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)