Patchwork linux-tools: multilib compilation fix

login
register
mail settings
Submitter Bogdan Marinescu
Date June 20, 2012, 8:25 a.m.
Message ID <1340180732-26710-1-git-send-email-bogdan.a.marinescu@intel.com>
Download mbox | patch
Permalink /patch/30253/
State New
Headers show

Comments

Bogdan Marinescu - June 20, 2012, 8:25 a.m.
This patch makes linux-tools compile properly on multilib configurations
(which failed because of some invalid dependencies). Tested by compiling
lib32-core-image-sato-sdk.

Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
 meta/recipes-kernel/linux/linux-tools.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - June 21, 2012, 12:29 p.m.
On Wed, 2012-06-20 at 11:25 +0300, Bogdan Marinescu wrote:
> This patch makes linux-tools compile properly on multilib configurations
> (which failed because of some invalid dependencies). Tested by compiling
> lib32-core-image-sato-sdk.
> 
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>  meta/recipes-kernel/linux/linux-tools.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
> index 3b03c05..048608c 100644
> --- a/meta/recipes-kernel/linux/linux-tools.inc
> +++ b/meta/recipes-kernel/linux/linux-tools.inc
> @@ -34,7 +34,7 @@ do_install_perf[umask] = "022"
>  
>  PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
>  PERFDEPENDS_libc-uclibc = ""
> -PERFRDEPENDS = "python perl elfutils"
> +PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
>  PERFRDEPENDS_libc-uclibc = ""
>  
>  do_compile_perf[depends] = "${PERFDEPENDS}"

Bruce has just totally rearranged this code. Could you check if the new
recipe still suffers from this issue please?

Cheers,

Richard
Bogdan Marinescu - June 21, 2012, 12:32 p.m.
On Thu, Jun 21, 2012 at 3:29 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2012-06-20 at 11:25 +0300, Bogdan Marinescu wrote:
>> This patch makes linux-tools compile properly on multilib configurations
>> (which failed because of some invalid dependencies). Tested by compiling
>> lib32-core-image-sato-sdk.
>>
>> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
>> ---
>>  meta/recipes-kernel/linux/linux-tools.inc |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
>> index 3b03c05..048608c 100644
>> --- a/meta/recipes-kernel/linux/linux-tools.inc
>> +++ b/meta/recipes-kernel/linux/linux-tools.inc
>> @@ -34,7 +34,7 @@ do_install_perf[umask] = "022"
>>
>>  PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
>>  PERFDEPENDS_libc-uclibc = ""
>> -PERFRDEPENDS = "python perl elfutils"
>> +PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
>>  PERFRDEPENDS_libc-uclibc = ""
>>
>>  do_compile_perf[depends] = "${PERFDEPENDS}"
>
> Bruce has just totally rearranged this code. Could you check if the new
> recipe still suffers from this issue please?

Sure, I'm on it.

Thanks,
Bogdan

>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Bruce Ashfield - June 21, 2012, 12:33 p.m.
On Thu, Jun 21, 2012 at 8:32 AM, Marinescu, Bogdan A
<bogdan.a.marinescu@intel.com> wrote:
> On Thu, Jun 21, 2012 at 3:29 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> On Wed, 2012-06-20 at 11:25 +0300, Bogdan Marinescu wrote:
>>> This patch makes linux-tools compile properly on multilib configurations
>>> (which failed because of some invalid dependencies). Tested by compiling
>>> lib32-core-image-sato-sdk.
>>>
>>> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
>>> ---
>>>  meta/recipes-kernel/linux/linux-tools.inc |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
>>> index 3b03c05..048608c 100644
>>> --- a/meta/recipes-kernel/linux/linux-tools.inc
>>> +++ b/meta/recipes-kernel/linux/linux-tools.inc
>>> @@ -34,7 +34,7 @@ do_install_perf[umask] = "022"
>>>
>>>  PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
>>>  PERFDEPENDS_libc-uclibc = ""
>>> -PERFRDEPENDS = "python perl elfutils"
>>> +PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
>>>  PERFRDEPENDS_libc-uclibc = ""
>>>
>>>  do_compile_perf[depends] = "${PERFDEPENDS}"
>>
>> Bruce has just totally rearranged this code. Could you check if the new
>> recipe still suffers from this issue please?
>
> Sure, I'm on it.

Yep. We still need this addition to the recipe .. luckily, easy to do :)

Cheers,

Bruce

>
> Thanks,
> Bogdan
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - June 21, 2012, 12:39 p.m.
On Thu, 2012-06-21 at 08:33 -0400, Bruce Ashfield wrote:
> On Thu, Jun 21, 2012 at 8:32 AM, Marinescu, Bogdan A
> <bogdan.a.marinescu@intel.com> wrote:
> > On Thu, Jun 21, 2012 at 3:29 PM, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> >> On Wed, 2012-06-20 at 11:25 +0300, Bogdan Marinescu wrote:
> >>> This patch makes linux-tools compile properly on multilib configurations
> >>> (which failed because of some invalid dependencies). Tested by compiling
> >>> lib32-core-image-sato-sdk.
> >>>
> >>> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> >>> ---
> >>>  meta/recipes-kernel/linux/linux-tools.inc |    2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
> >>> index 3b03c05..048608c 100644
> >>> --- a/meta/recipes-kernel/linux/linux-tools.inc
> >>> +++ b/meta/recipes-kernel/linux/linux-tools.inc
> >>> @@ -34,7 +34,7 @@ do_install_perf[umask] = "022"
> >>>
> >>>  PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
> >>>  PERFDEPENDS_libc-uclibc = ""
> >>> -PERFRDEPENDS = "python perl elfutils"
> >>> +PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
> >>>  PERFRDEPENDS_libc-uclibc = ""
> >>>
> >>>  do_compile_perf[depends] = "${PERFDEPENDS}"
> >>
> >> Bruce has just totally rearranged this code. Could you check if the new
> >> recipe still suffers from this issue please?
> >
> > Sure, I'm on it.
> 
> Yep. We still need this addition to the recipe .. luckily, easy to do :)

I'm not sure, the autorenaming magic should take care of a simple
RDEPENDS...

Cheers,

Richard
Bruce Ashfield - June 21, 2012, 12:42 p.m.
On Thu, Jun 21, 2012 at 8:39 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Thu, 2012-06-21 at 08:33 -0400, Bruce Ashfield wrote:
>> On Thu, Jun 21, 2012 at 8:32 AM, Marinescu, Bogdan A
>> <bogdan.a.marinescu@intel.com> wrote:
>> > On Thu, Jun 21, 2012 at 3:29 PM, Richard Purdie
>> > <richard.purdie@linuxfoundation.org> wrote:
>> >> On Wed, 2012-06-20 at 11:25 +0300, Bogdan Marinescu wrote:
>> >>> This patch makes linux-tools compile properly on multilib configurations
>> >>> (which failed because of some invalid dependencies). Tested by compiling
>> >>> lib32-core-image-sato-sdk.
>> >>>
>> >>> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
>> >>> ---
>> >>>  meta/recipes-kernel/linux/linux-tools.inc |    2 +-
>> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>>
>> >>> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
>> >>> index 3b03c05..048608c 100644
>> >>> --- a/meta/recipes-kernel/linux/linux-tools.inc
>> >>> +++ b/meta/recipes-kernel/linux/linux-tools.inc
>> >>> @@ -34,7 +34,7 @@ do_install_perf[umask] = "022"
>> >>>
>> >>>  PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
>> >>>  PERFDEPENDS_libc-uclibc = ""
>> >>> -PERFRDEPENDS = "python perl elfutils"
>> >>> +PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
>> >>>  PERFRDEPENDS_libc-uclibc = ""
>> >>>
>> >>>  do_compile_perf[depends] = "${PERFDEPENDS}"
>> >>
>> >> Bruce has just totally rearranged this code. Could you check if the new
>> >> recipe still suffers from this issue please?
>> >
>> > Sure, I'm on it.
>>
>> Yep. We still need this addition to the recipe .. luckily, easy to do :)
>
> I'm not sure, the autorenaming magic should take care of a simple
> RDEPENDS...

Ah yes, I wasn't sure about that myself. I'll just watch and wait in
that case :)

Bruce

>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Bogdan Marinescu - June 21, 2012, 2:59 p.m.
On Thu, Jun 21, 2012 at 3:42 PM, Bruce Ashfield
<bruce.ashfield@gmail.com> wrote:
> On Thu, Jun 21, 2012 at 8:39 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> On Thu, 2012-06-21 at 08:33 -0400, Bruce Ashfield wrote:
>>> On Thu, Jun 21, 2012 at 8:32 AM, Marinescu, Bogdan A
>>> <bogdan.a.marinescu@intel.com> wrote:
>>> > On Thu, Jun 21, 2012 at 3:29 PM, Richard Purdie
>>> > <richard.purdie@linuxfoundation.org> wrote:
>>> >> On Wed, 2012-06-20 at 11:25 +0300, Bogdan Marinescu wrote:
>>> >>> This patch makes linux-tools compile properly on multilib configurations
>>> >>> (which failed because of some invalid dependencies). Tested by compiling
>>> >>> lib32-core-image-sato-sdk.
>>> >>>
>>> >>> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
>>> >>> ---
>>> >>>  meta/recipes-kernel/linux/linux-tools.inc |    2 +-
>>> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >>>
>>> >>> diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
>>> >>> index 3b03c05..048608c 100644
>>> >>> --- a/meta/recipes-kernel/linux/linux-tools.inc
>>> >>> +++ b/meta/recipes-kernel/linux/linux-tools.inc
>>> >>> @@ -34,7 +34,7 @@ do_install_perf[umask] = "022"
>>> >>>
>>> >>>  PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
>>> >>>  PERFDEPENDS_libc-uclibc = ""
>>> >>> -PERFRDEPENDS = "python perl elfutils"
>>> >>> +PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
>>> >>>  PERFRDEPENDS_libc-uclibc = ""
>>> >>>
>>> >>>  do_compile_perf[depends] = "${PERFDEPENDS}"
>>> >>
>>> >> Bruce has just totally rearranged this code. Could you check if the new
>>> >> recipe still suffers from this issue please?
>>> >
>>> > Sure, I'm on it.
>>>
>>> Yep. We still need this addition to the recipe .. luckily, easy to do :)
>>
>> I'm not sure, the autorenaming magic should take care of a simple
>> RDEPENDS...
>
> Ah yes, I wasn't sure about that myself. I'll just watch and wait in
> that case :)

I'm not sure what to think. I don't get the error that I got yesterday
when I compile lib32-core-image-sato-sdk, but I also can't find any
linux-tools package anywhere. Is this normal?

Thanks,
Bogdan

>
> Bruce
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc
index 3b03c05..048608c 100644
--- a/meta/recipes-kernel/linux/linux-tools.inc
+++ b/meta/recipes-kernel/linux/linux-tools.inc
@@ -34,7 +34,7 @@  do_install_perf[umask] = "022"
 
 PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot"
 PERFDEPENDS_libc-uclibc = ""
-PERFRDEPENDS = "python perl elfutils"
+PERFRDEPENDS = "${MLPREFIX}python ${MLPREFIX}perl ${MLPREFIX}elfutils"
 PERFRDEPENDS_libc-uclibc = ""
 
 do_compile_perf[depends] = "${PERFDEPENDS}"