Patchwork debian.bbclass: invoke target objdump

login
register
mail settings
Submitter James Limbouris
Date June 18, 2012, 2:33 a.m.
Message ID <1339986813-17890-1-git-send-email-james@digitalmatter.com.au>
Download mbox | patch
Permalink /patch/30049/
State Accepted
Commit 6d761ae17ddbd3d936e7fe985b40825ad62b2418
Headers show

Comments

James Limbouris - June 18, 2012, 2:33 a.m.
Using the host objdump can lead to errors like:

objdump: library.so.1.0.0: File format is ambiguous
objdump: Matching formats: elf32-littlearm elf32-littlearm-symbian elf32-littlearm-vxworks

with certain configurations of binutils.

Signed-off-by: James Limbouris <james@digitalmatter.com.au>
---
 meta/classes/debian.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Khem Raj - June 18, 2012, 2:44 a.m.
On Sun, Jun 17, 2012 at 7:33 PM, James Limbouris
<james@digitalmatter.com.au> wrote:
> Using the host objdump can lead to errors like:
>
> objdump: library.so.1.0.0: File format is ambiguous
> objdump: Matching formats: elf32-littlearm elf32-littlearm-symbian elf32-littlearm-vxworks
>

yes for target recipes we should always use cross binutils since host
objdump may not have all bfd emulations built in.

> with certain configurations of binutils.
>
> Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> ---
>  meta/classes/debian.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/debian.bbclass b/meta/classes/debian.bbclass
> index 3637e2e..bb4ae11 100644
> --- a/meta/classes/debian.bbclass
> +++ b/meta/classes/debian.bbclass
> @@ -60,7 +60,7 @@ python debian_package_name_hook () {
>                                for f in files:
>                                        if so_re.match(f):
>                                                fp = os.path.join(root, f)
> -                                               cmd = (d.getVar('BUILD_PREFIX', True) or "") + "objdump -p " + fp + " 2>/dev/null"
> +                                               cmd = (d.getVar('TARGET_PREFIX', True) or "") + "objdump -p " + fp + " 2>/dev/null"
>                                                fd = os.popen(cmd)
>                                                lines = fd.readlines()
>                                                fd.close()
> --
> 1.7.3.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - June 18, 2012, 12:43 p.m.
On Mon, 2012-06-18 at 10:33 +0800, James Limbouris wrote:
> Using the host objdump can lead to errors like:
> 
> objdump: library.so.1.0.0: File format is ambiguous
> objdump: Matching formats: elf32-littlearm elf32-littlearm-symbian elf32-littlearm-vxworks
> 
> with certain configurations of binutils.
> 
> Signed-off-by: James Limbouris <james@digitalmatter.com.au>
> ---
>  meta/classes/debian.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/classes/debian.bbclass b/meta/classes/debian.bbclass
index 3637e2e..bb4ae11 100644
--- a/meta/classes/debian.bbclass
+++ b/meta/classes/debian.bbclass
@@ -60,7 +60,7 @@  python debian_package_name_hook () {
 				for f in files:
 					if so_re.match(f):
 						fp = os.path.join(root, f)
-						cmd = (d.getVar('BUILD_PREFIX', True) or "") + "objdump -p " + fp + " 2>/dev/null"
+						cmd = (d.getVar('TARGET_PREFIX', True) or "") + "objdump -p " + fp + " 2>/dev/null"
 						fd = os.popen(cmd)
 						lines = fd.readlines()
 						fd.close()