Patchwork core-image-gtk-directfb, qt4e-demo-image: Remove module-init-tools from IMAGE_INSTALL list

login
register
mail settings
Submitter Laurentiu Palcu
Date June 14, 2012, 1:01 p.m.
Message ID <1339678865-3610-1-git-send-email-laurentiu.palcu@intel.com>
Download mbox | patch
Permalink /patch/29835/
State Accepted
Commit 85d612737d050d4633013c706d9ad6b8169814af
Headers show

Comments

Laurentiu Palcu - June 14, 2012, 1:01 p.m.
As module-init-tools package does not exist anymore there's no reason to
have it in the IMAGE_INSTALL package list. If RPM package manager is
used, build will fail with:

Unable to find package module-init-tools (module-init-tools)!

[Yocto #2580]

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
 .../images/core-image-gtk-directfb.bb              |    3 +--
 meta/recipes-qt/images/qt4e-demo-image.bb          |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
Saul Wold - June 14, 2012, 5:05 p.m.
On 06/14/2012 06:01 AM, Laurentiu Palcu wrote:
> As module-init-tools package does not exist anymore there's no reason to
> have it in the IMAGE_INSTALL package list. If RPM package manager is
> used, build will fail with:
>
> Unable to find package module-init-tools (module-init-tools)!
>
Do we need to replace it with kmod?

Sau!

> [Yocto #2580]
>
> Signed-off-by: Laurentiu Palcu<laurentiu.palcu@intel.com>
> ---
>   .../images/core-image-gtk-directfb.bb              |    3 +--
>   meta/recipes-qt/images/qt4e-demo-image.bb          |    3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-graphics/images/core-image-gtk-directfb.bb b/meta/recipes-graphics/images/core-image-gtk-directfb.bb
> index a5fba17..dcf5165 100644
> --- a/meta/recipes-graphics/images/core-image-gtk-directfb.bb
> +++ b/meta/recipes-graphics/images/core-image-gtk-directfb.bb
> @@ -1,5 +1,5 @@
>   LICENSE = "MIT"
> -PR="r0"
> +PR="r1"
>
>
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> @@ -17,7 +17,6 @@ inherit core-image
>   IMAGE_INSTALL += "\
>   	${CORE_IMAGE_BASE_INSTALL} \
>   	task-core-basic \
> -	module-init-tools \
>   	task-core-gtk-directfb-base \
>   "
>
> diff --git a/meta/recipes-qt/images/qt4e-demo-image.bb b/meta/recipes-qt/images/qt4e-demo-image.bb
> index 6c0dc70..794dac5 100644
> --- a/meta/recipes-qt/images/qt4e-demo-image.bb
> +++ b/meta/recipes-qt/images/qt4e-demo-image.bb
> @@ -1,6 +1,6 @@
>   DESCRIPTION = "Version 1.0-r1 of the qtr3-demo-image."
>   LICENSE = "MIT"
> -PR="r1"
> +PR="r2"
>
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> @@ -13,7 +13,6 @@ RDEPENDS_${PN} += " \
>
>   IMAGE_INSTALL += "\
>   	${CORE_IMAGE_BASE_INSTALL} \
> -	module-init-tools \
>   	task-qt4e-base \
>   "
>
Laurentiu Palcu - June 15, 2012, 1:03 p.m.
Hi,

On 06/14/2012 08:05 PM, Saul Wold wrote:
>> As module-init-tools package does not exist anymore there's no reason to
>> > have it in the IMAGE_INSTALL package list. If RPM package manager is
>> > used, build will fail with:
>> >
>> > Unable to find package module-init-tools (module-init-tools)!
>> >
> Do we need to replace it with kmod?
> 
> Sau!
> 
kmod gets installed in the final image without adding it into the
IMAGE_INSTALL list. I couldn't, yet, figure out how... :( It's not in
the IMAGE_INSTALL and it's not in the RDEPENDS of any other package.
Maybe I missed something. If someone can put some light on this, I would
appreciate it.

Thanks,
Laurentiu
Paul Eggleton - June 15, 2012, 1:36 p.m.
On Friday 15 June 2012 16:03:54 Laurentiu Palcu wrote:
> On 06/14/2012 08:05 PM, Saul Wold wrote:
> >> As module-init-tools package does not exist anymore there's no reason to
> >> > have it in the IMAGE_INSTALL package list. If RPM package manager is
> >> > used, build will fail with:
> >> > 
> >> > Unable to find package module-init-tools (module-init-tools)!
> > 
> > Do we need to replace it with kmod?
> > 
> > Sau!
> 
> kmod gets installed in the final image without adding it into the
> IMAGE_INSTALL list. I couldn't, yet, figure out how... :( It's not in
> the IMAGE_INSTALL and it's not in the RDEPENDS of any other package.
> Maybe I missed something. If someone can put some light on this, I would
> appreciate it.

It's because of the following dependency chain:

task-core-basic -> task-core-basic-extended -> module-init-tools

Since the kmod package RPROVIDES module-init-tools it gets installed.

Cheers,
Paul
Saul Wold - June 18, 2012, 4:48 p.m.
On 06/14/2012 06:01 AM, Laurentiu Palcu wrote:
> As module-init-tools package does not exist anymore there's no reason to
> have it in the IMAGE_INSTALL package list. If RPM package manager is
> used, build will fail with:
>
> Unable to find package module-init-tools (module-init-tools)!
>
> [Yocto #2580]
>
> Signed-off-by: Laurentiu Palcu<laurentiu.palcu@intel.com>
> ---
>   .../images/core-image-gtk-directfb.bb              |    3 +--
>   meta/recipes-qt/images/qt4e-demo-image.bb          |    3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-graphics/images/core-image-gtk-directfb.bb b/meta/recipes-graphics/images/core-image-gtk-directfb.bb
> index a5fba17..dcf5165 100644
> --- a/meta/recipes-graphics/images/core-image-gtk-directfb.bb
> +++ b/meta/recipes-graphics/images/core-image-gtk-directfb.bb
> @@ -1,5 +1,5 @@
>   LICENSE = "MIT"
> -PR="r0"
> +PR="r1"
>
>
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> @@ -17,7 +17,6 @@ inherit core-image
>   IMAGE_INSTALL += "\
>   	${CORE_IMAGE_BASE_INSTALL} \
>   	task-core-basic \
> -	module-init-tools \
>   	task-core-gtk-directfb-base \
>   "
>
> diff --git a/meta/recipes-qt/images/qt4e-demo-image.bb b/meta/recipes-qt/images/qt4e-demo-image.bb
> index 6c0dc70..794dac5 100644
> --- a/meta/recipes-qt/images/qt4e-demo-image.bb
> +++ b/meta/recipes-qt/images/qt4e-demo-image.bb
> @@ -1,6 +1,6 @@
>   DESCRIPTION = "Version 1.0-r1 of the qtr3-demo-image."
>   LICENSE = "MIT"
> -PR="r1"
> +PR="r2"
>
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> @@ -13,7 +13,6 @@ RDEPENDS_${PN} += " \
>
>   IMAGE_INSTALL += "\
>   	${CORE_IMAGE_BASE_INSTALL} \
> -	module-init-tools \
>   	task-qt4e-base \
>   "
>

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-graphics/images/core-image-gtk-directfb.bb b/meta/recipes-graphics/images/core-image-gtk-directfb.bb
index a5fba17..dcf5165 100644
--- a/meta/recipes-graphics/images/core-image-gtk-directfb.bb
+++ b/meta/recipes-graphics/images/core-image-gtk-directfb.bb
@@ -1,5 +1,5 @@ 
 LICENSE = "MIT"
-PR="r0"
+PR="r1"
 
 
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
@@ -17,7 +17,6 @@  inherit core-image
 IMAGE_INSTALL += "\
 	${CORE_IMAGE_BASE_INSTALL} \
 	task-core-basic \
-	module-init-tools \
 	task-core-gtk-directfb-base \
 "
 
diff --git a/meta/recipes-qt/images/qt4e-demo-image.bb b/meta/recipes-qt/images/qt4e-demo-image.bb
index 6c0dc70..794dac5 100644
--- a/meta/recipes-qt/images/qt4e-demo-image.bb
+++ b/meta/recipes-qt/images/qt4e-demo-image.bb
@@ -1,6 +1,6 @@ 
 DESCRIPTION = "Version 1.0-r1 of the qtr3-demo-image."
 LICENSE = "MIT"
-PR="r1"
+PR="r2"
 
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
@@ -13,7 +13,6 @@  RDEPENDS_${PN} += " \
 
 IMAGE_INSTALL += "\
 	${CORE_IMAGE_BASE_INSTALL} \
-	module-init-tools \
 	task-qt4e-base \
 "