Patchwork [2/2] connman: make useradd parameters consistent with rootless X

login
register
mail settings
Submitter Laurentiu Palcu
Date June 12, 2012, 3:17 p.m.
Message ID <1339514272-7427-3-git-send-email-laurentiu.palcu@intel.com>
Download mbox | patch
Permalink /patch/29713/
State Accepted
Commit 28087e7a9ddfd2d118aa907a29ed522bb8cbfc16
Headers show

Comments

Laurentiu Palcu - June 12, 2012, 3:17 p.m.
Both connman and rootless X share the same xuser. However, useradd
parameters are not consistent and if connman runs useradd first,
rootless X will be broken.

[Yocto #2467]

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
 meta/recipes-connectivity/connman/connman.inc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Ross Burton - June 12, 2012, 3:30 p.m.
On 12 June 2012 16:17, Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
> Both connman and rootless X share the same xuser. However, useradd
> parameters are not consistent and if connman runs useradd first,
> rootless X will be broken.

It's probably a good idea to put a comment in X package where the
xuser is also created saying that any changes should be mirrored to
the connman package to avoid this happening again.

Ross

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 4fb7b43..eb174c5 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -47,8 +47,8 @@  INITSCRIPT_NAME = "connman"
 INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
 
 USERADD_PACKAGES = "${PN}"
-USERADD_PARAM_${PN} = "--system --no-create-home \
-                       --shell /bin/false --groups video,tty,audio \
+USERADD_PARAM_${PN} = "--create-home \
+                       --groups video,tty,audio \
                        --user-group xuser"
 
 inherit autotools pkgconfig update-rc.d useradd