Patchwork [V2,0/3] Use openssh to provide sftp-server service

login
register
mail settings
Submitter Lianhao Lu
Date June 12, 2012, 10:10 a.m.
Message ID <cover.1339495723.git.lianhao.lu@intel.com>
Download mbox
Permalink /patch/29695/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib llu/ssh

Comments

Lianhao Lu - June 12, 2012, 10:10 a.m.
This patch set changes dropbear to openssh in the referenced core sato-sdk
image to provide the sftp-server service which is required by some other 
tools, e.g. the Eclipse Remote System Explorer.

The following changes since commit 0eddc176e73e74d4b1a7d3163d65f619fcd4baf0:
  Saul Wold (1):
        gnomebase: add GNOME_COMPRESS_TYPE variable

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib llu/ssh
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=llu/ssh

Lianhao Lu (3):
  task-core-ssh-openssh: Added openssh-sftp-server.
  core-image-sato-sdk: Replace dropbear by openssh.
  classes/image: Allow openssh empty passwords login.

 meta/classes/core-image.bbclass                  |    2 ++
 meta/classes/image.bbclass                       |   10 +++++++++-
 meta/recipes-core/tasks/task-core-ssh-openssh.bb |    2 +-
 meta/recipes-sato/images/core-image-sato-sdk.bb  |    4 +++-
 4 files changed, 15 insertions(+), 3 deletions(-)
Richard Purdie - June 12, 2012, 1:53 p.m.
On Tue, 2012-06-12 at 18:10 +0800, Lianhao Lu wrote:
> This patch set changes dropbear to openssh in the referenced core sato-sdk
> image to provide the sftp-server service which is required by some other 
> tools, e.g. the Eclipse Remote System Explorer.
> 
> The following changes since commit 0eddc176e73e74d4b1a7d3163d65f619fcd4baf0:
>   Saul Wold (1):
>         gnomebase: add GNOME_COMPRESS_TYPE variable
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib llu/ssh
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=llu/ssh
> 
> Lianhao Lu (3):
>   task-core-ssh-openssh: Added openssh-sftp-server.
>   core-image-sato-sdk: Replace dropbear by openssh.
>   classes/image: Allow openssh empty passwords login.

There are some pieces in here I like but I'm not sure overall this is
the right way to make this work. For example, lets say I want to use the
eclipse tools with a plain sato image. Its hard for me to do this with
the patches as they stand. We need to take a step back and think how a
user is going to expect this to work.

I think what we need to do at the basic level is have something like an
IMAGE_FEATURE that we can turn on that pulls in the various IDE
integration pieces. In this case, it would explicitly add openssh/sftp
and we should use the package manager functionality to replace dropbear
with openssh when an image requests both.

This IMAGE_FEATURE would then be on by default for the -sdk image but
could easily be enabled for others.

Cheers,

Richard