Patchwork [1/2] gcc-common: Enable hardfloat ABI when target is arm

login
register
mail settings
Submitter Khem Raj
Date June 9, 2012, 10:19 p.m.
Message ID <1339280364-22585-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/29589/
State Accepted
Commit f48bb903218e14ba15dab452e8bb43ba25b9ea44
Headers show

Comments

Khem Raj - June 9, 2012, 10:19 p.m.
We need to check target to be arm before enabling hard-float
ABI. There are crossdk targets or candian-cross targets built
for arm and we should not enable it for those class of recipes.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-common.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - June 11, 2012, 12:50 p.m.
On Sat, 2012-06-09 at 15:19 -0700, Khem Raj wrote:
> We need to check target to be arm before enabling hard-float
> ABI. There are crossdk targets or candian-cross targets built
> for arm and we should not enable it for those class of recipes.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-common.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Merged to master (along with 2/2), thanks.

Richard

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index c479403..7911ceb 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -10,7 +10,7 @@  inherit autotools gettext
 FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
 
 def get_gcc_fpu_setting(bb, d):
-    if d.getVar('ARMPKGSFX_EABI', True) is "hf":
+    if d.getVar('ARMPKGSFX_EABI', True) is "hf" and  d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
         return "--with-float=hard"
     if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
         return "--with-float=soft"