Patchwork [1/3] libomxil-bellagio: cosmetics: unify recipes

login
register
mail settings
Submitter Paul Menzel
Date Jan. 16, 2011, 11:32 p.m.
Message ID <1295220721.13967.13.camel@mattotaupa>
Download mbox | patch
Permalink /patch/295/
State Accepted
Headers show

Comments

Paul Menzel - Jan. 16, 2011, 11:32 p.m.
Date: Sun, 16 Jan 2011 23:34:08 +0100

Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].

[1] http://wiki.openembedded.org/index.php/Styleguide

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
 recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------
 recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------
 3 files changed, 10 insertions(+), 16 deletions(-)
Koen Kooi - Jan. 17, 2011, 8:14 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-01-11 00:32, Paul Menzel wrote:
> Date: Sun, 16 Jan 2011 23:34:08 +0100
> 
> Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].
> 
> [1] http://wiki.openembedded.org/index.php/Styleguide
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
>  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
>  recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------


FWIW, the above two aren't used and can get deleted, I suspect they
don't even build against our recent ffmpeg

>  recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------
>  3 files changed, 10 insertions(+), 16 deletions(-)
> 
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
> index 3be6dde..aa78d6f 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.0.bb
> @@ -6,13 +6,11 @@ DEPENDS = "alsa-lib ffmpeg \
>  PR = "r7"
>  
>  SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> +SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
> +SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
>  
>  inherit autotools
>  
>  FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
>  FILES_${PN}-dev += "${libdir}/bellagio/*.a"
>  FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
> -
> -
> -SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
> -SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
> index 942f963..958ac26 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.1.bb
> @@ -3,16 +3,14 @@ LICENSE = "LGPLv2"
>  DEPENDS = "alsa-lib ffmpeg \
>             ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
>  
> -SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> -
>  PR = "r1"
>  
> +SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> +SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
> +SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
> +
>  inherit autotools
>  
>  FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
>  FILES_${PN}-dev += "${libdir}/bellagio/*.a"
>  FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
> -
> -
> -SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
> -SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
> diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
> index a58b296..ff30c10 100644
> --- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
> +++ b/recipes/openmax/libomxil-bellagio_0.9.2.bb
> @@ -3,10 +3,12 @@ LICENSE = "LGPLv2"
>  DEPENDS = "alsa-lib ffmpeg \
>             ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
>  
> -SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> -
>  PR = "r1"
>  
> +SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
> +SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
> +SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
> +
>  inherit autotools
>  
>  FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
> @@ -14,7 +16,3 @@ FILES_${PN}-dev += "${libdir}/bellagio/*.a"
>  FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
>  
>  PARALLEL_MAKE = ""
> -
> -
> -SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
> -SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
> 
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNM/psMkyGM64RGpERAoYrAKCTFgLDR/mHygAKKwmD5pqJxfCtSACfb5Wg
TsuMu6328pV5Il9+0+ZBN1w=
=K64M
-----END PGP SIGNATURE-----
Paul Menzel - Jan. 17, 2011, 11:48 a.m.
Am Montag, den 17.01.2011, 09:14 +0100 schrieb Koen Kooi:
> On 17-01-11 00:32, Paul Menzel wrote:
> > Date: Sun, 16 Jan 2011 23:34:08 +0100
> > 
> > Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].
> > 
> > [1] http://wiki.openembedded.org/index.php/Styleguide
> > 
> > Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > ---
> >  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
> >  recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------
> 
> 
> FWIW, the above two aren't used and can get deleted, I suspect they
> don't even build against our recent ffmpeg

Is it alright to send a follow-up patch after this patch series has been
committed?

> >  recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------

Just for my interest, what is the reason to use 0.9.2 instead of
0.9.2.1?

[…]


Thanks,

Paul
Koen Kooi - Jan. 17, 2011, 1:08 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-01-11 12:48, Paul Menzel wrote:
> Am Montag, den 17.01.2011, 09:14 +0100 schrieb Koen Kooi:
>> On 17-01-11 00:32, Paul Menzel wrote:
>>> Date: Sun, 16 Jan 2011 23:34:08 +0100
>>>
>>> Just reorder the lines to be consistent throughout all recipes and to adhere to the style guide [1].
>>>
>>> [1] http://wiki.openembedded.org/index.php/Styleguide
>>>
>>> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
>>> ---
>>>  recipes/openmax/libomxil-bellagio_0.9.0.bb |    6 ++----
>>>  recipes/openmax/libomxil-bellagio_0.9.1.bb |   10 ++++------
>>
>>
>> FWIW, the above two aren't used and can get deleted, I suspect they
>> don't even build against our recent ffmpeg
> 
> Is it alright to send a f
ollow-up patch after this patch series has been
> committed?

surr

> 
>>>  recipes/openmax/libomxil-bellagio_0.9.2.bb |   10 ++++------
> 
> Just for my interest, what is the reason to use 0.9.2 instead of
> 0.9.2.1?

none, I just misread :) 0.9.2 can go as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNND8/MkyGM64RGpERApd6AJ9DR9W5xf8JmOFojgIRHoMijdZNCgCcDRRa
9NuIBOL4QaBwqn3jhGQV5xM=
=AXCH
-----END PGP SIGNATURE-----

Patch

diff --git a/recipes/openmax/libomxil-bellagio_0.9.0.bb b/recipes/openmax/libomxil-bellagio_0.9.0.bb
index 3be6dde..aa78d6f 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.0.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.0.bb
@@ -6,13 +6,11 @@  DEPENDS = "alsa-lib ffmpeg \
 PR = "r7"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
+SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
 
 inherit autotools
 
 FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
 FILES_${PN}-dev += "${libdir}/bellagio/*.a"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
-
-
-SRC_URI[md5sum] = "6d6b6a75bc8751a7421b5e739c53ef6e"
-SRC_URI[sha256sum] = "07128710a699b453dcd7b92e33f2aa8dcbbfe0a657d33040803cdaf0997e442c"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.1.bb b/recipes/openmax/libomxil-bellagio_0.9.1.bb
index 942f963..958ac26 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.1.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.1.bb
@@ -3,16 +3,14 @@  LICENSE = "LGPLv2"
 DEPENDS = "alsa-lib ffmpeg \
            ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
-
 PR = "r1"
 
+SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
+SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
+
 inherit autotools
 
 FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
 FILES_${PN}-dev += "${libdir}/bellagio/*.a"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
-
-
-SRC_URI[md5sum] = "757371e21e4f3653ce4d12d3ba0be1e0"
-SRC_URI[sha256sum] = "9a0864cd442c43e5b69072dc0617b56252bc933fce26f6bfd6d47909287a353a"
diff --git a/recipes/openmax/libomxil-bellagio_0.9.2.bb b/recipes/openmax/libomxil-bellagio_0.9.2.bb
index a58b296..ff30c10 100644
--- a/recipes/openmax/libomxil-bellagio_0.9.2.bb
+++ b/recipes/openmax/libomxil-bellagio_0.9.2.bb
@@ -3,10 +3,12 @@  LICENSE = "LGPLv2"
 DEPENDS = "alsa-lib ffmpeg \
            ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad', d)}"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
-
 PR = "r1"
 
+SRC_URI = "${SOURCEFORGE_MIRROR}/omxil/${PN}-${PV}.tar.gz"
+SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
+SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"
+
 inherit autotools
 
 FILES_${PN} += "${libdir}/bellagio/*.so ${libdir}/bellagio/*.la"
@@ -14,7 +16,3 @@  FILES_${PN}-dev += "${libdir}/bellagio/*.a"
 FILES_${PN}-dbg += "${libdir}/bellagio/.debug"
 
 PARALLEL_MAKE = ""
-
-
-SRC_URI[md5sum] = "42ab7383c4ca4093000ec7062289112b"
-SRC_URI[sha256sum] = "dc5d3cf256390d5419ea7dc3fc35761999a1da99fa4b645ac3e92a6a279c38fc"