diff mbox series

init-manager-systemd.inc: update KERNEL_FEATURES

Message ID 20230824090714.2911613-1-kai.kang@windriver.com
State New
Headers show
Series init-manager-systemd.inc: update KERNEL_FEATURES | expand

Commit Message

Kai Aug. 24, 2023, 9:07 a.m. UTC
From: Kai Kang <kai.kang@windriver.com>

Append cfg/systemd.scc to init-manager-systemd.inc which enables kernel
config CONFIG_FHANDLE. The config is required by systemd >= 209 [1]:

  you have to enable CONFIG_FHANDLE in your kernel to use systemd >= 209
  successfully, otherwise udev won't find any devices.

[1]: https://lists.freedesktop.org/archives/systemd-devel/2014-February/017362.html

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/conf/distro/include/init-manager-systemd.inc | 1 +
 1 file changed, 1 insertion(+)

Comments

Khem Raj Aug. 24, 2023, 4:22 p.m. UTC | #1
On 8/24/23 2:07 AM, Kai Kang wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> Append cfg/systemd.scc to init-manager-systemd.inc which enables kernel
> config CONFIG_FHANDLE. The config is required by systemd >= 209 [1]:
> 
>    you have to enable CONFIG_FHANDLE in your kernel to use systemd >= 209
>    successfully, otherwise udev won't find any devices.
> 
> [1]: https://lists.freedesktop.org/archives/systemd-devel/2014-February/017362.html
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/conf/distro/include/init-manager-systemd.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/conf/distro/include/init-manager-systemd.inc b/meta/conf/distro/include/init-manager-systemd.inc
> index 595d1f2644..8f45a87b50 100644
> --- a/meta/conf/distro/include/init-manager-systemd.inc
> +++ b/meta/conf/distro/include/init-manager-systemd.inc
> @@ -5,3 +5,4 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd"
>   VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units"
>   VIRTUAL-RUNTIME_login_manager ??= "shadow-base"
>   VIRTUAL-RUNTIME_dev_manager ??= "systemd"
> +KERNEL_FEATURES:append = " cfg/systemd.scc"
> 

Can this be always enabled ? udev is used with sysvinit too.
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#186650): https://lists.openembedded.org/g/openembedded-core/message/186650
> Mute This Topic: https://lists.openembedded.org/mt/100932054/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Kai Aug. 25, 2023, 2:53 a.m. UTC | #2
On 8/25/23 00:22, Khem Raj wrote:
> On 8/24/23 2:07 AM, Kai Kang wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> Append cfg/systemd.scc to init-manager-systemd.inc which enables kernel
>> config CONFIG_FHANDLE. The config is required by systemd >= 209 [1]:
>>
>>    you have to enable CONFIG_FHANDLE in your kernel to use systemd >= 
>> 209
>>    successfully, otherwise udev won't find any devices.
>>
>> [1]: 
>> https://lists.freedesktop.org/archives/systemd-devel/2014-February/017362.html
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   meta/conf/distro/include/init-manager-systemd.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/conf/distro/include/init-manager-systemd.inc 
>> b/meta/conf/distro/include/init-manager-systemd.inc
>> index 595d1f2644..8f45a87b50 100644
>> --- a/meta/conf/distro/include/init-manager-systemd.inc
>> +++ b/meta/conf/distro/include/init-manager-systemd.inc
>> @@ -5,3 +5,4 @@ VIRTUAL-RUNTIME_init_manager ??= "systemd"
>>   VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units"
>>   VIRTUAL-RUNTIME_login_manager ??= "shadow-base"
>>   VIRTUAL-RUNTIME_dev_manager ??= "systemd"
>> +KERNEL_FEATURES:append = " cfg/systemd.scc"
>>
>
> Can this be always enabled ? udev is used with sysvinit too.

Just found it had been enabled by default

https://git.yoctoproject.org/yocto-kernel-cache/commit/ktypes/standard/standard.scc?id=3a55d8b019770d78598c3121a6f3479383ef77f2

commit 3a55d8b019770d78598c3121a6f3479383ef77f2
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date:   Fri Feb 14 13:36:54 2014 -0500

     meta: enable CONFIG_FHANDLE for standard and preempt-rt kernels

     CONFIG_FHANDLE is now a requirement for systemd support:

http://cgit.freedesktop.org/systemd/systemd/commit/README?id=c2cb7cbbd526e572b1caa1d7f70be68195b513a9

     So we add it into our default standard and preempt-rt kernel types, the
     overhead is small and having this always configured allows init system
     switching, without a kernel rebuild.

     Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>

diff --git a/ktypes/standard/standard.scc b/ktypes/standard/standard.scc
index 31ebd22f..08563da6 100644
--- a/ktypes/standard/standard.scc
+++ b/ktypes/standard/standard.scc
@@ -91,4 +91,6 @@ include cfg/net/ip_nf.scc
  include cfg/net/ip6_nf.scc
  include cfg/net/bridge.scc

+include cfg/systemd.scc
+
  include features/rfkill/rfkill.scc

Plz ignore it and sorry for inconvenience.

Regards,
Kai

>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#186650): 
>> https://lists.openembedded.org/g/openembedded-core/message/186650
>> Mute This Topic: https://lists.openembedded.org/mt/100932054/1997914
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
>> [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/init-manager-systemd.inc b/meta/conf/distro/include/init-manager-systemd.inc
index 595d1f2644..8f45a87b50 100644
--- a/meta/conf/distro/include/init-manager-systemd.inc
+++ b/meta/conf/distro/include/init-manager-systemd.inc
@@ -5,3 +5,4 @@  VIRTUAL-RUNTIME_init_manager ??= "systemd"
 VIRTUAL-RUNTIME_initscripts ??= "systemd-compat-units"
 VIRTUAL-RUNTIME_login_manager ??= "shadow-base"
 VIRTUAL-RUNTIME_dev_manager ??= "systemd"
+KERNEL_FEATURES:append = " cfg/systemd.scc"