Patchwork [bitbake-devel,v3,15/15] terminal.py: Make screen_inline have a higher priority than screen

login
mail settings
Submitter Jason Wessel
Date June 6, 2012, 8:28 p.m.
Message ID <1339014519-9972-16-git-send-email-jason.wessel@windriver.com>
Download mbox | patch
Permalink /patch/29359/
State New
Headers show

Comments

Jason Wessel - June 6, 2012, 8:28 p.m.
The screen_inline is far easier to use and less confusing for
beginner users of oe-core.  Making this the default improves
the end user experience, and it is possible to change
the OE_TERMINAL variable as well as the default fall back list
with OE_TERMINAL_PREFERRED for anyone who desires the original
behavior.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 meta/lib/oe/terminal.py |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Patch

diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
index 943e5db..3122d56 100644
--- a/meta/lib/oe/terminal.py
+++ b/meta/lib/oe/terminal.py
@@ -55,11 +55,11 @@  class XTerminal(Terminal):
 
 class Gnome(XTerminal):
     command = 'gnome-terminal --disable-factory -t "{title}" -x {command}'
-    priority = 2
+    priority = 3
 
 class Xfce(XTerminal):
     command = 'Terminal -T "{title}" -e "{command}"'
-    priority = 2
+    priority = 3
 
     def __init__(self, command, title=None, env=None):
         # Upstream binary name is Terminal but Debian/Ubuntu use
@@ -73,7 +73,7 @@  class Xfce(XTerminal):
 
 class Konsole(XTerminal):
     command = 'konsole -T "{title}" -e {command}'
-    priority = 2
+    priority = 3
 
     def __init__(self, command, title=None, env=None):
         # Check version
@@ -86,14 +86,15 @@  class Konsole(XTerminal):
 
 class XTerm(XTerminal):
     command = 'xterm -T "{title}" -e {command}'
-    priority = 1
+    priority = 2
 
 class Rxvt(XTerminal):
     command = 'rxvt -T "{title}" -e {command}'
-    priority = 1
+    priority = 2
 
 class Screen_inline(Terminal):
     command = 'screen -D -m -t "{title}" -S devshell {command}'
+    priority = 1
 
     def __init__(self, command, title=None, env=None):
         Terminal.__init__(self, command, title, env)