Patchwork [1/1] git fetcher: make tag back to work, fix Yocto bug 972

login
register
mail settings
Submitter Yu Ke
Date April 27, 2011, 4:48 a.m.
Message ID <73f9675c0e2ea187dafb85330f3e0f6c4902add8.1303879603.git.ke.yu@intel.com>
Download mbox | patch
Permalink /patch/2895/
State New, archived
Headers show

Comments

Yu Ke - April 27, 2011, 4:48 a.m.
From: Yu Ke <ke.yu@intel.com>

In current git fetcher, tag does not work due to commit http://git.pokylinux.org/cgit/cgit.cgi/poky/commit/?id=5920e85c561624e657c126df58f5c378a8950bbc. Tag is not in sha256 form, so it will be treated invalid, and silently replaced by latest revision.

To fix it, this patch treat tag name as branches name, thus it will be handled correctly later. Thanks Richard for reviewing and proposing the better approach.

Fix [YOCTO #972]

CC: Richard Purdie <richard.purdie@linuxfoundation.org>

Signed-off-by: Yu Ke <ke.yu@intel.com>
---
 bitbake/lib/bb/fetch2/git.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index d462acf..811acbf 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -81,6 +81,7 @@  class Git(FetchMethod):
         for name in ud.names:
             # Ensure anything that doesn't look like a sha256 checksum/revision is translated into one
             if not ud.revisions[name] or len(ud.revisions[name]) != 40  or (False in [c in "abcdef0123456789" for c in ud.revisions[name]]):
+                ud.branches[name] = ud.revisions[name]
                 ud.revisions[name] = self.latest_revision(ud.url, ud, d, name)
 
     def localpath(self, url, ud, d):