From patchwork Wed May 30 12:01:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel, 2/2] Hob: add the 'build new' be as the primary action for 'Image detail' page Date: Wed, 30 May 2012 12:01:11 -0000 From: An, LimingX L X-Patchwork-Id: 28937 Message-Id: <433b599051655ff565d42e949cf351d5436b3294.1338379209.git.limingx.l.an@intel.com> To: bitbake-devel@lists.openembedded.org As ui design, we should set at least one primary action for 'My Image' and 'Image detail' screen as the differnt selected image. if no 'run image' or no 'save as template' or no 'deploy image' we should set 'build new image' [YOCTO #2326] Signed-off-by: Liming An --- bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 19 ++++++++----------- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py index 9d57dc0..deb053c 100755 --- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py +++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py @@ -431,23 +431,20 @@ class ImageDetailsPage (HobPage): self.details_bottom_buttons.pack_end(save_button, expand=False, fill=False) create = True - if not packed: - box = gtk.HBox(False, 6) - box.show() - subbox = gtk.HBox(False, 0) - subbox.set_size_request(205, 49) - subbox.show() - box.add(subbox) - self.details_bottom_buttons.pack_end(box, False, False) - name = "Build new image" if name in buttonlist: # create button "Build new image" - build_new_button = HobAltButton("Build new image") + if packed: + build_new_button = HobAltButton("Build new image") + self.details_bottom_buttons.pack_start(build_new_button, expand=False, fill=False) + else: + build_new_button = HobButton("Build new image") + build_new_button.set_size_request(205, 49) + build_new_button.set_flags(gtk.CAN_DEFAULT) + self.details_bottom_buttons.pack_end(build_new_button, expand=False, fill=False) build_new_button.set_tooltip_text("Create a new image from scratch") button_id = build_new_button.connect("clicked", self.build_new_button_clicked_cb) self.button_ids[button_id] = build_new_button - self.details_bottom_buttons.pack_start(build_new_button, expand=False, fill=False) def get_kernel_file_name(self, image_name): name_list = []