Patchwork package.bbclass: Add warning about FILES containing '//'

login
register
mail settings
Submitter Richard Purdie
Date May 30, 2012, 10:59 a.m.
Message ID <1338375541.20169.119.camel@ted>
Download mbox | patch
Permalink /patch/28923/
State Accepted
Commit 0e33e314b1d2d3779658696f13a274b20d698667
Headers show

Comments

Richard Purdie - May 30, 2012, 10:59 a.m.
'//' in a FILES variable causes hard to track down issues with
packaging. This adds a warning and attempts to auto-correct the issue to
try and make the problem more user friendly.

[YOCTO #2448]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index bc83bfb..6bce742 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -917,6 +917,9 @@  python populate_packages () {
 		files = filesvar.split()
 		file_links = {}
 		for file in files:
+			if file.find("//") != -1:
+				bb.warn("FILES variable for package %s contains '//' which is invalid. Attempting to fix this but you should correct the metadata.\n" % pkg)
+				file.replace("//", "/")
 			if os.path.isabs(file):
 				file = '.' + file
 			if not os.path.islink(file):