From patchwork Wed May 30 10:19:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [bitbake-devel,1/1] HOB: 'str' object has no attribute 'close' Date: Wed, 30 May 2012 10:19:08 -0000 From: Robert Yang X-Patchwork-Id: 28921 Message-Id: To: Cc: Zhenfeng.Zhao@windriver.com For builddetailspage.py: The "f" was a stream in the past, it is a string now, so it doesn't need f.close(), and change its name to "branch". And we don't need the "2>&1" since bb.process.run() can handle it, it will raise exception when error occurs, we should handle the exception ourselves if we want to ignore the error. For hig.py: Use bb.process.Popen() since it doesn't need the return value. If we use bb.process.run(), the parent process will wait for the child process to terminate to get the result. [YOCTO #2511] Signed-off-by: Robert Yang --- bitbake/lib/bb/ui/crumbs/builddetailspage.py | 7 +++---- bitbake/lib/bb/ui/crumbs/hig.py | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/bitbake/lib/bb/ui/crumbs/builddetailspage.py b/bitbake/lib/bb/ui/crumbs/builddetailspage.py index 0741a7b..b1afe10 100755 --- a/bitbake/lib/bb/ui/crumbs/builddetailspage.py +++ b/bitbake/lib/bb/ui/crumbs/builddetailspage.py @@ -98,11 +98,10 @@ class BuildConfigurationTreeView(gtk.TreeView): for path in src_config_info.layers: import os, os.path if os.path.exists(path): - f, errors = bb.process.run('cd %s; git branch 2>&1 | grep "^* " | tr -d "* "' % path) - if f: - branch = f.strip('\n') + branch = bb.process.run('cd %s; git branch | grep "^* " | tr -d "* "' % path)[0] + if branch: + branch = branch.strip('\n') vars.append(self.set_vars("Branch:", branch)) - f.close() break self.set_config_model(vars) diff --git a/bitbake/lib/bb/ui/crumbs/hig.py b/bitbake/lib/bb/ui/crumbs/hig.py index 38f890b..17b9408 100644 --- a/bitbake/lib/bb/ui/crumbs/hig.py +++ b/bitbake/lib/bb/ui/crumbs/hig.py @@ -829,7 +829,7 @@ class DeployImageDialog (CrumbsDialog): cmdline = bb.ui.crumbs.utils.which_terminal() if cmdline: cmdline += "\"sudo dd if=" + self.image_path + " of=" + combo_item + "\"" - bb.process.run(shlex.split(cmdline)) + bb.process.Popen(shlex.split(cmdline)) def update_progress_bar(self, title, fraction, status=None): self.progress_bar.update(fraction)