Patchwork [0/4] replace os.system/popen with subprocess module

login
register
mail settings
Submitter Robert Yang
Date May 29, 2012, 2:53 p.m.
Message ID <cover.1338302685.git.liezhi.yang@windriver.com>
Download mbox
Permalink /patch/28881/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib robert/meta_subprocess

Comments

Robert Yang - May 29, 2012, 2:53 p.m.
These patches are based on oe-core.

* Testinfo
  1) $ bitbake core-image-sato core-image-sato-sdk metatoolchain-sdk with
        MACHINE=qemuarm, PACKAGE_CLASSES = "package_rpm"

  2) $ bitbake core-image-sato core-image-sato-sdk metatoolchain-sdk with
        MACHINE=qemuarm, PACKAGE_CLASSES = "package_ipk"

  3) $ bitbake core-image-sato with MACHINE=qemux86, PACKAGE_CLASSES = "package_deb"

  4) $ bitbake world with MACHINE=qemux86

// Robert

The following changes since commit a7532d6b2870a51079c39366def9ae55faeba626:

  rootfs_rpm.bbclass: save rpmlib rather than remove it (2012-05-29 22:36:39 +0800)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib robert/meta_subprocess
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/meta_subprocess

Robert Yang (4):
  meta: replace os.system with subprocess.call
  scripts: replace os.system with subprocess.call
  meta: replace os.popen with subprocess.Popen
  scripts: replace os.popen with subprocess.Popen

 meta/classes/archiver.bbclass                   |    3 +-
 meta/classes/debian.bbclass                     |   12 ++++--
 meta/classes/distrodata.bbclass                 |   17 ++++----
 meta/classes/icecc.bbclass                      |    6 +-
 meta/classes/imagetest-qemu.bbclass             |    9 ++--
 meta/classes/insane.bbclass                     |   46 ++++++++++++++-------
 meta/classes/kernel.bbclass                     |    6 +-
 meta/classes/metadata_scm.bbclass               |   12 ++---
 meta/classes/package.bbclass                    |   49 ++++++++++++----------
 meta/classes/package_deb.bbclass                |    3 +-
 meta/classes/package_ipk.bbclass                |   13 ++++--
 meta/classes/package_tar.bbclass                |    6 ++-
 meta/classes/sanity.bbclass                     |   13 +++---
 meta/classes/sstate.bbclass                     |    9 +++-
 meta/lib/oe/distro_check.py                     |    3 +-
 meta/recipes-core/busybox/busybox.inc           |    3 +-
 meta/recipes-core/uclibc/uclibc.inc             |    7 ++-
 meta/recipes-extended/cups/cups14.inc           |    3 +-
 scripts/contrib/python/generate-manifest-2.7.py |    3 +-
 scripts/rpm-createsolvedb.py                    |    5 +-
 scripts/swabber-strace-attach                   |    3 +-
 21 files changed, 136 insertions(+), 95 deletions(-)
Richard Purdie - May 30, 2012, 11:59 a.m.
On Tue, 2012-05-29 at 22:53 +0800, Robert Yang wrote:
> These patches are based on oe-core.
> 
> * Testinfo
>   1) $ bitbake core-image-sato core-image-sato-sdk metatoolchain-sdk with
>         MACHINE=qemuarm, PACKAGE_CLASSES = "package_rpm"
> 
>   2) $ bitbake core-image-sato core-image-sato-sdk metatoolchain-sdk with
>         MACHINE=qemuarm, PACKAGE_CLASSES = "package_ipk"
> 
>   3) $ bitbake core-image-sato with MACHINE=qemux86, PACKAGE_CLASSES = "package_deb"
> 
>   4) $ bitbake world with MACHINE=qemux86
> 
> // Robert
> 
> The following changes since commit a7532d6b2870a51079c39366def9ae55faeba626:
> 
>   rootfs_rpm.bbclass: save rpmlib rather than remove it (2012-05-29 22:36:39 +0800)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib robert/meta_subprocess
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/meta_subprocess
> 
> Robert Yang (4):
>   meta: replace os.system with subprocess.call
>   scripts: replace os.system with subprocess.call
>   meta: replace os.popen with subprocess.Popen

I took the first three of these, thanks.

>   scripts: replace os.popen with subprocess.Popen

As Chris says, we may as well use an unlink call for this case.

Cheers,

Richard