Patchwork classes/sanity: remove broken TARGET_ARCH check

login
register
mail settings
Submitter Paul Eggleton
Date May 28, 2012, 2:34 p.m.
Message ID <1338215657-6618-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/28859/
State Accepted
Commit 897a9b1dddef385253b16ea7c193483e0ea679b6
Headers show

Comments

Paul Eggleton - May 28, 2012, 2:34 p.m.
The variable name has been typo'd as TARGE_ARCH since it was introduced
some time ago, so the check has never worked. Fixing the typo shows that
the test is not quite functional, so let's just remove it:

http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/010613.html

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/classes/sanity.bbclass |    4 ----
 1 file changed, 4 deletions(-)
Richard Purdie - May 30, 2012, 12:01 p.m.
On Mon, 2012-05-28 at 15:34 +0100, Paul Eggleton wrote:
> The variable name has been typo'd as TARGE_ARCH since it was introduced
> some time ago, so the check has never worked. Fixing the typo shows that
> the test is not quite functional, so let's just remove it:
> 
> http://lists.linuxtogo.org/pipermail/openembedded-core/2011-October/010613.html
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/classes/sanity.bbclass |    4 ----
>  1 file changed, 4 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index a2b45bc..8332105 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -248,10 +248,6 @@  def check_sanity_validmachine(sanity_data):
     if sanity_data.getVar('TUNE_ARCH', True) == 'INVALID':
         messages = messages + 'TUNE_ARCH is unset. Please ensure your MACHINE configuration includes a valid tune configuration file which will set this correctly.\n'
 
-    # Check TARGET_ARCH is set correctly
-    if sanity_data.getVar('TARGE_ARCH', False) == '${TUNE_ARCH}':
-        messages = messages + 'TARGET_ARCH is being overwritten, likely by your MACHINE configuration files.\nPlease use a valid tune configuration file which should set this correctly automatically\nand avoid setting this in the machine configuration. See the OE-Core mailing list for more information.\n'
-    
     # Check TARGET_OS is set
     if sanity_data.getVar('TARGET_OS', True) == 'INVALID':
         messages = messages + 'Please set TARGET_OS directly, or choose a MACHINE or DISTRO that does so.\n'