Patchwork [1/2] buildhistory_analysis: fix error when version specifier missing

login
register
mail settings
Submitter Paul Eggleton
Date May 28, 2012, 12:57 p.m.
Message ID <981510e35f03f1c90e7ab2cf4fd7a0bbe5045f67.1338209763.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/28855/
State Accepted
Commit 90caa605bd24279e4a9204e279492754119a8a55
Headers show

Comments

Paul Eggleton - May 28, 2012, 12:57 p.m.
Passing None to split_versions() will raise an exception, so check that
the version is specified before passing it in.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/lib/oe/buildhistory_analysis.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta/lib/oe/buildhistory_analysis.py b/meta/lib/oe/buildhistory_analysis.py
index 313416c..29dc4a9 100644
--- a/meta/lib/oe/buildhistory_analysis.py
+++ b/meta/lib/oe/buildhistory_analysis.py
@@ -272,7 +272,7 @@  def compare_pkg_lists(astr, bstr):
         if k in depverb:
             dva = depvera[k]
             dvb = depverb[k]
-            if dva != dvb:
+            if dva and dvb and dva != dvb:
                 if bb.utils.vercmp(split_version(dva), split_version(dvb)) < 0:
                     remove.append(k)