Patchwork [13/32] utils.bbclass: Testing via env in create_wrapper is a nice idea but breaks things

login
register
mail settings
Submitter Scott Garman
Date May 24, 2012, 9:38 p.m.
Message ID <915769c405e24751eae613e9ef55f05490a726de.1337892418.git.scott.a.garman@intel.com>
Download mbox | patch
Permalink /patch/28677/
State New
Headers show

Comments

Scott Garman - May 24, 2012, 9:38 p.m.
From: Richard Purdie <richard.purdie@linuxfoundation.org>

For example, pseudo-native wants to set LD_LIBRBARY_PATH but setting this
into the environment here causes the existing pseudo (running during do_install)
to poke into paths in /opt and this breaks builds.

The simplest fix is simply not to do this. Comments tweaks to match the code.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/utils.bbclass |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 3b59463..fde8f44 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -282,7 +282,6 @@  create_cmdline_wrapper () {
    cmd=$1
    shift
 
-   # run echo via env to test syntactic validity of the variable arguments
    echo "Generating wrapper script for $cmd"
 
    mv $cmd $cmd.real
@@ -306,8 +305,7 @@  create_wrapper () {
    cmd=$1
    shift
 
-   # run echo via env to test syntactic validity of the variable arguments
-   env $@ echo "Generating wrapper script for $cmd"
+   echo "Generating wrapper script for $cmd"
 
    mv $cmd $cmd.real
    cmdname=`basename $cmd`.real