Patchwork [bitbake-devel] bitbake/exceptions: Handle reports from the field of exception code failures

login
register
mail settings
Submitter Richard Purdie
Date May 24, 2012, 1:23 p.m.
Message ID <1337865824.8248.112.camel@ted>
Download mbox | patch
Permalink /patch/28611/
State New
Headers show

Comments

Richard Purdie - May 24, 2012, 1:23 p.m.
Despite using python 2.6, there have been reports of issues where
bitbake is printing tracebacks with errors in the exception handling
code. This was masking the real error.

Since we need to do whatever we can to give the user good feedback about
errors, detect the tuple instead of namedtuple case and don't fault
in the exception handler but just give up trying to traceback any further.

In the reported cases, this gives a message the user can then understand.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/bitbake/lib/bb/exceptions.py b/bitbake/lib/bb/exceptions.py
index 4dd3e2c..f182c8f 100644
--- a/bitbake/lib/bb/exceptions.py
+++ b/bitbake/lib/bb/exceptions.py
@@ -32,7 +32,14 @@  class TracebackEntry(namedtuple.abc):
 def _get_frame_args(frame):
     """Get the formatted arguments and class (if available) for a frame"""
     arginfo = inspect.getargvalues(frame)
-    if not arginfo.args:
+
+    try:
+        if not arginfo.args:
+            return '', None
+    # There have been reports from the field of python 2.6 which doesn't 
+    # return a namedtuple here but simply a tuple so fallback gracefully if
+    # args isn't present.
+    except AttributeError:
         return '', None
 
     firstarg = arginfo.args[0]