Patchwork Added Europe/Berlin timezone to tzdata pkg

login
register
mail settings
Submitter Lars Michelsen
Date Jan. 16, 2011, 12:45 a.m.
Message ID <1295138727-6516-1-git-send-email-lm@larsmichelsen.com>
Download mbox | patch
Permalink /patch/286/
State Rejected
Headers show

Comments

Lars Michelsen - Jan. 16, 2011, 12:45 a.m.
I was missing the Europe/Berlin timezone in the tzdata package. So I
added it to the package.

Additionally increased the PR. Hope this OK for such a change - must
admit that I am very new to OE.

Signed-off-by: Lars Michelsen <lm@larsmichelsen.com>
---
 recipes/tzdata/tzdata.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Paul Menzel - Jan. 16, 2011, 11:47 a.m.
Dear Lars,


Am Sonntag, den 16.01.2011, 01:45 +0100 schrieb Lars Michelsen:
> I was missing the Europe/Berlin timezone in the tzdata package. So I
> added it to the package.
> 
> Additionally increased the PR. Hope this OK for such a change - must
> admit that I am very new to OE.

thank you very much for your patch and welcome to OE.

Could you please resend your patch (`[PATCH v2]`) with the following two
points addressed.

1. The commit summary is standardized and should start with the package
name as documented in the commit policy [1].

	tzdata: package `Europe/Berlin` timezone

2. Although it probably does not matter, commit messages are normally
written from a neutral view point(?) and personal comments are added
after a `---` before the diff which starts also with `---`. When
applying your patch, these remarks are left out then.

> Signed-off-by: Lars Michelsen <lm@larsmichelsen.com>

[…]

With these two issues addressed you can add

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

to the commit message when resending.


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Commit_Policy
[2] http://wiki.openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded#Create_and_Commit_your_patch
Koen Kooi - Jan. 16, 2011, 12:04 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 16-01-11 01:45, Lars Michelsen wrote:
> I was missing the Europe/Berlin timezone in the tzdata package. So I
> added it to the package.

NAK! The main tzdate package is kept as small as possible, only
packaging one tz per continent.

If we look at your patch:

>                  ${datadir}/zoneinfo/Europe/Paris         \
> +                ${datadir}/zoneinfo/Europe/Berlin        \

We see you are adding Berlin right below Paris, which is the same TZ
with the same DST rules.

So if you only want to install tzdata and want to have 'date' show the
correct time, use Europe/Paris. If you nationalism prevents you from
doing that and you have some space left in your rootfs, install
'tzdata-europe' :)

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNMt6zMkyGM64RGpERApd6AJ9Qz6A/MXfQY3yJq+eGUB5s7+4+IACeIjLQ
uq7sMCxdkcbyZPKabJO+kck=
=0NoX
-----END PGP SIGNATURE-----
Lars Michelsen - Jan. 21, 2011, 8:30 p.m.
Hello Paul,

On 16/01/11 12:47, Paul Menzel wrote:
> Dear Lars,
>
>
> Am Sonntag, den 16.01.2011, 01:45 +0100 schrieb Lars Michelsen:
>> I was missing the Europe/Berlin timezone in the tzdata package. So I
>> added it to the package.
>>
>> Additionally increased the PR. Hope this OK for such a change - must
>> admit that I am very new to OE.
>
> thank you very much for your patch and welcome to OE.
>
> Could you please resend your patch (`[PATCH v2]`) with the following two
> points addressed.
>
> 1. The commit summary is standardized and should start with the package
> name as documented in the commit policy [1].
>
> 	tzdata: package `Europe/Berlin` timezone
>
> 2. Although it probably does not matter, commit messages are normally
> written from a neutral view point(?) and personal comments are added
> after a `---` before the diff which starts also with `---`. When
> applying your patch, these remarks are left out then.

Thanks for the information. I'll do so on my next postings.

But after the post of Koen I am unsure if I should resubmit this patch. 
My intend was to fix my time, setting the TZ to Europe/Paris fixes this 
and is absolutely ok for me. Other thoughts?

Regards,
Lars
Lars Michelsen - Jan. 21, 2011, 8:32 p.m.
Hello Koen,

On 16/01/11 13:04, Koen Kooi wrote:
> We see you are adding Berlin right below Paris, which is the same TZ
> with the same DST rules.
>
> So if you only want to install tzdata and want to have 'date' show the
> correct time, use Europe/Paris. If you nationalism prevents you from
> doing that and you have some space left in your rootfs, install
> 'tzdata-europe' :)

Well, thanks for the hint. I am new to OE and need to get a feeling for 
the priorities. If the size is that important it is OK for me.

Even didn't know that the DST is exactly the same. My intend was to fix 
my local time and when it can be fixed with Europe/Paris I have no 
problem with it.

Regards,
Lars

Patch

diff --git a/recipes/tzdata/tzdata.inc b/recipes/tzdata/tzdata.inc
index dd5c2c9..5597232 100644
--- a/recipes/tzdata/tzdata.inc
+++ b/recipes/tzdata/tzdata.inc
@@ -3,7 +3,7 @@  SECTION = "base"
 PRIORITY = "optional"
 DEPENDS = "tzcode-native"
 
-INC_PR = "r8"
+INC_PR = "r9"
 
 DEFAULT_TIMEZONE ?= "Europe/London"
 
@@ -132,6 +132,7 @@  FILES_${PN} += "${datadir}/zoneinfo/Pacific/Honolulu     \
                 ${datadir}/zoneinfo/America/Sao_Paulo    \
                 ${datadir}/zoneinfo/Europe/London        \
                 ${datadir}/zoneinfo/Europe/Paris         \
+                ${datadir}/zoneinfo/Europe/Berlin        \
                 ${datadir}/zoneinfo/Africa/Cairo         \
                 ${datadir}/zoneinfo/Europe/Moscow        \
                 ${datadir}/zoneinfo/Asia/Dubai           \