| Submitter | Joshua Lock |
|---|---|
| Date | May 24, 2012, 12:03 a.m. |
| Message ID | <3cdd2984697d7068273ebaa3545fa25caf806fb9.1337816265.git.josh@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/28515/ |
| State | New |
| Headers | show |
Comments
On 23/05/12 17:03, Joshua Lock wrote: > If the user does not have write permissions to SSTATE_CACHE, detected by > the check_create_long_filename() test failing with a "Permission denied" > value in strerror, then suggest they might want to use the location as > an entry in SSTATE_MIRRORS. > > Signed-off-by: Joshua Lock<josh@linux.intel.com> > --- > meta/classes/sanity.bbclass | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index 39da14b..e86edf7 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -100,6 +100,9 @@ def check_sanity_sstate_dir_change(sstate_dir, data): > testmsg = "" > if sstate_dir != "": > testmsg = check_create_long_filename(sstate_dir, "SSTATE_DIR") > + # If we don't have permissions to SSTATE_DIR, suggest the user set it as an SSTATE_MIRRORS > + if testmsg.split(': ')[1].strip() == "Permission denied.": > + testmsg = testmsg + "You could try using %s in SSTATE_MIRRORS rather than as an SSTATE_CACHE.\n" % (sstate_dir) > return testmsg Whoops. This one breaks when check_create_long_filename() succeeds. I've updated the git repo with the following hunk instead of above: + # If we don't have permissions to SSTATE_DIR, suggest the user set it as an SSTATE_MIRRORS + try: + err = testmsg.split(': ')[1].strip() + if err == "Permission denied.": + testmsg = testmsg + "You could try using %s in SSTATE_MIRRORS rather than as an SSTATE_CACHE.\n" % (sstate_dir) + except IndexError: + pass Tested with both an SSTATE_DIR I can write to and one I can't. Thanks, Joshua > > def check_sanity_tmpdir_change(tmpdir, data):
Patch
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 39da14b..e86edf7 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -100,6 +100,9 @@ def check_sanity_sstate_dir_change(sstate_dir, data): testmsg = "" if sstate_dir != "": testmsg = check_create_long_filename(sstate_dir, "SSTATE_DIR") + # If we don't have permissions to SSTATE_DIR, suggest the user set it as an SSTATE_MIRRORS + if testmsg.split(': ')[1].strip() == "Permission denied.": + testmsg = testmsg + "You could try using %s in SSTATE_MIRRORS rather than as an SSTATE_CACHE.\n" % (sstate_dir) return testmsg def check_sanity_tmpdir_change(tmpdir, data):
If the user does not have write permissions to SSTATE_CACHE, detected by the check_create_long_filename() test failing with a "Permission denied" value in strerror, then suggest they might want to use the location as an entry in SSTATE_MIRRORS. Signed-off-by: Joshua Lock <josh@linux.intel.com> --- meta/classes/sanity.bbclass | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)