Patchwork [0/7] Sanity class clean ups

login
register
mail settings
Submitter Joshua Lock
Date May 24, 2012, 12:02 a.m.
Message ID <cover.1337816265.git.josh@linux.intel.com>
Download mbox
Permalink /patch/28509/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib josh/sanity

Comments

Joshua Lock - May 24, 2012, 12:02 a.m.
My recent change to the sanity class to warn users when they don't have R/W
permission to their SSTATE_CACHE directory has caused at least a couple of users
trouble, including the Yocto project autobuilder.

I have been unable to reproduce the issue but after discussionwith Elizabeth and
Chris on #yocto I came up with the following series.

The series includes a revert my original change as it seems the simple logic has
severla edge cases. I replace it later in the series with a simple piggy-back
on the existing check_create_long_filename() call, where I make the suggestion
of using SSTATE_MIRRORS if that call fails with "Permission denied" when called
against SSTATE_DIR. This check has been in use for some time and, to the best of
my knowledge, doesn't trigger invalid failures.

Thanks to Chris and Elizabeth for pointers as to why this was failing.

Cheers,

Joshua

The following changes since commit e6333825c3482a559a0c0499e17f8f48d3042ddf:

  tune-mips64.inc: Add new tune file for mips64 big-endian (2012-05-20 20:24:37 -0700)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib josh/sanity
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/sanity

Joshua Lock (7):
  Revert "sanity.bbclass: check user can read and write to SSTATE_DIR"
  sanity.bbclass: copy the data store and finalise before running
    checks
  sanity.bbclass: data.getVar(VAR, obj, exp) -> obj.getVar(VAR, exp)
  sanity.bbclass: add newline to check_create_long_filename failure
    message
  sanity.bbclass: add extra information when SSTATE_CACHE unusable
  sanity.bbclass: catch an extra exception in
    check_create_long_filename
  sanity.bbclass: check sanity at BuildStarted rather than ConfigParsed

 meta/classes/sanity.bbclass |  153 ++++++++++++++++++++++---------------------
 1 files changed, 78 insertions(+), 75 deletions(-)
Christopher Larson - May 24, 2012, 12:41 a.m.
This series looks quite sane to me. Nicely done.
Saul Wold - May 24, 2012, 6:14 p.m.
On 05/23/2012 05:02 PM, Joshua Lock wrote:
> My recent change to the sanity class to warn users when they don't have R/W
> permission to their SSTATE_CACHE directory has caused at least a couple of users
> trouble, including the Yocto project autobuilder.
>
> I have been unable to reproduce the issue but after discussionwith Elizabeth and
> Chris on #yocto I came up with the following series.
>
> The series includes a revert my original change as it seems the simple logic has
> severla edge cases. I replace it later in the series with a simple piggy-back
> on the existing check_create_long_filename() call, where I make the suggestion
> of using SSTATE_MIRRORS if that call fails with "Permission denied" when called
> against SSTATE_DIR. This check has been in use for some time and, to the best of
> my knowledge, doesn't trigger invalid failures.
>
> Thanks to Chris and Elizabeth for pointers as to why this was failing.
>
> Cheers,
>
> Joshua
>
> The following changes since commit e6333825c3482a559a0c0499e17f8f48d3042ddf:
>
>    tune-mips64.inc: Add new tune file for mips64 big-endian (2012-05-20 20:24:37 -0700)
>
> are available in the git repository at:
>    git://git.openembedded.org/openembedded-core-contrib josh/sanity
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/sanity
>
> Joshua Lock (7):
>    Revert "sanity.bbclass: check user can read and write to SSTATE_DIR"
>    sanity.bbclass: copy the data store and finalise before running
>      checks
>    sanity.bbclass: data.getVar(VAR, obj, exp) ->  obj.getVar(VAR, exp)
>    sanity.bbclass: add newline to check_create_long_filename failure
>      message
>    sanity.bbclass: add extra information when SSTATE_CACHE unusable
>    sanity.bbclass: catch an extra exception in
>      check_create_long_filename
>    sanity.bbclass: check sanity at BuildStarted rather than ConfigParsed
>
>   meta/classes/sanity.bbclass |  153 ++++++++++++++++++++++---------------------
>   1 files changed, 78 insertions(+), 75 deletions(-)
>

Merged the updated version into OE-Core

Thanks
	Sau!