Patchwork [v3] valgrind: Enable valgrind for armv7

login
register
mail settings
Submitter Samuel Stirtzel
Date May 23, 2012, 1:46 p.m.
Message ID <1337780788-30178-1-git-send-email-s.stirtzel@googlemail.com>
Download mbox | patch
Permalink /patch/28467/
State Accepted
Commit 211ac8b39023d4998fb7d5a577b63a4960b08172
Headers show

Comments

Samuel Stirtzel - May 23, 2012, 1:46 p.m.
Valgrind supports the armv7 architecture, this patch allows armv7 users to build and use Valgrind

This patch was run-tested on a Gumstix Overo (armv7a cortex-a8)
* The test consisted of running valgrinds memcheck (memory leakage detection),
* and callgrind (profiling) on a Qt 4 application

Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.7.0.bb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Saul Wold - May 24, 2012, 6:14 p.m.
On 05/23/2012 06:46 AM, Samuel Stirtzel wrote:
> Valgrind supports the armv7 architecture, this patch allows armv7 users to build and use Valgrind
>
> This patch was run-tested on a Gumstix Overo (armv7a cortex-a8)
> * The test consisted of running valgrinds memcheck (memory leakage detection),
> * and callgrind (profiling) on a Qt 4 application
>
> Signed-off-by: Samuel Stirtzel<s.stirtzel@googlemail.com>
> ---
>   meta/recipes-devtools/valgrind/valgrind_3.7.0.bb |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> index d7c7b24..6b54472 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> @@ -23,13 +23,16 @@ SRC_URI[md5sum] = "a855fda56edf05614f099dca316d1775"
>   SRC_URI[sha256sum] = "5d62c0330f1481fe2c593249192fa68ff454c19c34343978cc9ce91aa324cbf6"
>
>   COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64).*-linux'
> +COMPATIBLE_HOST_armv7a = 'arm.*-linux'
>
>   inherit autotools
>
>   EXTRA_OECONF = "--enable-tls"
> +EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi"
>   EXTRA_OEMAKE = "-w"
>   PARALLEL_MAKE = ""
>
>   FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
>   RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
>   RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
> +RRECOMMENDS_${PN}_armv7a += "${TCLIBC}-dbg"

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
index d7c7b24..6b54472 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
@@ -23,13 +23,16 @@  SRC_URI[md5sum] = "a855fda56edf05614f099dca316d1775"
 SRC_URI[sha256sum] = "5d62c0330f1481fe2c593249192fa68ff454c19c34343978cc9ce91aa324cbf6"
 
 COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64).*-linux'
+COMPATIBLE_HOST_armv7a = 'arm.*-linux'
 
 inherit autotools
 
 EXTRA_OECONF = "--enable-tls"
+EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi"
 EXTRA_OEMAKE = "-w"
 PARALLEL_MAKE = ""
 
 FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
 RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
 RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
+RRECOMMENDS_${PN}_armv7a += "${TCLIBC}-dbg"