Patchwork valgrind: Enable valgrind for omap3

login
register
mail settings
Submitter Samuel Stirtzel
Date May 23, 2012, 12:19 p.m.
Message ID <1337775586-32611-1-git-send-email-s.stirtzel@googlemail.com>
Download mbox | patch
Permalink /patch/28419/
State New
Headers show

Comments

Samuel Stirtzel - May 23, 2012, 12:19 p.m.
Valgrind supports the armv7 architecture, this patch allows users of the omap3 soc family to build and use valgrind

This patch was run-tested on a Gumstix Overo (armv7a cortex-a8)
* The test consisted of running valgrinds memcheck (memory leakage detection),
* and callgrind (profiling) on a Qt 4 application

Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.7.0.bb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

\ No newline at end of file
Samuel Stirtzel - May 23, 2012, 12:23 p.m.
2012/5/23 Samuel Stirtzel <s.stirtzel@googlemail.com>:
> Valgrind supports the armv7 architecture, this patch allows users of the omap3 soc family to build and use valgrind
>
> This patch was run-tested on a Gumstix Overo (armv7a cortex-a8)
> * The test consisted of running valgrinds memcheck (memory leakage detection),
> * and callgrind (profiling) on a Qt 4 application
>
> Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
> ---
>  meta/recipes-devtools/valgrind/valgrind_3.7.0.bb |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> index d7c7b24..0311d75 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> @@ -22,14 +22,17 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>  SRC_URI[md5sum] = "a855fda56edf05614f099dca316d1775"
>  SRC_URI[sha256sum] = "5d62c0330f1481fe2c593249192fa68ff454c19c34343978cc9ce91aa324cbf6"
>
> -COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64).*-linux'
> +COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|arm).*-linux'

Oops forgot to change this line back, v2 coming soon.

> +COMPATIBLE_HOST_omap3 = 'arm.*-linux'
>
>  inherit autotools
>
>  EXTRA_OECONF = "--enable-tls"
> +EXTRA_OECONF_omap3 = "--enable-tls -host=armv7-none-linux-gnueabi"
>  EXTRA_OEMAKE = "-w"
>  PARALLEL_MAKE = ""
>
>  FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
>  RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
>  RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
> +RRECOMMENDS_${PN}_omap3 += "libc6-dbg"
> \ No newline at end of file
> --
> 1.7.5.4
>
Martin Jansa - May 23, 2012, 12:25 p.m.
On Wed, May 23, 2012 at 02:23:19PM +0200, Samuel Stirtzel wrote:
> 2012/5/23 Samuel Stirtzel <s.stirtzel@googlemail.com>:
> > Valgrind supports the armv7 architecture, this patch allows users of the omap3 soc family to build and use valgrind
> >
> > This patch was run-tested on a Gumstix Overo (armv7a cortex-a8)
> > * The test consisted of running valgrinds memcheck (memory leakage detection),
> > * and callgrind (profiling) on a Qt 4 application
> >
> > Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
> > ---
> >  meta/recipes-devtools/valgrind/valgrind_3.7.0.bb |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> > index d7c7b24..0311d75 100644
> > --- a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> > +++ b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
> > @@ -22,14 +22,17 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> >  SRC_URI[md5sum] = "a855fda56edf05614f099dca316d1775"
> >  SRC_URI[sha256sum] = "5d62c0330f1481fe2c593249192fa68ff454c19c34343978cc9ce91aa324cbf6"
> >
> > -COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64).*-linux'
> > +COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|arm).*-linux'
> 
> Oops forgot to change this line back, v2 coming soon.
> 
> > +COMPATIBLE_HOST_omap3 = 'arm.*-linux'
> >
> >  inherit autotools
> >
> >  EXTRA_OECONF = "--enable-tls"
> > +EXTRA_OECONF_omap3 = "--enable-tls -host=armv7-none-linux-gnueabi"

Why not for all armv7 machines?

Cheers,

> >  EXTRA_OEMAKE = "-w"
> >  PARALLEL_MAKE = ""
> >
> >  FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
> >  RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
> >  RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
> > +RRECOMMENDS_${PN}_omap3 += "libc6-dbg"
> > \ No newline at end of file
> > --
> > 1.7.5.4
> >
> 
> 
> 
> -- 
> Regards
> Samuel
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Samuel Stirtzel - May 23, 2012, 12:34 p.m.
2012/5/23 Martin Jansa <martin.jansa@gmail.com>:
> On Wed, May 23, 2012 at 02:23:19PM +0200, Samuel Stirtzel wrote:
>> 2012/5/23 Samuel Stirtzel <s.stirtzel@googlemail.com>:
>> > Valgrind supports the armv7 architecture, this patch allows users of the omap3 soc family to build and use valgrind
>> >
>> > This patch was run-tested on a Gumstix Overo (armv7a cortex-a8)
>> > * The test consisted of running valgrinds memcheck (memory leakage detection),
>> > * and callgrind (profiling) on a Qt 4 application
>> >
>> > Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
>> > ---
>> >  meta/recipes-devtools/valgrind/valgrind_3.7.0.bb |    5 ++++-
>> >  1 files changed, 4 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
>> > index d7c7b24..0311d75 100644
>> > --- a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
>> > +++ b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
>> > @@ -22,14 +22,17 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>> >  SRC_URI[md5sum] = "a855fda56edf05614f099dca316d1775"
>> >  SRC_URI[sha256sum] = "5d62c0330f1481fe2c593249192fa68ff454c19c34343978cc9ce91aa324cbf6"
>> >
>> > -COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64).*-linux'
>> > +COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|arm).*-linux'
>>
>> Oops forgot to change this line back, v2 coming soon.
>>
>> > +COMPATIBLE_HOST_omap3 = 'arm.*-linux'
>> >
>> >  inherit autotools
>> >
>> >  EXTRA_OECONF = "--enable-tls"
>> > +EXTRA_OECONF_omap3 = "--enable-tls -host=armv7-none-linux-gnueabi"
>
> Why not for all armv7 machines?

I've thought about that too, ok I will send the next patch with armv7.
But please keep in mind I only tested it on an omap3 device.

Patch

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
index d7c7b24..0311d75 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.7.0.bb
@@ -22,14 +22,17 @@  SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
 SRC_URI[md5sum] = "a855fda56edf05614f099dca316d1775"
 SRC_URI[sha256sum] = "5d62c0330f1481fe2c593249192fa68ff454c19c34343978cc9ce91aa324cbf6"
 
-COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64).*-linux'
+COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|arm).*-linux'
+COMPATIBLE_HOST_omap3 = 'arm.*-linux'
 
 inherit autotools
 
 EXTRA_OECONF = "--enable-tls"
+EXTRA_OECONF_omap3 = "--enable-tls -host=armv7-none-linux-gnueabi"
 EXTRA_OEMAKE = "-w"
 PARALLEL_MAKE = ""
 
 FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*"
 RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg"
 RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg"
+RRECOMMENDS_${PN}_omap3 += "libc6-dbg"