Patchwork [3/3] bluez4: Add 4.91 and make it default for Angstrom

login
register
mail settings
Submitter Tom Rini
Date April 25, 2011, 6:31 p.m.
Message ID <1303756273-22385-4-git-send-email-tom_rini@mentor.com>
Download mbox | patch
Permalink /patch/2821/
State Accepted
Headers show

Comments

Tom Rini - April 25, 2011, 6:31 p.m.
Signed-off-by: Tom Rini <tom_rini@mentor.com>
---
 recipes/bluez/bluez4_4.91.bb |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 recipes/bluez/bluez4_4.91.bb
Koen Kooi - April 25, 2011, 6:33 p.m.
Op 25 apr 2011, om 20:31 heeft Tom Rini het volgende geschreven:

> Signed-off-by: Tom Rini <tom_rini@mentor.com>

I ran into Marcel at ELC, which reminded me to make a recipe, but hadn't pushed it yet. Let's use your version. So:

Acked-by: Koen Kooi <koen@openembedded.org>

> ---
> recipes/bluez/bluez4_4.91.bb |   18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
> create mode 100644 recipes/bluez/bluez4_4.91.bb
> 
> diff --git a/recipes/bluez/bluez4_4.91.bb b/recipes/bluez/bluez4_4.91.bb
> new file mode 100644
> index 0000000..16f06d5
> --- /dev/null
> +++ b/recipes/bluez/bluez4_4.91.bb
> @@ -0,0 +1,18 @@
> +require bluez4.inc
> +
> +SRC_URI[md5sum] = "3059b7ef5168c84cd0c6a67034ce79f9"
> +SRC_URI[sha256sum] = "11e9279e2669db996afd464b96d2c68f41f157f6eb9b8842a0bbcad8a4eac18d"
> +
> +DEFAULT_PREFERENCE = "-1"
> +DEFAULT_PREFERENCE_angstrom = "1"
> +
> +DEPENDS += "libsndfile1"
> +
> +PR = "${INC_PR}.0"
> +
> +# Not all distros have a recent enough udev
> +BTUDEV = " --disable-udevrules"
> +BTUDEV_angstrom = " --enable-udevrules"
> +BTUDEV_shr = " --enable-udevrules"
> +
> +EXTRA_OECONF += "${BTUDEV}"
> -- 
> 1.7.0.4
>
Martin Jansa - April 25, 2011, 6:43 p.m.
On Mon, Apr 25, 2011 at 11:31:13AM -0700, Tom Rini wrote:
> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> ---
>  recipes/bluez/bluez4_4.91.bb |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/bluez/bluez4_4.91.bb
> 
> diff --git a/recipes/bluez/bluez4_4.91.bb b/recipes/bluez/bluez4_4.91.bb
> new file mode 100644
> index 0000000..16f06d5
> --- /dev/null
> +++ b/recipes/bluez/bluez4_4.91.bb
> @@ -0,0 +1,18 @@
> +require bluez4.inc
> +
> +SRC_URI[md5sum] = "3059b7ef5168c84cd0c6a67034ce79f9"
> +SRC_URI[sha256sum] = "11e9279e2669db996afd464b96d2c68f41f157f6eb9b8842a0bbcad8a4eac18d"
> +
> +DEFAULT_PREFERENCE = "-1"
> +DEFAULT_PREFERENCE_angstrom = "1"

please make it default for shr too, we're using bluez4_4.91 now from 
meta-oe and it works ok, so we can keep it in sync, thanks

> +
> +DEPENDS += "libsndfile1"
> +
> +PR = "${INC_PR}.0"
> +
> +# Not all distros have a recent enough udev
> +BTUDEV = " --disable-udevrules"
> +BTUDEV_angstrom = " --enable-udevrules"
> +BTUDEV_shr = " --enable-udevrules"
> +
> +EXTRA_OECONF += "${BTUDEV}"
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Paul Menzel - April 25, 2011, 6:54 p.m.
Dear Tom,


On Mo, 2011-04-25 at 11:31 -0700, Tom Rini wrote:

what build configuration did you use for build testing? Could you add
that to the commit message please.

> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> ---
>  recipes/bluez/bluez4_4.91.bb |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/bluez/bluez4_4.91.bb
> 
> diff --git a/recipes/bluez/bluez4_4.91.bb b/recipes/bluez/bluez4_4.91.bb
> new file mode 100644
> index 0000000..16f06d5
> --- /dev/null
> +++ b/recipes/bluez/bluez4_4.91.bb
> @@ -0,0 +1,18 @@
> +require bluez4.inc
> +
> +SRC_URI[md5sum] = "3059b7ef5168c84cd0c6a67034ce79f9"
> +SRC_URI[sha256sum] = "11e9279e2669db996afd464b96d2c68f41f157f6eb9b8842a0bbcad8a4eac18d"
> +
> +DEFAULT_PREFERENCE = "-1"
> +DEFAULT_PREFERENCE_angstrom = "1"
> +
> +DEPENDS += "libsndfile1"
> +
> +PR = "${INC_PR}.0"
> +
> +# Not all distros have a recent enough udev
> +BTUDEV = " --disable-udevrules"
> +BTUDEV_angstrom = " --enable-udevrules"
> +BTUDEV_shr = " --enable-udevrules"
> +
> +EXTRA_OECONF += "${BTUDEV}"

Please create the patch next time adding `-M -C -C` to `git
format-patch`. Additionally adding the recipe and making it default for
?ngström could have been two commits in my opinion.

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

I will build test with `minimal-uclibc` and report back.


Thanks,

Paul
Tom Rini - April 25, 2011, 7:05 p.m.
On 04/25/2011 11:54 AM, Paul Menzel wrote:
> Dear Tom,
> 
> 
> On Mo, 2011-04-25 at 11:31 -0700, Tom Rini wrote:
> 
> what build configuration did you use for build testing? Could you add
> that to the commit message please.

Done.

>> Signed-off-by: Tom Rini <tom_rini@mentor.com>
>> ---
>>  recipes/bluez/bluez4_4.91.bb |   18 ++++++++++++++++++
>>  1 files changed, 18 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/bluez/bluez4_4.91.bb
>>
>> diff --git a/recipes/bluez/bluez4_4.91.bb b/recipes/bluez/bluez4_4.91.bb
>> new file mode 100644
>> index 0000000..16f06d5
>> --- /dev/null
>> +++ b/recipes/bluez/bluez4_4.91.bb
>> @@ -0,0 +1,18 @@
>> +require bluez4.inc
>> +
>> +SRC_URI[md5sum] = "3059b7ef5168c84cd0c6a67034ce79f9"
>> +SRC_URI[sha256sum] = "11e9279e2669db996afd464b96d2c68f41f157f6eb9b8842a0bbcad8a4eac18d"
>> +
>> +DEFAULT_PREFERENCE = "-1"
>> +DEFAULT_PREFERENCE_angstrom = "1"
>> +
>> +DEPENDS += "libsndfile1"
>> +
>> +PR = "${INC_PR}.0"
>> +
>> +# Not all distros have a recent enough udev
>> +BTUDEV = " --disable-udevrules"
>> +BTUDEV_angstrom = " --enable-udevrules"
>> +BTUDEV_shr = " --enable-udevrules"
>> +
>> +EXTRA_OECONF += "${BTUDEV}"
> 
> Please create the patch next time adding `-M -C -C` to `git
> format-patch`.

Is there a way to shove that into ~/.gitconfig?  Otherwise I'm sure to
forget.

> Additionally adding the recipe and making it default for
> ?ngström could have been two commits in my opinion.

That's a little excessive I think, just because it's largely a given
that Angstrom (and SHR) will be opting to use this and it doesn't add
anything to the bisect'ability of the tree.

> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Just for this one patch I assume.
Eric BENARD - April 25, 2011, 7:18 p.m.
Hi

On 25/04/2011 21:05, Tom Rini wrote:
>> Please create the patch next time adding `-M -C -C` to `git
>> format-patch`.
>
> Is there a way to shove that into ~/.gitconfig?  Otherwise I'm sure to
> forget.
>
http://www.kernel.org/pub/software/scm/git/docs/git-config.html :
diff.renames

     Tells git to detect renames. If set to any boolean value, it will enable 
basic rename detection. If set to "copies" or "copy", it will detect copies, 
as well.

Eric

Patch

diff --git a/recipes/bluez/bluez4_4.91.bb b/recipes/bluez/bluez4_4.91.bb
new file mode 100644
index 0000000..16f06d5
--- /dev/null
+++ b/recipes/bluez/bluez4_4.91.bb
@@ -0,0 +1,18 @@ 
+require bluez4.inc
+
+SRC_URI[md5sum] = "3059b7ef5168c84cd0c6a67034ce79f9"
+SRC_URI[sha256sum] = "11e9279e2669db996afd464b96d2c68f41f157f6eb9b8842a0bbcad8a4eac18d"
+
+DEFAULT_PREFERENCE = "-1"
+DEFAULT_PREFERENCE_angstrom = "1"
+
+DEPENDS += "libsndfile1"
+
+PR = "${INC_PR}.0"
+
+# Not all distros have a recent enough udev
+BTUDEV = " --disable-udevrules"
+BTUDEV_angstrom = " --enable-udevrules"
+BTUDEV_shr = " --enable-udevrules"
+
+EXTRA_OECONF += "${BTUDEV}"