Patchwork python-scons_1.3.0: add `python-native` to `DEPENDS_virtclass-native`

login
register
mail settings
Submitter Paul Menzel
Date April 25, 2011, 3:26 p.m.
Message ID <1303745160.15311.36.camel@mattotaupa>
Download mbox | patch
Permalink /patch/2817/
State Accepted
Commit 9fb55ee61735ef420e468d9a84dee86e16a0480b
Headers show

Comments

Paul Menzel - April 25, 2011, 3:26 p.m.
Date: Mon, 25 Apr 2011 17:18:07 +0200

A clean build fails with the following error [1].

ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/log.do_compile.26596 for further information)
ERROR: Logfile of failure stored in: /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/log.do_compile.26596
Log data follows:
| ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/log.do_compile.26596 for further information)
| + cd /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/scons-1.3.0
| + do_compile
| + distutils_do_compile
| + STAGING_INCDIR=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/include
| + STAGING_LIBDIR=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/lib
| + BUILD_SYS=x86_64-linux
| + HOST_SYS=x86_64-linux
| + /home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/bin/python setup.py build
| /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/run.do_compile.26596: line 94: /home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/bin/python: No such file or directory
| + oefatal 'python setup.py build_ext execution failed.'
| + echo FATAL: 'python setup.py build_ext execution failed.'

Adding `python-native` to `DEPENDS_virtclass-native` as suggested in [1] and done for `python-scons-native_1.2.0` fixes the issue.

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-April/032180.html

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
Søren, please test this patch. By default 1.2.0 is not used for the native recipe.
---
 recipes/python/python-scons_1.3.0.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Søren Holm - April 25, 2011, 6:52 p.m.
Signed-off-by: Søren Holm <sgh@sgh.dk>

Works like a charm. What does DEPENDS_virtclass do ?

Mandag den 25. april 2011 17:26:00 skrev Paul Menzel:
> Date: Mon, 25 Apr 2011 17:18:07 +0200
> 
> A clean build fails with the following error [1].
> 
> ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/log.do_compile.26596 for further information)
> ERROR: Logfile of failure stored in: /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/log.do_compile.26596
> Log data follows:
> | ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/log.do_compile.26596 for further information)
> | + cd /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/scons-1.3.0
> | + do_compile
> | + distutils_do_compile
> | + STAGING_INCDIR=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/include
> | + STAGING_LIBDIR=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/lib
> | + BUILD_SYS=x86_64-linux
> | + HOST_SYS=x86_64-linux
> | + /home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/bin/python setup.py build
> | /home/sgh/oe-new-oe/build-vmc16/tmp/work/x86_64-linux/python-scons-native-1.3.0-r1/temp/run.do_compile.26596: line 94: /home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/x86_64-linux/usr/bin/python: No such file or directory
> | + oefatal 'python setup.py build_ext execution failed.'
> | + echo FATAL: 'python setup.py build_ext execution failed.'
> 
> Adding `python-native` to `DEPENDS_virtclass-native` as suggested in [1] and done for `python-scons-native_1.2.0` fixes the issue.
> 
> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-April/032180.html
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> Søren, please test this patch. By default 1.2.0 is not used for the native recipe.
> ---
>  recipes/python/python-scons_1.3.0.bb |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/python/python-scons_1.3.0.bb b/recipes/python/python-scons_1.3.0.bb
> index 82231f2..5a412cb 100644
> --- a/recipes/python/python-scons_1.3.0.bb
> +++ b/recipes/python/python-scons_1.3.0.bb
> @@ -2,6 +2,7 @@ DESCRIPTION = "A Software Construction Tool"
>  SECTION = "devel/python"
>  PRIORITY = "optional"
>  LICENSE = "MIT"
> +DEPENDS_virtclass-native = "python-native"
>  SRCNAME = "scons"
>  PR = "r1"
>  
>
Paul Menzel - April 26, 2011, 8:58 a.m.
Am Montag, den 25.04.2011, 20:52 +0200 schrieb Søren Holm:
> Signed-off-by: Søren Holm <sgh@sgh.dk>

I used Acked-by instead and pushed it [3]. I think policy in
OpenEmbedded does not differentiate between both versions anyway, but I
am used to [1]. I used Signed-off-by in your commits, because I adapted
the patches or the commit message slightly.

[…]

> What does DEPENDS_virtclass do ?

If I am not mistaken, these are the dependencies for the native package
when `BBCLASSEXTEND` is used [2].

> Mandag den 25. april 2011 17:26:00 skrev Paul Menzel:

[…]

Please do not top post, i. e. please rather remove these full text quote
altogether.


Thanks,

Paul


[1] http://www.kernel.org/doc/Documentation/SubmittingPatches
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/classes/native.bbclass?id=c3604894c130a6596b16abb945d3c57fbf40ef39
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=9fb55ee61735ef420e468d9a84dee86e16a0480b

Patch

diff --git a/recipes/python/python-scons_1.3.0.bb b/recipes/python/python-scons_1.3.0.bb
index 82231f2..5a412cb 100644
--- a/recipes/python/python-scons_1.3.0.bb
+++ b/recipes/python/python-scons_1.3.0.bb
@@ -2,6 +2,7 @@  DESCRIPTION = "A Software Construction Tool"
 SECTION = "devel/python"
 PRIORITY = "optional"
 LICENSE = "MIT"
+DEPENDS_virtclass-native = "python-native"
 SRCNAME = "scons"
 PR = "r1"