Patchwork [1/1] sanity.bbclass: Attach the missing value to a format string.

login
register
mail settings
Submitter Peter Seebach
Date May 17, 2012, 11:45 p.m.
Message ID <3b40004786e28acad94dbb4e059c51f792f508a3.1337298285.git.peter.seebach@windriver.com>
Download mbox | patch
Permalink /patch/27955/
State Accepted
Commit a9f5bf0ed398bf9cb861feaa8b6fefd8645b1d09
Headers show

Comments

Peter Seebach - May 17, 2012, 11:45 p.m.
The tuning changes to sanity.bbclass were almost right, but one of
the messages had a %s with no % operator.

Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Seebach - June 19, 2012, 8:08 p.m.
On Thu, 17 May 2012 18:45:58 -0500
Peter Seebach <peter.seebach@windriver.com> wrote:

> The tuning changes to sanity.bbclass were almost right, but one of
> the messages had a %s with no % operator.
> 
> Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
> ---
>  meta/classes/sanity.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index ff3c413..2bb0266 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -47,7 +47,7 @@ def check_toolchain_tune(data, tune, multilib):
>              tune_errors.append("Tuning '%s' (%s) cannot be used with
> any supported tuning/ABI." % (tune, tuneabi))
>      if tune_errors:
> -        return "Tuning '%s' has the following errors:\n" +
> '\n'.join(tune_errors)
> +        return "Tuning '%s' has the following errors:\n" % tune +
> '\n'.join(tune_errors) 
>  def check_toolchain(data):
>      tune_error_set = []

Just noticed that this seems to have never made it in, should I update
and resend?

-s

Patch

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index ff3c413..2bb0266 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -47,7 +47,7 @@  def check_toolchain_tune(data, tune, multilib):
             tune_errors.append("Tuning '%s' (%s) cannot be used with any supported tuning/ABI." %
                 (tune, tuneabi))
     if tune_errors:
-        return "Tuning '%s' has the following errors:\n" + '\n'.join(tune_errors)
+        return "Tuning '%s' has the following errors:\n" % tune + '\n'.join(tune_errors)
 
 def check_toolchain(data):
     tune_error_set = []