Patchwork [RFC] modutils-initscripts: fix wrong order of module loading happening in udev

login
mail settings
Submitter Gary Thomas
Date April 24, 2011, 12:51 p.m.
Message ID <4DB41CB6.6020809@mlbassoc.com>
Download mbox | patch
Permalink /patch/2789/
State New, archived
Headers show

Comments

Gary Thomas - April 24, 2011, 12:51 p.m.
On 04/23/2011 03:31 PM, Khem Raj wrote:
> On Mon, Apr 4, 2011 at 3:12 PM, Petr Štetiar<ynezz@true.cz>  wrote:
>> In the current state, udev init script is loaded as 3rd and modutils.sh as
>> 20th, so udevadm called in udev init script loads all kernel modules in some
>> unpredictable order, not honoring in any way specified order of modules in
>> /etc/modules. This causes some troubles mainly in the first boot. So to fix
>> this we now move loading of the kernel modules just before we exec udev init
>> script. Example of the current state:
>>
>>         Starting udev
>>         rtc-m48t86 rtc-m48t86: rtc core: registered m48t86 as rtc0
>>         rtc-m48t86 rtc-m48t86: battery ok
>>         ep93xx-rtc ep93xx-rtc: rtc core: registered ep93xx-rtc as rtc1
>>
>>         root@ts72xx:~# cat /etc/modules
>>         rtc-ep93xx
>>         ohci-hcd
>>         ts72xx_sbcinfo
>>         rtc-m48t86
>>
>> As you can guess, this is really wrong behaviour, because I've rtc1 as the
>> main time source for my system.
>>
>>         root@ts72xx:~# cat /etc/default/hwclock
>>         HWCLOCKACCESS=yes
>>         HWCLOCKDEVICE=/dev/rtc1
>>
>> Expected behaviour with this patch applied:
>>
>>         Please wait: booting...
>>         ep93xx-rtc ep93xx-rtc: rtc core: registered ep93xx-rtc as rtc0
>>         usbcore: registered new device driver usb
>>         ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
>>         ...
>>         rtc-m48t86 rtc-m48t86: rtc core: registered m48t86 as rtc1
>>         rtc-m48t86 rtc-m48t86: battery ok
>>         Starting udev
>>
>> Signed-off-by: Petr Štetiar<ynezz@true.cz>
>
> Looks ok.
>
> Acked-by: Khem Raj<raj.khem@gmail.com>
>
>> ---
>>   recipes/modutils/modutils-initscripts.bb |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes/modutils/modutils-initscripts.bb b/recipes/modutils/modutils-initscripts.bb
>> index 07f4810..797acb3 100644
>> --- a/recipes/modutils/modutils-initscripts.bb
>> +++ b/recipes/modutils/modutils-initscripts.bb
>> @@ -2,10 +2,10 @@ SECTION = "base"
>>   DESCRIPTION = "modutils configuration files"
>>   LICENSE = "PD"
>>   SRC_URI = "file://modutils.sh"
>> -PR = "r3"
>> +PR = "r4"
>>
>>   INITSCRIPT_NAME = "modutils.sh"
>> -INITSCRIPT_PARAMS = "start 20 S ."
>> +INITSCRIPT_PARAMS = "start 2 S ."
>>
>>   inherit update-rc.d
>>
>> --
>> 1.7.1

I'm not clear why this information is duplicated, but shouldn't these
changes also be applied to modutils/modutils_2.4.27.bb as well?

Something like this:
Andrea Adami - May 3, 2011, 10:57 p.m.
>>> Signed-off-by: Petr Štetiar<ynezz@true.cz>
>>
>> Looks ok.
>>
>> Acked-by: Khem Raj<raj.khem@gmail.com>

Already in oe-core.

Acked-by: Andrea Adami <andrea.adami@gmail.com>


Pushing
Thanks

Patch

diff --git a/recipes/modutils/modutils_2.4.27.bb b/recipes/modutils/modutils_2.4.27.bb
index 791707c..ef3f152 100644
--- a/recipes/modutils/modutils_2.4.27.bb
+++ b/recipes/modutils/modutils_2.4.27.bb
@@ -3,7 +3,7 @@  DESCRIPTION = "These utilities are intended to make a Linux modular kernel \
  manageable for all users, administrators and distribution maintainers."
  LICENSE = "GPLv2"
  DEPENDS = "bison-native"
-PR = "r8"
+PR = "r9"

  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/utils/kernel/modutils/v2.4/modutils-${PV}.tar.bz2 \
             file://lex.l.diff \
@@ -46,7 +46,7 @@  if test -n "$D"; then
                 done
         fi
  fi
-update-rc.d $D modutils.sh start 20 S .
+update-rc.d $D modutils.sh start 2 S .
  }

  pkg_prerm_modutils () {