Patchwork [bitbake-devel,2/2] lib/bb/siggen.py: ensure dumped signatures have group R/W

login
register
mail settings
Submitter Joshua Lock
Date May 12, 2012, 1:21 a.m.
Message ID <1336785711-13353-1-git-send-email-josh@linux.intel.com>
Download mbox | patch
Permalink /patch/27497/
State Accepted
Commit e4716f316152cafabebcefec7b387edeb02ad3eb
Headers show

Comments

Joshua Lock - May 12, 2012, 1:21 a.m.
We anticipate signatures being shared amongst peers in a group so ensure
they have rw-rw-r-- permissions to facilitate this.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/siggen.py |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Richard Purdie - May 13, 2012, 7:02 p.m.
On Fri, 2012-05-11 at 18:21 -0700, Joshua Lock wrote:
> We anticipate signatures being shared amongst peers in a group so ensure
> they have rw-rw-r-- permissions to facilitate this.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  lib/bb/siggen.py |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

Merged to master (along with 1/2) thanks.

Richard

Patch

diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index ca26919..5a0b80e 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -201,8 +201,10 @@  class SignatureGeneratorBasic(SignatureGenerator):
             for dep in data['runtaskdeps']:
                 data['runtaskhashes'][dep] = self.taskhash[dep]
 
-        p = pickle.Pickler(open(sigfile, "wb"), -1)
-        p.dump(data)
+        with open(sigfile, "wb") as f:
+            p = pickle.Pickler(f, -1)
+            p.dump(data)
+        os.chmod(sigfile, 0664)
 
     def dump_sigs(self, dataCache):
         for fn in self.taskdeps: