| Submitter | Joshua Lock |
|---|---|
| Date | May 12, 2012, 1 a.m. |
| Message ID | <1336784426-22337-1-git-send-email-josh@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/27495/ |
| State | Accepted |
| Commit | 0c0c4efbf92bcf0f8942f17c18525a4b4ed1798c |
| Headers | show |
Comments
On 05/12/2012 04:00 AM, Joshua Lock wrote: > The user needs read and write permissions to SSTATE_DIR, check > whether they have sufficient permissions and if not recommend > use of SSTATE_MIRRORS. > > Signed-off-by: Joshua Lock<josh@linux.intel.com> > --- > meta/classes/sanity.bbclass | 17 ++++++++++++++--- > 1 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index 05545f4..ff3c413 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -96,10 +96,16 @@ def check_conf_exists(fn, data): > def check_sanity_sstate_dir_change(sstate_dir, data): > # Sanity checks to be done when the value of SSTATE_DIR changes > > - # Check that SSTATE_DIR isn't on a filesystem with limited filename length (eg. eCryptFS) > testmsg = "" > if sstate_dir != "": > - testmsg = check_create_long_filename(sstate_dir, "SSTATE_DIR") > + # Check that the user can read and write to SSTATE_DIR > + sstatemsg = check_can_read_write_directory(sstate_dir) or None > + if sstatemsg: > + sstatemsg = sstatemsg + ". You could try using it as an SSTATE_MIRRORS instead of SSTATE_CACHE.\n" > + testmsg = testmsg + sstatemsg > + # Check that SSTATE_DIR isn't on a filesystem with limited filename length (eg. eCryptFS) > + testmsg = testmsg + check_create_long_filename(sstate_dir, "SSTATE_DIR") > + > return testmsg > > def check_sanity_tmpdir_change(tmpdir, data): > @@ -150,7 +156,12 @@ def check_create_long_filename(filepath, pathname): > if errno == 36: # ENAMETOOLONG > return "Failed to create a file with a long name in %s. Please use a filesystem that does not unreasonably limit filename length.\n" % pathname > else: > - return "Failed to create a file in %s: %s" % (pathname, strerror) > + return "Failed to create a file in %s: %s\n" % (pathname, strerror) > + return "" > + > +def check_can_read_write_directory(directory): > + if not os.access(directory, os.R_OK|os.W_OK): > + return "Insufficient permissions for %s" % directory > return "" > > def check_connectivity(d): Merged into OE-Core along with the state.bbclass change Thanks Sau!
Patch
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 05545f4..ff3c413 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -96,10 +96,16 @@ def check_conf_exists(fn, data): def check_sanity_sstate_dir_change(sstate_dir, data): # Sanity checks to be done when the value of SSTATE_DIR changes - # Check that SSTATE_DIR isn't on a filesystem with limited filename length (eg. eCryptFS) testmsg = "" if sstate_dir != "": - testmsg = check_create_long_filename(sstate_dir, "SSTATE_DIR") + # Check that the user can read and write to SSTATE_DIR + sstatemsg = check_can_read_write_directory(sstate_dir) or None + if sstatemsg: + sstatemsg = sstatemsg + ". You could try using it as an SSTATE_MIRRORS instead of SSTATE_CACHE.\n" + testmsg = testmsg + sstatemsg + # Check that SSTATE_DIR isn't on a filesystem with limited filename length (eg. eCryptFS) + testmsg = testmsg + check_create_long_filename(sstate_dir, "SSTATE_DIR") + return testmsg def check_sanity_tmpdir_change(tmpdir, data): @@ -150,7 +156,12 @@ def check_create_long_filename(filepath, pathname): if errno == 36: # ENAMETOOLONG return "Failed to create a file with a long name in %s. Please use a filesystem that does not unreasonably limit filename length.\n" % pathname else: - return "Failed to create a file in %s: %s" % (pathname, strerror) + return "Failed to create a file in %s: %s\n" % (pathname, strerror) + return "" + +def check_can_read_write_directory(directory): + if not os.access(directory, os.R_OK|os.W_OK): + return "Insufficient permissions for %s" % directory return "" def check_connectivity(d):
The user needs read and write permissions to SSTATE_DIR, check whether they have sufficient permissions and if not recommend use of SSTATE_MIRRORS. Signed-off-by: Joshua Lock <josh@linux.intel.com> --- meta/classes/sanity.bbclass | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-)