Patchwork [bitbake-devel] bitbake/runqueue: Drop check_stamp_fn, its obsolete and should not be used

login
mail settings
Submitter Richard Purdie
Date May 10, 2012, 8:23 a.m.
Message ID <1336638191.2494.122.camel@ted>
Download mbox | patch
Permalink /patch/27439/
State New
Headers show

Comments

Richard Purdie - May 10, 2012, 8:23 a.m.
This function was used by old code such as packaged staging but is thankfully
obsolete now and replaced with better mechanisms. Its time to remove it and
the horrible internal only variables associated with it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 8d56331..5bf9056 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -1080,8 +1080,6 @@  class RunQueueExecute:
                 os.umask(umask)
 
             self.cooker.configuration.data.setVar("BB_WORKERCONTEXT", "1")
-            self.cooker.configuration.data.setVar("__RUNQUEUE_DO_NOT_USE_EXTERNALLY", self)
-            self.cooker.configuration.data.setVar("__RUNQUEUE_DO_NOT_USE_EXTERNALLY2", fn)
             bb.parse.siggen.set_taskdata(self.rqdata.hashes, self.rqdata.hash_deps)
             ret = 0
             try:
@@ -1692,15 +1690,6 @@  class runQueueTaskCompleted(runQueueEvent):
     Event notifing a task completed
     """
 
-def check_stamp_fn(fn, taskname, d):
-    rqexe = d.getVar("__RUNQUEUE_DO_NOT_USE_EXTERNALLY")
-    fn = d.getVar("__RUNQUEUE_DO_NOT_USE_EXTERNALLY2")
-    fnid = rqexe.rqdata.taskData.getfn_id(fn)
-    taskid = rqexe.rqdata.get_task_id(fnid, taskname)
-    if taskid is not None:
-        return rqexe.rq.check_stamp_task(taskid)
-    return None
-
 class runQueuePipe():
     """
     Abstraction for a pipe between a worker thread and the server